Re: Commiter needed for PR 200652
Hi! > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 [...] > I'm not a committer, but i take a short look at it. I think you should > make a little more QA. That is a good suggestion. The port has been added to the tree. Thanks! -- p...@opsec.eu+49 171 3101372 5 years to go ! ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Commiter needed for PR 200652
Torsten Zuehlsdorff wrote: > > > On 09.10.2015 14:53, Torsten Zuehlsdorff wrote: >> Hello, >> >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 >>> >>> It's glue to use the existing ports >>> >>> p5-CGI-ExtDirect >>> p5-RPC-ExtDirect >>> >>> with plack environment. >>> >>> It's been open since June, so perhaps someone could take pity and >>> commit it? :-D >> >> I'm not a committer, but i take a short look at it. I think you should >> make a little more QA. >> >> First i see there is a PORTEPOCH. Since this is a new port, this line >> should be there. > > There is a "not" missing ;) PORTEPOCH is not required for a new port. From: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html -> It is expected that PORTEPOCH will not be used for the majority of ports, and that sensible use of PORTVERSION can often preempt it becoming necessary if a future release of the software changes the version structure. Regards, -- Michelle Sullivan http://www.mhix.org/ ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Commiter needed for PR 200652
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 It's glue to use the existing ports p5-CGI-ExtDirect p5-RPC-ExtDirect with plack environment. It's been open since June, so perhaps someone could take pity and commit it? :-D Thanks! Martin signature.asc Description: Message signed with OpenPGP using GPGMail
Re: Commiter needed for PR 200652
Hello, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 It's glue to use the existing ports p5-CGI-ExtDirect p5-RPC-ExtDirect with plack environment. It's been open since June, so perhaps someone could take pity and commit it? :-D I'm not a committer, but i take a short look at it. I think you should make a little more QA. First i see there is a PORTEPOCH. Since this is a new port, this line should be there. Also you comment out an build dependency. Better to remove it completely. It is also a good idea to use "portlint -AC" against the new port and add some poudriere logs, which proves everything works fine. If you need any help with this, feel free to contact me. Greetings, Torsten ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Commiter needed for PR 200652
On 09.10.2015 14:53, Torsten Zuehlsdorff wrote: Hello, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 It's glue to use the existing ports p5-CGI-ExtDirect p5-RPC-ExtDirect with plack environment. It's been open since June, so perhaps someone could take pity and commit it? :-D I'm not a committer, but i take a short look at it. I think you should make a little more QA. First i see there is a PORTEPOCH. Since this is a new port, this line should be there. There is a "not" missing ;) Greetings, Torsten ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
