Re: How to remove erroneous deps from pkgng
On Mon, Jul 23, 2012 at 08:04:44PM -0400, Jason E. Hale wrote: On Monday, July 23, 2012 20:50:34 Baptiste Daroussin wrote: Here is a plan for pkg-config, I hope it will statisfy everyone. First we need to get rid of pkg-config, since 0.26 we can't boostrap it anymore because it depends on glib which depends on pkg-config. Hopefully we have a viable alternative. What I will do is : step 1/ introduce a new pkgconf port (https://github.com/nenolod/pkgconf) which is 100% compatible with pkg-config and considers any incompatibility as a bug. along with this, I will introduce a new MACRO: http://people.freebsd.org/~bapt/USE_PKGCONFIG.diff USE_PKGCONFIG= yes or USE_PKGCONFIG= build will bring pkgconf only has a build dependency USE_PKGCONFIG= run will bring pkgconf has a run dependency (some things like ruby wrapper or perl wrapper) USE_PKGCONFIG= both will bring both run and build deps. Why a MACRO, because some ports may need en environnement variable in CONFIGURE_ENV PKG_CONFIG=pkgconf do work correctly. the USE_GNOME= pkgconfig will be automatically add USE_PKGCONFIG= both Yeah sorry for step one will keep pkgconf in both dependencies. This is necessary because too much ports rely on one of their deps bringing pkgconfig, and this concerns about 4k+ ports. All the gnome one (mostly), all the xorg one (xproto bring pkgconfig) most of the gtk ones, most of things depending on libxml2 and curl, from what I have seen. step 2/ advertise the maintainers to stop using USE_GNOME= pkgconfig but rather switch to USE_PKGCONFIG, and do it actively. setp 3/ drop USE_GNOME= pkgconfig from bsd.gnome.mk when switching to USE_PKGCONFIG becare full about the ports that depend on your ports to make sure, it doesn't expect pkgconfig being brought by your port. regards, Bapt I think it might be a good idea to factor out the pkg-config hacks provided by USE_GNOME=gnomehack as well, and expand it to work with CMake (or other build systems if needed). Most ports that install .pc files must be fixed to install them in libdata instead of lib. Jason E. Hale That is a good idea, good be done after the switch to pkgconf. It will need some volunteer :) regards, Bapt pgpQmsdoIGCqm.pgp Description: PGP signature
Re: Re: How to remove erroneous deps from pkgng
On Mon, 23 Jul 2012 04:37:08 +0300 Kimmo Paasiala wrote: Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. Right. It defaults to both build and run dependency if no type is specified. This is not correct. For example, USE_KDE4= automoc4 (without any suffix) will bring BUILD only dependency on devel/automoc4. The great majority ports don't need ever possibility to run depend on build tools like automoc4, but kde4.mk still provides it (the only consumer if automoc4_run can be IDE, I suppose). The way USE_KDE4 is implemented allows to minimize the use of suffixes, that's the right way in my understanding. Max ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Mon, Jul 23, 2012 at 01:31:52PM +, Max Brazhnikov wrote: On Mon, 23 Jul 2012 04:37:08 +0300 Kimmo Paasiala wrote: Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. Right. It defaults to both build and run dependency if no type is specified. This is not correct. For example, USE_KDE4= automoc4 (without any suffix) will bring BUILD only dependency on devel/automoc4. The great majority ports don't need ever possibility to run depend on build tools like automoc4, but kde4.mk still provides it (the only consumer if automoc4_run can be IDE, I suppose). The way USE_KDE4 is implemented allows to minimize the use of suffixes, that's the right way in my understanding. Max ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Here is a plan for pkg-config, I hope it will statisfy everyone. First we need to get rid of pkg-config, since 0.26 we can't boostrap it anymore because it depends on glib which depends on pkg-config. Hopefully we have a viable alternative. What I will do is : step 1/ introduce a new pkgconf port (https://github.com/nenolod/pkgconf) which is 100% compatible with pkg-config and considers any incompatibility as a bug. along with this, I will introduce a new MACRO: http://people.freebsd.org/~bapt/USE_PKGCONFIG.diff USE_PKGCONFIG= yes or USE_PKGCONFIG= build will bring pkgconf only has a build dependency USE_PKGCONFIG= run will bring pkgconf has a run dependency (some things like ruby wrapper or perl wrapper) USE_PKGCONFIG= both will bring both run and build deps. Why a MACRO, because some ports may need en environnement variable in CONFIGURE_ENV PKG_CONFIG=pkgconf do work correctly. the USE_GNOME= pkgconfig will be automatically add USE_PKGCONFIG= both Yeah sorry for step one will keep pkgconf in both dependencies. This is necessary because too much ports rely on one of their deps bringing pkgconfig, and this concerns about 4k+ ports. All the gnome one (mostly), all the xorg one (xproto bring pkgconfig) most of the gtk ones, most of things depending on libxml2 and curl, from what I have seen. step 2/ advertise the maintainers to stop using USE_GNOME= pkgconfig but rather switch to USE_PKGCONFIG, and do it actively. setp 3/ drop USE_GNOME= pkgconfig from bsd.gnome.mk when switching to USE_PKGCONFIG becare full about the ports that depend on your ports to make sure, it doesn't expect pkgconfig being brought by your port. regards, Bapt pgpKLnadxSTkq.pgp Description: PGP signature
Re: How to remove erroneous deps from pkgng
On Monday, July 23, 2012 20:50:34 Baptiste Daroussin wrote: Here is a plan for pkg-config, I hope it will statisfy everyone. First we need to get rid of pkg-config, since 0.26 we can't boostrap it anymore because it depends on glib which depends on pkg-config. Hopefully we have a viable alternative. What I will do is : step 1/ introduce a new pkgconf port (https://github.com/nenolod/pkgconf) which is 100% compatible with pkg-config and considers any incompatibility as a bug. along with this, I will introduce a new MACRO: http://people.freebsd.org/~bapt/USE_PKGCONFIG.diff USE_PKGCONFIG= yes or USE_PKGCONFIG= build will bring pkgconf only has a build dependency USE_PKGCONFIG= run will bring pkgconf has a run dependency (some things like ruby wrapper or perl wrapper) USE_PKGCONFIG= both will bring both run and build deps. Why a MACRO, because some ports may need en environnement variable in CONFIGURE_ENV PKG_CONFIG=pkgconf do work correctly. the USE_GNOME=pkgconfig will be automatically add USE_PKGCONFIG= both Yeah sorry for step one will keep pkgconf in both dependencies. This is necessary because too much ports rely on one of their deps bringing pkgconfig, and this concerns about 4k+ ports. All the gnome one (mostly), all the xorg one (xproto bring pkgconfig) most of the gtk ones, most of things depending on libxml2 and curl, from what I have seen. step 2/ advertise the maintainers to stop using USE_GNOME= pkgconfig but rather switch to USE_PKGCONFIG, and do it actively. setp 3/ drop USE_GNOME= pkgconfig from bsd.gnome.mk when switching to USE_PKGCONFIG becare full about the ports that depend on your ports to make sure, it doesn't expect pkgconfig being brought by your port. regards, Bapt I think it might be a good idea to factor out the pkg-config hacks provided by USE_GNOME=gnomehack as well, and expand it to work with CMake (or other build systems if needed). Most ports that install .pc files must be fixed to install them in libdata instead of lib. Jason E. Hale ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Re: How to remove erroneous deps from pkgng
On Sat, 21 Jul 2012 21:56:49 -0700 Doug Barton wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. KDE 4 ports don't require pkgconfig although they may use it if available. If some ports strongly rely on pkgconfig and don't set USE_GNOME properly they must be fixed. So let have exp-run first. Max ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Sat, Jul 21, 2012 at 11:56 PM, Doug Barton do...@freebsd.org wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. On 07/21/2012 21:33, Jeremy Messenger wrote: On Sat, Jul 21, 2012 at 4:04 PM, Doug Barton do...@freebsd.org wrote: On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. snip It is unnecessary to be in hurry when that pkg-config has been in the bsd.gnome.mk for about nine years. The sooner we start fixing it, the better off we are. I already have a better solution available for weeks. Therefore, you (and others) need to be patient because when I add the :build/:run dependency in the bsd.gnome.mk then that pkg-config runtime dependency will be re-added. Um, yeah ... don't do that. You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. I mis-attributed your patch to Jason previously, sorry about that. But before it goes in your patch should have the logic I spoke about in my previous posts, to make sure that the USE_GNOME bits cannot get added as the wrong kinds of deps. And no I am not going to work on chase all ports to have the 'pkgconfig:build' (sorry). Not asking you to. I'm asking you to fix your patch so that things that should only be one kind of dep or the other (like pkgconfig, but not necessarily limited to it) are handled properly by default if the right :label is not attached, and error out if the wrong one is. That way the work that's being done now to fix ports that need explicit build deps for pkg-config will solve this part of the problem for you. As you pointed out, the current situation has existed for a long time already. If we have to wait another week or 2 for the pkg-config run dep problem to be fixed properly before your patch gets committed, that's not really a problem. Doug -- Change is hard. -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. And you want me to respect that? -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/22/2012 06:10, Max Brazhnikov wrote: On Sat, 21 Jul 2012 21:56:49 -0700 Doug Barton wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. KDE 4 ports don't require pkgconfig although they may use it if available. If some ports strongly rely on pkgconfig and don't set USE_GNOME properly they must be fixed. So let have exp-run first. Okey dokey. -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Re: How to remove erroneous deps from pkgng
On Sun, 22 Jul 2012 09:51:40 -0500 Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. in kde4.mk we support not only run/build suffixes, but also have default dependence type if suffix is not set. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. Why should we change lots of ports and always keep eyes on new ports, if it can be altered once in .mk ?? Max ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Re: How to remove erroneous deps from pkgng
On Sun, Jul 22, 2012 at 6:22 PM, Max Brazhnikov m...@freebsd.org wrote: On Sun, 22 Jul 2012 09:51:40 -0500 Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. in kde4.mk we support not only run/build suffixes, but also have default dependence type if suffix is not set. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. Why should we change lots of ports and always keep eyes on new ports, if it can be altered once in .mk ?? Because it's not a right solution. There are very few need pkg-config in the runtime dependency. Also I already have designed feature that way (it's not for pkg-config, but all stuff in the bsd.gnome.mk) and it doesn't break anything by defaut. But don't worry because bapt, kwm and I have discussed about add USE_PKGCONFIG in the bsd.port.mk and rip pkg-config out of bsd.gnome.mk. It's even better, but I know it's more work like USE_GNOME=pkgconfig:build. Cheers, Mezz Max -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Sun, Jul 22, 2012 at 4:16 PM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? Remove the runtime dependency is a bug either because there are a few that need it in the runtime dependency. I have written a best solution than remove that runtime line. It will be 99% bug free when all ports have the right :build/:run. And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. Quiet simple, I do not have time for that huge project. I already have added :build/:run feature before anyone complain about the pkg-config dependency. The feature happened to address this issue and fix all pkg-config dependency was not part of my TODO list. My method does not break before or after patch any port, but still have the wrong dependency which it's minor and can be fixed by edit to pkgconfig:build. And you want me to respect that? -- Change is hard. -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Mon, Jul 23, 2012 at 4:22 AM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 17:50, Jeremy Messenger wrote: On Sun, Jul 22, 2012 at 4:16 PM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? Remove the runtime dependency is a bug either because there are a few that need it in the runtime dependency. Which ports are those? And even if these ports exist, an explicit run dep can be added for them. Better to add one more dep for a few ports than bogus ones for thousands. I have written a best solution than remove that runtime line. It will be 99% bug free when all ports have the right :build/:run. I'm interested in your feedback to Max' point that the equivalent functionality for kde.mk already has the right logic to handle proper defaults if the right :label isn't set. And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. Quiet simple, I do not have time for that huge project. That's fine, stand aside and let people who are willing to solve the problem properly do the work. Then when your patch is in proper shape it can be committed without fear of adding new bugs, or re-adding old ones. The position you're taking that we can't fix the bug because you demand your right to get *your* patch in is entirely unreasonable. Doug -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. It defaults to both build and run dependency if no type is specified. In my opinion Jeremy's solution would be fine for now, least amount of immediate destruction :P Regards, Kimmo Paasiala ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/20/2012 22:02, Jeremy Messenger wrote: I prefer to leave it alone and port a feature that I have added in the bsd.mate.mk (repocopied from bsd.gnome.mk) that support 'USE_GNOME= foo:build bar:run foobar'. The 'foobar' without the :* means that it's both build/run time dependency. It's available at: http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/ports-experimental/Mk/bsd.mate.mk That sounds like a good fix, although it doesn't look like pkg-config was pulled over. If you decide to do it this way there should probably be a test for things that cannot be one type of dependency or the other so that someone who used pkgconfig:run would get a helpful error message. And of course for things that don't have a : they should get appropriate defaults. By my count there are over 10k ports using just pkgconfig, it's probably a larger number that use other gnome bits. Baptiste already volunteered to do an exp-run for this topic on Monday. If you don't have time to get your changes ready before then IMO we should go ahead with removing the line from bsd.gnome.mk. Making that correct fix now won't negatively affect your ability to make a different/better change later; but doing it now will give us more opportunity to see the results and fix any regressions. If you decide to go forward, please file a PR with your change, and coordinate with Baptiste. Thanks! Doug -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Friday, July 20, 2012 23:35:10 Doug Barton wrote:
Baptiste already volunteered to do an exp-run for this topic on Monday.
If you don't have time to get your changes ready before then IMO we
should go ahead with removing the line from bsd.gnome.mk. Making that
correct fix now won't negatively affect your ability to make a
different/better change later; but doing it now will give us more
opportunity to see the results and fix any regressions.
The problem with simply removing
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
from bsd.gnome.mk is that there are ports that indirectly depend on pkg-config
for their build through other ports that directly depend on it since it has
just been a runtime dependency. I know there are quite a few KDE ports like
that.
To explain better, x11/kdelibs4 has USE_GNOME=pkgconfig, but some ports that
depend on kdelibs4 and require pkg-config for their build are not currently
defining USE_GNOME=pkgconfig since it is assumed that pkg-config is installed.
A direct dependency for pkg-config would need to be added to all of those
ports.
I think there would be a lot less breakage if the line in bsd.gnome.mk were
left in for now and we migrated over to the pkgconfig:build/run scheme.
Jason E. Hale
KDE/FreeBSD Team
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Sat, Jul 21, 2012 at 6:59 AM, Jason E. Hale bsdkaf...@gmail.com wrote:
On Friday, July 20, 2012 23:35:10 Doug Barton wrote:
Baptiste already volunteered to do an exp-run for this topic on Monday.
If you don't have time to get your changes ready before then IMO we
should go ahead with removing the line from bsd.gnome.mk. Making that
correct fix now won't negatively affect your ability to make a
different/better change later; but doing it now will give us more
opportunity to see the results and fix any regressions.
The problem with simply removing
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
from bsd.gnome.mk is that there are ports that indirectly depend on pkg-config
for their build through other ports that directly depend on it since it has
just been a runtime dependency. I know there are quite a few KDE ports like
that.
Removing this runtime dependency for pkgconfig from bsd.gnome.mk is
the correct thing to do, until we have the better frame work to
specify that pkgconfig is a build or run dependancy.
To explain better, x11/kdelibs4 has USE_GNOME=pkgconfig, but some ports that
depend on kdelibs4 and require pkg-config for their build are not currently
defining USE_GNOME=pkgconfig since it is assumed that pkg-config is installed.
A direct dependency for pkg-config would need to be added to all of those
ports.
That is what the experimental run will tell us. Which ports break
when this line is removed/disabled in bsd.gnome.mk. This way we can
fix those ports by adding a BUILD_DEPENDS to them.
I think there would be a lot less breakage if the line in bsd.gnome.mk were
left in for now and we migrated over to the pkgconfig:build/run scheme.
We would still have the same amount of breakage. In your example
x11/kdelibs4 would be changed to USE_GNOME=pkgconfig:build. The ports
that still have an indirect build dependancy on pkgconfig would still
fail to build.
Scot
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Saturday, July 21, 2012 11:38:39 Scot Hetzel wrote:
The problem with simply removing
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
from bsd.gnome.mk is that there are ports that indirectly depend on
pkg-config for their build through other ports that directly depend on it
since it has just been a runtime dependency. I know there are quite a
few KDE ports like that.
Removing this runtime dependency for pkgconfig from bsd.gnome.mk is
the correct thing to do, until we have the better frame work to
specify that pkgconfig is a build or run dependancy.
IMO I don't really see what the hurry is. This has been the behavior for
years. I think we can wait until there is a framework in place so we are not
doing double work. I agree it should be done, but why go through all this
again in a week or a month?
To explain better, x11/kdelibs4 has USE_GNOME=pkgconfig, but some ports
that depend on kdelibs4 and require pkg-config for their build are not
currently defining USE_GNOME=pkgconfig since it is assumed that
pkg-config is installed. A direct dependency for pkg-config would need to
be added to all of those ports.
That is what the experimental run will tell us. Which ports break
when this line is removed/disabled in bsd.gnome.mk. This way we can
fix those ports by adding a BUILD_DEPENDS to them.
There are a few ports that need pkg-config to properly configure, but will
build anyways without it. Just doing an exp-run isn't going to neccessarily
test for those (graphics/kipi-plugins-kde4 is a good example although in that
case there may be some file leftovers to give it away). Certain non-default
options may use pkg-config to check a dependency as well and a default build
wouldn't tell us if those options worked or not.
I think there would be a lot less breakage if the line in bsd.gnome.mk
were
left in for now and we migrated over to the pkgconfig:build/run scheme.
We would still have the same amount of breakage. In your example
x11/kdelibs4 would be changed to USE_GNOME=pkgconfig:build. The ports
that still have an indirect build dependancy on pkgconfig would still
fail to build.
I see what you're saying. I was originally thinking that it would still
remain as USE_GNOME=pkgconfig, meaning pkg-config is a build and run
dependency and we could opt-in to either :build or :run later.
My main concern is with ports like graphics/kipi-plugins-kde4 where the
failure isn't going to be as obvious. I think a good alternative is to detect
the ports that currently have and indirect dependency on pkg-config whether
needed or not and add USE_GNOME=pkgconfig (if we are just going to remove the
line from bsd.gnome.mk) to them for now.
Jason E. Hale
KDE/FreeBSD Team
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. I read your message as containing some degree of concern that if we fix this particular problem the simple way now that it will reduce the motivation to bring in your patch later. I assure you that's not the case. The idea you have is a good one, and once it's a bit more fleshed out I can't imagine that it would be rejected. If my reading of this is wrong, my apologies. I think we can wait until there is a framework in place so we are not doing double work. I agree it should be done, but why go through all this again in a week or a month? But as Scot pointed out, this is not double work. Things that need build-deps for pkg-config need to have them added, no matter how it's done. In fact, if you read my previous message carefully you would see that by adding USE_GNOME= pkgconfig now, after making it a run-only dep, nothing has to change immediately when your patch is added because your patch will contain the proper support for making sure that pkgconfig stays run-only. Then down the road if people want to change pkgconfig to pkgconfig:run to be more clear, they can. But they won't have to. There are a few ports that need pkg-config to properly configure, but will build anyways without it. Just doing an exp-run isn't going to neccessarily test for those (graphics/kipi-plugins-kde4 is a good example although in that case there may be some file leftovers to give it away). Certain non-default options may use pkg-config to check a dependency as well and a default build wouldn't tell us if those options worked or not. For all the ports you know of now that fall into the category of need pkg-config as a build dep but do not have it set please submit a PR, today. Even if you just list the names of the ports. That would be a big help. I see what you're saying. I was originally thinking that it would still remain as USE_GNOME=pkgconfig, meaning pkg-config is a build and run dependency and we could opt-in to either :build or :run later. pkg-config should never be a run dep. As I pointed out in my previous message, your patch should contain knowledge about what features cannot be which kind of dep. It should use this knowledge to default to the right type if unspecified, and error out if it is specified wrong. My main concern is with ports like graphics/kipi-plugins-kde4 where the failure isn't going to be as obvious. I think a good alternative is to detect the ports that currently have and indirect dependency on pkg-config whether needed or not and add USE_GNOME=pkgconfig (if we are just going to remove the line from bsd.gnome.mk) to them for now. For the ones you are already aware of, please submit a PR. For the others, how do you propose to do the detection? Doug -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Sat, Jul 21, 2012 at 4:04 PM, Doug Barton do...@freebsd.org wrote: On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. snip It is unnecessary to be in hurry when that pkg-config has been in the bsd.gnome.mk for about nine years. I already have a better solution available for weeks. Therefore, you (and others) need to be patient because when I add the :build/:run dependency in the bsd.gnome.mk then that pkg-config runtime dependency will be re-added. And no I am not going to work on chase all ports to have the 'pkgconfig:build' (sorry). -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. On 07/21/2012 21:33, Jeremy Messenger wrote: On Sat, Jul 21, 2012 at 4:04 PM, Doug Barton do...@freebsd.org wrote: On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. snip It is unnecessary to be in hurry when that pkg-config has been in the bsd.gnome.mk for about nine years. The sooner we start fixing it, the better off we are. I already have a better solution available for weeks. Therefore, you (and others) need to be patient because when I add the :build/:run dependency in the bsd.gnome.mk then that pkg-config runtime dependency will be re-added. Um, yeah ... don't do that. I mis-attributed your patch to Jason previously, sorry about that. But before it goes in your patch should have the logic I spoke about in my previous posts, to make sure that the USE_GNOME bits cannot get added as the wrong kinds of deps. And no I am not going to work on chase all ports to have the 'pkgconfig:build' (sorry). Not asking you to. I'm asking you to fix your patch so that things that should only be one kind of dep or the other (like pkgconfig, but not necessarily limited to it) are handled properly by default if the right :label is not attached, and error out if the wrong one is. That way the work that's being done now to fix ports that need explicit build deps for pkg-config will solve this part of the problem for you. As you pointed out, the current situation has existed for a long time already. If we have to wait another week or 2 for the pkg-config run dep problem to be fixed properly before your patch gets committed, that's not really a problem. Doug -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
How to remove erroneous deps from pkgng
I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 7/20/2012 11:57 AM, Reko Turja wrote: I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? Which port is pulling it in? In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. If the port defines invalid dependencies, it's not pkgng's problem, it's the port. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org -- Regards, Bryan Drewery bdrewery@freenode/EFNet ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 8:01 PM, Bryan Drewery br...@shatow.net wrote: On 7/20/2012 11:57 AM, Reko Turja wrote: I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? Which port is pulling it in? In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. If the port defines invalid dependencies, it's not pkgng's problem, it's the port. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org -- Regards, Bryan Drewery bdrewery@freenode/EFNet ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org I think this is the effect of recursive dependencies. If port B directly depends on port C and A directly depends on B, then port A has both ports B and C as its dependencies. Replace C with devel/pkg-config and you get the picture. The port devel/pkg-config is used in many ports, there's no harm in installing it. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
-Original Message- From: Bryan Drewery On 7/20/2012 11:57 AM, Reko Turja wrote: I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? Which port is pulling it in? sqlite3 In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. If the port defines invalid dependencies, it's not pkgng's problem, it's the port. True that, but there should be way of pruning cruft from the pkg tree anyway. Even if the system is going more and more to linux way for majority of users (one package fits all) there should be some kind of allowance for those who want to build their own ports, but do not have access to major build clusters ;) Ability to build and customise ports has been major reason for using freebsd for me. If you get force-fed all the dependencies the port does not really need something like portupgrade -a will become major PITA. Kimmo Paasiala wrote: The port devel/pkg-config is used in many ports, there's no harm in installing it. I'm not running Gnome nor any gnome stuff except glib2. pkg-config might be used somewhere, but it's completely unneeded in my systems and just extra baggage for building and tracking dependencies. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 8:30 PM, Reko Turja reko.tu...@liukuma.net wrote: -Original Message- From: Bryan Drewery On 7/20/2012 11:57 AM, Reko Turja wrote: I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? Which port is pulling it in? sqlite3 In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. If the port defines invalid dependencies, it's not pkgng's problem, it's the port. True that, but there should be way of pruning cruft from the pkg tree anyway. Even if the system is going more and more to linux way for majority of users (one package fits all) there should be some kind of allowance for those who want to build their own ports, but do not have access to major build clusters ;) Ability to build and customise ports has been major reason for using freebsd for me. If you get force-fed all the dependencies the port does not really need something like portupgrade -a will become major PITA. Kimmo Paasiala wrote: The port devel/pkg-config is used in many ports, there's no harm in installing it. I'm not running Gnome nor any gnome stuff except glib2. pkg-config might be used somewhere, but it's completely unneeded in my systems and just extra baggage for building and tracking dependencies. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Regards, Kimmo Paasiala ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Actually, sqlite3 builds and works quite fine with pkg-config dependency removed from makefile. So it's kinda silly to pull it in by force - of course it's not pkgng problem, but a problem in the port itself. Just hoping that in pkgng there would be some Yes I might shoot myself in foot, but sod it -options. On the other hand, based on experience with 2 boxes running pkgng+portupgrade experimentally for some days pkgng looks like pretty good backend. Just still with some minor nits. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 7/20/2012 8:36 PM, Reko Turja wrote: Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Actually, sqlite3 builds and works quite fine with pkg-config dependency removed from makefile. So it's kinda silly to pull it in by force - of course it's not pkgng problem, but a problem in the port itself. sqlite3 installs /usr/local/libdata/pkgconfig/sqlite3.pc. So I think the rationale is if a developper wants to link against sqlite3 using the pkg-config file, he should have pkg-config on his machine. If you go this way, you could also ask why sqlite3 install header files which are not needed for the runtime dependency (when what is required is only the shared object)... Just hoping that in pkgng there would be some Yes I might shoot myself in foot, but sod it -options. Well, if you really want to shoot yourself, you can edit the local db with sqlite. On the other hand, based on experience with 2 boxes running pkgng+portupgrade experimentally for some days pkgng looks like pretty good backend. Just still with some minor nits. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 11:57 AM, Reko Turja reko.tu...@liukuma.net wrote: I'm testing out the pkgng system and somehow a port managed to pull devel/pkg-config into one low level port polluting whole db. pkg check just wants to install the annoying thing. Is there any way to get rid of that erroneous dependency? You can't be that serious? The pkg-config is everywhere and is not specific to the GNOME. Even the OpenSSL has pkg-config files. The pkg-config is very tiny. You need to grow hairs on your chest, dude. In production system, these kind of errors should be somehow correctable, especially if pkgng is to be used with ports as well. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 9:50 PM, Julien Laffaye jlaff...@freebsd.org wrote: On 7/20/2012 8:36 PM, Reko Turja wrote: Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Actually, sqlite3 builds and works quite fine with pkg-config dependency removed from makefile. So it's kinda silly to pull it in by force - of course it's not pkgng problem, but a problem in the port itself. sqlite3 installs /usr/local/libdata/pkgconfig/sqlite3.pc. So I think the rationale is if a developper wants to link against sqlite3 using the pkg-config file, he should have pkg-config on his machine. If you go this way, you could also ask why sqlite3 install header files which are not needed for the runtime dependency (when what is required is only the shared object)... This could be handled by having pkg-config only as a build time dependency for sqlite3 and for any port that depends on it, pkg-config is a build time tool much like autoconf, automake, libtool etc. and is not needed to use the port at run time. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 7/20/2012 9:03 PM, Kimmo Paasiala wrote: On Fri, Jul 20, 2012 at 9:50 PM, Julien Laffaye jlaff...@freebsd.org wrote: On 7/20/2012 8:36 PM, Reko Turja wrote: Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Actually, sqlite3 builds and works quite fine with pkg-config dependency removed from makefile. So it's kinda silly to pull it in by force - of course it's not pkgng problem, but a problem in the port itself. sqlite3 installs /usr/local/libdata/pkgconfig/sqlite3.pc. So I think the rationale is if a developper wants to link against sqlite3 using the pkg-config file, he should have pkg-config on his machine. If you go this way, you could also ask why sqlite3 install header files which are not needed for the runtime dependency (when what is required is only the shared object)... This could be handled by having pkg-config only as a build time dependency for sqlite3 and for any port that depends on it, pkg-config is a build time tool much like autoconf, automake, libtool etc. and is not needed to use the port at run time. Yes it is needed at runtime if you are a developper using sqlite3 and pkg-config: to use `pkg-config sqlite3 --cflags` and `pkg-config sqlite3 --libs` in your $APP build process. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/20/2012 12:15, Julien Laffaye wrote: On 7/20/2012 9:03 PM, Kimmo Paasiala wrote: On Fri, Jul 20, 2012 at 9:50 PM, Julien Laffaye jlaff...@freebsd.org wrote: On 7/20/2012 8:36 PM, Reko Turja wrote: Its use is not limited to Gnome, as you can see it's used in the build process of databases/sqlite3 and there are many other ports that have nothing to do with Gnome that use it the same way. The only thing that is wrong with it is that ends up being a run time dependency of sqlite3 instead of being only a build time dependency. Maybe this could be changed, anyone know if it's possible? Actually, sqlite3 builds and works quite fine with pkg-config dependency removed from makefile. So it's kinda silly to pull it in by force - of course it's not pkgng problem, but a problem in the port itself. sqlite3 installs /usr/local/libdata/pkgconfig/sqlite3.pc. So I think the rationale is if a developper wants to link against sqlite3 using the pkg-config file, he should have pkg-config on his machine. If you go this way, you could also ask why sqlite3 install header files which are not needed for the runtime dependency (when what is required is only the shared object)... This could be handled by having pkg-config only as a build time dependency for sqlite3 and for any port that depends on it, pkg-config is a build time tool much like autoconf, automake, libtool etc. and is not needed to use the port at run time. This is correct. Yes it is needed at runtime if you are a developper using sqlite3 and pkg-config: to use `pkg-config sqlite3 --cflags` and `pkg-config sqlite3 --libs` in your $APP build process. If you're developing a port, then the port needs to have a build dep on pkg-config. If you're developing your own stuff, then you need to install pkg-config as a build tool, just like you would (theoretically) install gmake, autoconf, etc. Run dependencies are for things that the installed package needs in order to *run*. Doug -- Change is hard. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
Julien Laffaye jlaff...@freebsd.org wrote: Yes it is needed at runtime if you are a developper using sqlite3 and pkg-config: to use `pkg-config sqlite3 --cflags` and `pkg-config sqlite3 --libs` in your $APP build process. It's $APP that needs pkg-config as a build dependency. Sqlite3 does not need to depend on pkf-config at all; it should install .pc file and nothing more. Look at lang/gcc, lang/python or devel/pcre: they all do it this way. In short, sqlite3 should completely drop the dependency on pkg-config. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 7/20/2012 9:24 PM, Vitaly Magerya wrote: Julien Laffaye jlaff...@freebsd.org wrote: Yes it is needed at runtime if you are a developper using sqlite3 and pkg-config: to use `pkg-config sqlite3 --cflags` and `pkg-config sqlite3 --libs` in your $APP build process. It's $APP that needs pkg-config as a build dependency. Sqlite3 does not need to depend on pkf-config at all; it should install .pc file and nothing more. Look at lang/gcc, lang/python or devel/pcre: they all do it this way. In short, sqlite3 should completely drop the dependency on pkg-config. I am not trying to state what it should or should not do. I am trying to guess why it is doing things like it does. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
Julien Laffaye jlaff...@freebsd.org wrote: I am not trying to state what it should or should not do. I am trying to guess why it is doing things like it does. I apologize for being patronizing then. Is any committer here willing to remove sqlite3's dependency on pkg-config, or should I file a PR? (A grep through the sources reveals that sqlite3 does not use pkg-config for it's own build, so it should be safe to completely drop the dependency). ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 10:59 PM, Vitaly Magerya vmage...@gmail.com wrote: Julien Laffaye jlaff...@freebsd.org wrote: I am not trying to state what it should or should not do. I am trying to guess why it is doing things like it does. I apologize for being patronizing then. Is any committer here willing to remove sqlite3's dependency on pkg-config, or should I file a PR? (A grep through the sources reveals that sqlite3 does not use pkg-config for it's own build, so it should be safe to completely drop the dependency). The port builds fine with the USE_GNOME=pkgconfig line commented out, also I tested building a dependent port devel/subversion and it built fine. I'm wondering if the dependency is removed then will all ports that link to sqlite3 pull in pkg-config if it's not installed? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
-Original Message- From: Kimmo Paasiala I'm wondering if the dependency is removed then will all ports that link to sqlite3 pull in pkg-config if it's not installed? After cleaning downstream ports and using portupgrade -f -O removes the dependency from that port, downstream is still affected though, so full downstream rebuild is needed in order to completely remove the dependency. And I'm not a dev, so having a utility that is only needed in certain linking scenarios isn't that useful for me as a dependency. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 11:29 PM, Kimmo Paasiala kpaas...@gmail.com wrote: On Fri, Jul 20, 2012 at 10:59 PM, Vitaly Magerya vmage...@gmail.com wrote: Julien Laffaye jlaff...@freebsd.org wrote: I am not trying to state what it should or should not do. I am trying to guess why it is doing things like it does. I apologize for being patronizing then. Is any committer here willing to remove sqlite3's dependency on pkg-config, or should I file a PR? (A grep through the sources reveals that sqlite3 does not use pkg-config for it's own build, so it should be safe to completely drop the dependency). The port builds fine with the USE_GNOME=pkgconfig line commented out, also I tested building a dependent port devel/subversion and it built fine. I'm wondering if the dependency is removed then will all ports that link to sqlite3 pull in pkg-config if it's not installed? Sqlite3 isn't the only one with a bogus dependency to pkg-config, for example audio/libsndfile does the same by using USE_GNOME=gnomehack pkgconfig instead of doing the proper thing (tm) which is patching Makefile.in to install the .pc file to $(prefix)/libdata/pkgconfig. I can try to track down some of those and submit PRs. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
-Original Message- From: Kimmo Paasiala Sqlite3 isn't the only one with a bogus dependency to pkg-config, for example audio/libsndfile does the same by using USE_GNOME=gnomehack Libxml2 is another, maybe grepping ports tree against pkg-config might be a start. -Reko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On 07/20/2012 14:26, Kimmo Paasiala wrote:
Sqlite3 isn't the only one with a bogus dependency to pkg-config, for
example audio/libsndfile does the same by using USE_GNOME=gnomehack
pkgconfig instead of doing the proper thing (tm) which is patching
Makefile.in to install the .pc file to $(prefix)/libdata/pkgconfig. I
can try to track down some of those and submit PRs.
http://people.freebsd.org/~dougb/pkg-config-run-deps.txt
Looks like bsd.gnome.mk is (bogusly) adding most of these:
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
Removing that is almost certainly the right first step.
--
Change is hard.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Sat, Jul 21, 2012 at 1:26 AM, Doug Barton do...@freebsd.org wrote:
On 07/20/2012 14:26, Kimmo Paasiala wrote:
Sqlite3 isn't the only one with a bogus dependency to pkg-config, for
example audio/libsndfile does the same by using USE_GNOME=gnomehack
pkgconfig instead of doing the proper thing (tm) which is patching
Makefile.in to install the .pc file to $(prefix)/libdata/pkgconfig. I
can try to track down some of those and submit PRs.
http://people.freebsd.org/~dougb/pkg-config-run-deps.txt
Looks like bsd.gnome.mk is (bogusly) adding most of these:
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
Removing that is almost certainly the right first step.
--
Change is hard.
Doug,
That certainly seems to be the culprit and it does look like it's safe
to remove that line. With that line removed there are still ports that
pull in pkg-config for build but don't actually use it. That's not a
big problem since pkg-config won't have anything depending on it after
the build.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
For those that are confused about why they are receiving this message,
ongoing discussion in ports@ as to the fact that pkg-config should not
be a run-dep for any ports.
On 07/20/2012 15:26, Doug Barton wrote:
http://people.freebsd.org/~dougb/pkg-config-run-deps.txt
Looks like bsd.gnome.mk is (bogusly) adding most of these:
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
Removing that is almost certainly the right first step.
... and indeed, removing that one line results in the list shrinking
from 3,000 to:
Ruby:
/usr/ports/accessibility/ruby-atk
/usr/ports/devel/ruby-gio2
/usr/ports/devel/ruby-glib2
/usr/ports/graphics/ruby-gdk_pixbuf2
/usr/ports/x11-toolkits/ruby-gstreamer
/usr/ports/x11-toolkits/ruby-pango
/usr/ports/x11-toolkits/ruby-poppler
/usr/ports/x11-toolkits/ruby-vte
Other:
/usr/ports/security/xmlsec1 johans@
/usr/ports/sysutils/lireed...@mavetju.org
/usr/ports/textproc/gmetadomports@, so I fixed it already
In the case of the Ruby ports it seems that they have a bogus run-dep on
rubygem-pkg-config. Removing that should do the trick (I haven't
examined all of them, since I don't know Ruby).
security/xmlsec1 just needs to make pkg-config a run-dep only.
I'm not quite sure where the run-dep for pkg-config is coming in for
sysutils/lire.
hth,
Doug
--
Change is hard.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: How to remove erroneous deps from pkgng
On Fri, Jul 20, 2012 at 6:48 PM, Doug Barton do...@freebsd.org wrote:
For those that are confused about why they are receiving this message,
ongoing discussion in ports@ as to the fact that pkg-config should not
be a run-dep for any ports.
On 07/20/2012 15:26, Doug Barton wrote:
http://people.freebsd.org/~dougb/pkg-config-run-deps.txt
Looks like bsd.gnome.mk is (bogusly) adding most of these:
pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
Removing that is almost certainly the right first step.
I prefer to leave it alone and port a feature that I have added in the
bsd.mate.mk (repocopied from bsd.gnome.mk) that support 'USE_GNOME=
foo:build bar:run foobar'. The 'foobar' without the :* means that it's
both build/run time dependency. It's available at:
http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/ports-experimental/Mk/bsd.mate.mk
Cheers,
Mezz
... and indeed, removing that one line results in the list shrinking
from 3,000 to:
Ruby:
/usr/ports/accessibility/ruby-atk
/usr/ports/devel/ruby-gio2
/usr/ports/devel/ruby-glib2
/usr/ports/graphics/ruby-gdk_pixbuf2
/usr/ports/x11-toolkits/ruby-gstreamer
/usr/ports/x11-toolkits/ruby-pango
/usr/ports/x11-toolkits/ruby-poppler
/usr/ports/x11-toolkits/ruby-vte
Other:
/usr/ports/security/xmlsec1 johans@
/usr/ports/sysutils/lireed...@mavetju.org
/usr/ports/textproc/gmetadomports@, so I fixed it already
In the case of the Ruby ports it seems that they have a bogus run-dep on
rubygem-pkg-config. Removing that should do the trick (I haven't
examined all of them, since I don't know Ruby).
security/xmlsec1 just needs to make pkg-config a run-dep only.
I'm not quite sure where the run-dep for pkg-config is coming in for
sysutils/lire.
hth,
Doug
--
Change is hard.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
--
mezz.free...@gmail.com - m...@freebsd.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gn...@freebsd.org
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
