Re: Mono 5.2 patch and DotNet Core 2 update

[David Naylor]

On Wednesday, 10 January 2018 08:55:45 Russell Haley wrote:
> Hi David,
> 
> I've successfully built mono based on a modified version of your patch
> from here: https://reviews.freebsd.org/D13752
> 
> I'm getting size and checksum errors for the file
> dotnet-roslyn-322bd5b_GH0.tar.gz. This shouldn't be an issue: I
> changed the size of the file in distinfo from 22058493 to the actual
> size I received of 22058637 in order to make it build. My expectation
> is that I should then run make checksum to fix the distinfo file
> correctly. I run sudo make checksum and the target goes into an
> infinite loop downloading the file, deciding it doesn't match the
> checksum and then downloading it again. WTH?
> 
> I am unsure how to proceed. The porters handbook is quite explicit
> that this is the way forward:
> https://www.freebsd.org/doc/en/books/porters-handbook/porting-checksum.html
> 
> I have attached what I think is the svn diff that include both your
> patch and my update. The distinfo file should still be incorrect. I
> haven't tested it. I have to get to work . :P
> 
> I have cc'd the ports list as well in this conversation. Any input
> from all parties would be grand.

Thank you for the review - I see you commented on the review.  I'll try and 
finish the port over the weekend.  

FYI, I have uploaded another two reviews.  These combined get the CentOS 
version of .NET Core running on FreeBSD :-).  

Regards

signature.asc
Description: This is a digitally signed message part.

Re: Mono 5.2 patch and DotNet Core 2 update

[Steven Hartland]

You want make makesum not make checksum to rebuild the distinfo file

On Wed, 10 Jan 2018 at 19:43, Romain Tartière  wrote:

> On Wed, Jan 10, 2018 at 08:55:45AM -0800, Russell Haley wrote:
> > I'm getting size and checksum errors for the file
> > dotnet-roslyn-322bd5b_GH0.tar.gz. This shouldn't be an issue: I
> > changed the size of the file in distinfo from 22058493 to the actual
> > size I received of 22058637 in order to make it build. My expectation
> > is that I should then run make checksum to fix the distinfo file
> > correctly. I run sudo make checksum and the target goes into an
> > infinite loop downloading the file, deciding it doesn't match the
> > checksum and then downloading it again. WTH?
>
> Since there are checksums, the ports systems must be checking them when
> downloading…  and since the checksum does not match, the download is
> assumed to have failed…  I guess you can solve this chicken-and-egg
> problem, vy simply removing the existing distinfo file.
>
> The actual files checksums will then be written to distinfo. You can
> `svn diff` to confirm only the expected files have been touched ;-)
>
> Regards,
> Romain
>
> --
> Romain Tartière   http://people.FreeBSD.org/~romain/
> pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
> (plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Mono 5.2 patch and DotNet Core 2 update

[Romain Tartière]

On Wed, Jan 10, 2018 at 08:55:45AM -0800, Russell Haley wrote:
> I'm getting size and checksum errors for the file
> dotnet-roslyn-322bd5b_GH0.tar.gz. This shouldn't be an issue: I
> changed the size of the file in distinfo from 22058493 to the actual
> size I received of 22058637 in order to make it build. My expectation
> is that I should then run make checksum to fix the distinfo file
> correctly. I run sudo make checksum and the target goes into an
> infinite loop downloading the file, deciding it doesn't match the
> checksum and then downloading it again. WTH?

Since there are checksums, the ports systems must be checking them when
downloading…  and since the checksum does not match, the download is
assumed to have failed…  I guess you can solve this chicken-and-egg
problem, vy simply removing the existing distinfo file.

The actual files checksums will then be written to distinfo. You can
`svn diff` to confirm only the expected files have been touched ;-)

Regards,
Romain

-- 
Romain Tartière   http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)


signature.asc
Description: PGP signature