More nitpicks from the department of redundancy department...
PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the following ports redefine it to exactly the same value: % grep -r 'PORT_DBDIR?=' . ./security/pear-Crypt_RSA/Makefile:PORT_DBDIR?= /var/db/ports ./Mk/bsd.port.mk:PORT_DBDIR?= /var/db/ports ./mail/squirrelmail-shared_calendars-plugin/Makefile:PORT_DBDIR?= /var/db/ports ./lang/php52-extensions/Makefile:PORT_DBDIR?= /var/db/ports ./lang/php5-extensions/Makefile:PORT_DBDIR?=/var/db/ports ./lang/php4-extensions/Makefile:PORT_DBDIR?=/var/db/ports ./lang/fpc-units/Makefile:PORT_DBDIR?= /var/db/ports ./sysutils/thefish/Makefile:PORT_DBDIR?=/var/db/ports ./devel/mico/Makefile:PORT_DBDIR?= /var/db/ports ./net-mgmt/nedi/Makefile:PORT_DBDIR?= /var/db/ports ./net-mgmt/netustad/Makefile:PORT_DBDIR?= /var/db/ports In the same vein, if a port sets LATEST_LINK this is automatically used for UNIQUENAME so the following are all redundant too: % grep -r '${PORT_DBDIR}/${LATEST_LINK}/options' . ./security/pear-Crypt_RSA/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./mail/squirrelmail-shared_calendars-plugin/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./lang/php52-extensions/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./lang/php5-extensions/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./lang/php4-extensions/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./lang/fpc-units/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./sysutils/thefish/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./net-mgmt/nedi/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options ./net-mgmt/netustad/Makefile:OPTIONSFILE?= ${PORT_DBDIR}/${LATEST_LINK}/options Pedantically, Matthew -- Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matt...@infracaninophile.co.uk Kent, CT11 9PW signature.asc Description: OpenPGP digital signature
Re: More nitpicks from the department of redundancy department...
On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman wrote: > > PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the > following ports redefine it to exactly the same value: > [ snip ] Thanks for the report - I'll handle these. -- Eitan Adler ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: More nitpicks from the department of redundancy department...
On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: > On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman > wrote: >> >> PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the >> following ports redefine it to exactly the same value: >> [ snip ] > > Thanks for the report - I'll handle these. Sorry for the empty promise. Something came up and I won't have the time to look at these :( - maybe someone else can take them up > > -- > Eitan Adler > -- Eitan Adler ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: More nitpicks from the department of redundancy department...
On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: > On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: > > On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman > > wrote: > >> > >> PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the > >> following ports redefine it to exactly the same value: > >> [ snip ] > > > > Thanks for the report - I'll handle these. > > Sorry for the empty promise. Something came up and I won't have the > time to look at these :( - maybe someone else can take them up Hi Matthew! If you could please file these in a PR and CC me I will try and work through all of these. -- WXS ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: More nitpicks from the department of redundancy department...
On 22/11/2011 13:29, Wesley Shields wrote: > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >>> wrote: PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the following ports redefine it to exactly the same value: [ snip ] >>> >>> Thanks for the report - I'll handle these. >> >> Sorry for the empty promise. Something came up and I won't have the >> time to look at these :( - maybe someone else can take them up > > Hi Matthew! > > If you could please file these in a PR and CC me I will try and work > through all of these. Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 Cheers, Matthew -- Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matt...@infracaninophile.co.uk Kent, CT11 9PW signature.asc Description: OpenPGP digital signature
Re: More nitpicks from the department of redundancy department...
On Tue, Nov 22, 2011 at 03:44:47PM +, Matthew Seaman wrote: > On 22/11/2011 13:29, Wesley Shields wrote: > > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: > >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: > >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman > >>> wrote: > > PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the > following ports redefine it to exactly the same value: > [ snip ] > >>> > >>> Thanks for the report - I'll handle these. > >> > >> Sorry for the empty promise. Something came up and I won't have the > >> time to look at these :( - maybe someone else can take them up > > > > Hi Matthew! > > > > If you could please file these in a PR and CC me I will try and work > > through all of these. > > Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 Thank you! I will try and clean all this up, but as I'm sure you're aware we are coming up on a holiday in the states so my time is limited for the next few days. I will look at this as time permits though! -- WXS ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: More nitpicks from the department of redundancy department...
On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake: On Tue, Nov 22, 2011 at 03:44:47PM +, Matthew Seaman wrote: On 22/11/2011 13:29, Wesley Shields wrote: > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >>> wrote: PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the following ports redefine it to exactly the same value: [ snip ] >>> >>> Thanks for the report - I'll handle these. >> >> Sorry for the empty promise. Something came up and I won't have the >> time to look at these :( - maybe someone else can take them up > > Hi Matthew! > > If you could please file these in a PR and CC me I will try and work > through all of these. Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 Thank you! I will try and clean all this up, but as I'm sure you're aware we are coming up on a holiday in the states so my time is limited for the next few days. I will look at this as time permits though! -- WXS I did have a brief look at some of these and it was a great catch. One item I did find interesting is a number of these define LATEST_LINK, but it just matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped -- on a case-by-case basis, of course. -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5 ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: More nitpicks from the department of redundancy department...
On 22/11/2011 17:29, Jason Helfman wrote: > On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake: >> On Tue, Nov 22, 2011 at 03:44:47PM +, Matthew Seaman wrote: >>> On 22/11/2011 13:29, Wesley Shields wrote: >>> > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >>> >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler >>> wrote: >>> >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >>> >>> wrote: >>> >>> PORT_DBDIR?= /var/db/ports is the default setting in >>> bsd.ports.mk -- the >>> following ports redefine it to exactly the same value: >>> [ snip ] >>> >>> >>> >>> Thanks for the report - I'll handle these. >>> >> >>> >> Sorry for the empty promise. Something came up and I won't have the >>> >> time to look at these :( - maybe someone else can take them up >>> > >>> > Hi Matthew! >>> > >>> > If you could please file these in a PR and CC me I will try and work >>> > through all of these. >>> >>> Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 >> >> Thank you! I will try and clean all this up, but as I'm sure you're >> aware we are coming up on a holiday in the states so my time is limited >> for the next few days. I will look at this as time permits though! >> >> -- WXS > > I did have a brief look at some of these and it was a great catch. One item > I did find interesting is a number of these define LATEST_LINK, but it just > matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped > -- on > a case-by-case basis, of course. Yes -- in fact, all the ports where PORT_DBDIR was redefined also set OPTIONSFILE to what would be the default value in any case. About half the ports mentioned were essentially clones of one of the phpX-extensions ports or borrowed heavily from them. I did a bit of checking to see if there were any other common cases with OPTIONSFILE but couldn't find anything obvious. Haven't searched for people setting LATEST_LINK to what would be the default in any case. Hmmm... just by inspection, there's a lot of ports that essentially set LATEST_LINK to ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} -- and that is actually the default value already. I'll stick looking into that on the queue. Cheers, Matthew -- Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matt...@infracaninophile.co.uk Kent, CT11 9PW signature.asc Description: OpenPGP digital signature