Re: On the usage of ${FILE}
On 03/02/2012 07:22, Chris Rees wrote:
> On 2 Mar 2012 13:19, "Wesley Shields" wrote:
>>
>> On Thu, Mar 01, 2012 at 12:38:01PM +, Chris Rees wrote:
>>> On 1 Mar 2012 11:26, "Matthew Seaman" wrote:
Dear all,
bsd.commands.mk has the following:
FILE?= /usr/bin/file
which is unfortunate, given that ${FILE} is used in several thousand
ports, generally as a loop control variable for iterating through a
> list
of files. In fact, I can only find about 8 places where the file(1)
program is intended.
This obvious conflict of meanings seems pretty undesirable to me. Am
> I
missing something? Is there any reason to keep the status quo rather
than changing the bsd.commands.mk variable to FILE_CMD and making the
corresponding changes in those 8 places?
Cheers,
Matthew
>>>
>>> I think that the loop control variables should be renamed to lower case.
>>
>> Except more of them in uppercase are bound to be added in the future,
>> despite the best warnings not to do so.
>
> Can I say portlint? ;)
Won't help, as we have a non-trivial number of developers who can't be
bothered to learn the proper way to do things, or even to use a tool as
simple as portlint.
Matthew's proposal is the right way to go.
Doug
--
This .signature sanitized for your protection
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: On the usage of ${FILE}
On 2 Mar 2012 13:19, "Wesley Shields" wrote:
>
> On Thu, Mar 01, 2012 at 12:38:01PM +, Chris Rees wrote:
> > On 1 Mar 2012 11:26, "Matthew Seaman" wrote:
> > >
> > >
> > > Dear all,
> > >
> > > bsd.commands.mk has the following:
> > >
> > > FILE?= /usr/bin/file
> > >
> > > which is unfortunate, given that ${FILE} is used in several thousand
> > > ports, generally as a loop control variable for iterating through a
list
> > > of files. In fact, I can only find about 8 places where the file(1)
> > > program is intended.
> > >
> > > This obvious conflict of meanings seems pretty undesirable to me. Am
I
> > > missing something? Is there any reason to keep the status quo rather
> > > than changing the bsd.commands.mk variable to FILE_CMD and making the
> > > corresponding changes in those 8 places?
> > >
> > >Cheers,
> > >
> > >Matthew
> > >
> >
> > I think that the loop control variables should be renamed to lower case.
>
> Except more of them in uppercase are bound to be added in the future,
> despite the best warnings not to do so.
Can I say portlint? ;)
Chris
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: On the usage of ${FILE}
On Thu, Mar 01, 2012 at 12:38:01PM +, Chris Rees wrote:
> On 1 Mar 2012 11:26, "Matthew Seaman" wrote:
> >
> >
> > Dear all,
> >
> > bsd.commands.mk has the following:
> >
> > FILE?= /usr/bin/file
> >
> > which is unfortunate, given that ${FILE} is used in several thousand
> > ports, generally as a loop control variable for iterating through a list
> > of files. In fact, I can only find about 8 places where the file(1)
> > program is intended.
> >
> > This obvious conflict of meanings seems pretty undesirable to me. Am I
> > missing something? Is there any reason to keep the status quo rather
> > than changing the bsd.commands.mk variable to FILE_CMD and making the
> > corresponding changes in those 8 places?
> >
> >Cheers,
> >
> >Matthew
> >
>
> I think that the loop control variables should be renamed to lower case.
Except more of them in uppercase are bound to be added in the future,
despite the best warnings not to do so.
-- WXS
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: On the usage of ${FILE}
On 1 Mar 2012 11:26, "Matthew Seaman" wrote:
>
>
> Dear all,
>
> bsd.commands.mk has the following:
>
> FILE?= /usr/bin/file
>
> which is unfortunate, given that ${FILE} is used in several thousand
> ports, generally as a loop control variable for iterating through a list
> of files. In fact, I can only find about 8 places where the file(1)
> program is intended.
>
> This obvious conflict of meanings seems pretty undesirable to me. Am I
> missing something? Is there any reason to keep the status quo rather
> than changing the bsd.commands.mk variable to FILE_CMD and making the
> corresponding changes in those 8 places?
>
>Cheers,
>
>Matthew
>
I think that the loop control variables should be renamed to lower case.
Chris
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
On the usage of ${FILE}
Dear all,
bsd.commands.mk has the following:
FILE?= /usr/bin/file
which is unfortunate, given that ${FILE} is used in several thousand
ports, generally as a loop control variable for iterating through a list
of files. In fact, I can only find about 8 places where the file(1)
program is intended.
This obvious conflict of meanings seems pretty undesirable to me. Am I
missing something? Is there any reason to keep the status quo rather
than changing the bsd.commands.mk variable to FILE_CMD and making the
corresponding changes in those 8 places?
Cheers,
Matthew
--
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
signature.asc
Description: OpenPGP digital signature
