RE: Patch for net-mgmt/p0f

2012-01-06 Thread Clayton Milos


-Original Message-
From: Wesley Shields [mailto:w...@freebsd.org] 
Sent: 06 January 2012 20:48
To: Clayton Milos
Cc: po...@freebsd.org
Subject: Re: Patch for net-mgmt/p0f

On Fri, Jan 06, 2012 at 04:12:19PM -, Clayton Milos wrote:
> Hi guys
> 
> I found that p0f doesn't work with the pflog interface. A bit of 
> searching and this patch turned up:
> http://desync.com/~bw/patch-p0f.c
> 
> With it applied instead of the default patch it works. It looks like 
> the default patch has a few wrong line numbers in it and is missing 
> the first part of the patch.
> Please could somebody commit the new patch.

The patch needs to include sys/queue.h before including net/if_pflog.h, at
least on my -CURRENT system. I'm testing things now and will commit if it
all looks good.

-- WXS

Thanks Wesley

I compiled it on 8.1-RELEASE i386 GENERIC.
I've also just tested it on 8.2-RELEASE amd64 GENERIC.
I'm not running -CURRENT on any of my systems at the moment.

Regards
Clay

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Patch for net-mgmt/p0f

2012-01-06 Thread Wesley Shields
On Fri, Jan 06, 2012 at 04:12:19PM -, Clayton Milos wrote:
> Hi guys
> 
> I found that p0f doesn't work with the pflog interface. A bit of searching
> and this patch turned up:
> http://desync.com/~bw/patch-p0f.c
> 
> With it applied instead of the default patch it works. It looks like the
> default patch has a few wrong line numbers in it and is missing the first
> part of the patch.
> Please could somebody commit the new patch.

These kinds of requests are better filled out as a PR so that they don't
get lost in the daily shuffle of this list.

For now I will take a look at that patch and see about getting it
committed.

-- WXS
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Patch for net-mgmt/p0f

2012-01-06 Thread Wesley Shields
On Fri, Jan 06, 2012 at 04:12:19PM -, Clayton Milos wrote:
> Hi guys
> 
> I found that p0f doesn't work with the pflog interface. A bit of searching
> and this patch turned up:
> http://desync.com/~bw/patch-p0f.c
> 
> With it applied instead of the default patch it works. It looks like the
> default patch has a few wrong line numbers in it and is missing the first
> part of the patch.
> Please could somebody commit the new patch.

The patch needs to include sys/queue.h before including net/if_pflog.h,
at least on my -CURRENT system. I'm testing things now and will commit
if it all looks good.

-- WXS
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Patch for net-mgmt/p0f

2012-01-06 Thread Clayton Milos
Hi guys

I found that p0f doesn't work with the pflog interface. A bit of searching
and this patch turned up:
http://desync.com/~bw/patch-p0f.c

With it applied instead of the default patch it works. It looks like the
default patch has a few wrong line numbers in it and is missing the first
part of the patch.
Please could somebody commit the new patch.

Regards
Clay


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"