Re: Please commit bug 190843
2014-07-14 16:36 GMT+02:00 Carlos Jacobo Puga Medina cjpug...@gmail.com: 2014-07-14 15:37 GMT+02:00 Kubilay Kocak ko...@freebsd.org: On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: Added patch to update to 0.7.0 Build logs: https://redports.org/buildarchive/20140714113400-20929/ --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Thanks for your submission Carlos :) Our issue tracker is the authoritative source of information for change requests, so always include all information there before posting on the mailing lists. I also note that OPTIONS_DEFAULT is added in your patch but has no value, so you may want to provide a second version of your patch fixing that, including the MAINTAINER update, and posting the URL to your redports build in a comment, noting that its ready to commit. Fixed. Running portlint (with -AC) flags is also highly recommended (add the output in your comment too, even if its clean) This gives committers confidence++ that your submission is ready to rock Thanks for your useful tips, koobs@ -- koobs Kind regards, --CJPM I attached a new patch after r362015 was committed. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190843#c8 --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Please commit bug 190843
Added patch to update to 0.7.0 Build logs: https://redports.org/buildarchive/20140714113400-20929/ --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Please commit bug 190843
On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: Added patch to update to 0.7.0 Build logs: https://redports.org/buildarchive/20140714113400-20929/ --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Thanks for your submission Carlos :) Our issue tracker is the authoritative source of information for change requests, so always include all information there before posting on the mailing lists. I also note that OPTIONS_DEFAULT is added in your patch but has no value, so you may want to provide a second version of your patch fixing that, including the MAINTAINER update, and posting the URL to your redports build in a comment, noting that its ready to commit. Running portlint (with -AC) flags is also highly recommended (add the output in your comment too, even if its clean) This gives committers confidence++ that your submission is ready to rock -- koobs ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Please commit bug 190843
2014-07-14 15:37 GMT+02:00 Kubilay Kocak ko...@freebsd.org: On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: Added patch to update to 0.7.0 Build logs: https://redports.org/buildarchive/20140714113400-20929/ --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Thanks for your submission Carlos :) Our issue tracker is the authoritative source of information for change requests, so always include all information there before posting on the mailing lists. I also note that OPTIONS_DEFAULT is added in your patch but has no value, so you may want to provide a second version of your patch fixing that, including the MAINTAINER update, and posting the URL to your redports build in a comment, noting that its ready to commit. Fixed. Running portlint (with -AC) flags is also highly recommended (add the output in your comment too, even if its clean) This gives committers confidence++ that your submission is ready to rock Thanks for your useful tips, koobs@ -- koobs Kind regards, --CJPM ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
