RE: FreeBSD Port: horde-base-3.1.5_1
Okay, so it's probably a Unicode vs. UTF-8 parser thing. My comment about the code needing to remain in ASCII stands, though (this isn't your fault, of course). The patch should really be fixed to use literal whitespace (ASCII 0x20) or tabs (ASCII 0x09). I have commit access to fix this, but I want to clear it + discuss with those involved with the PR first. I have re-rolled the patch, please let me know if you still have problems. It may take a while to get into the tree. Beech Looks fine now - ran portupgrade this morning and all is well. Thanks, Barry ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: FreeBSD Port: horde-base-3.1.5_1
On Wed, Dec 19, 2007 at 10:37:52AM -, Barry Byrne wrote:
Just portupgraded from horde-base-3.1.5 to 3.1.5_1 and ended up with an
parse error in NSL.php.
Checked the patched file (NLS.php) and I had something like this;
\xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */
\xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == UTF-8){
\xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,C);
\xa0 \xa0 \xa0 \xa0}
When I replaced the \xa0 with tabs, all was fine again.
The parse error is probably because PHP does not have Unicode or
multibyte character support enabled. The patch file in question
contains actual Unicode characters. You might try rebuilding PHP with
Zend support for multibyte characters (it's an option in make config)
and see if that improves things.
IMHO, the files/patch-lib_Horde_NLS.php patch should be using ASCII
characters for the actual source to ensure 100% compatibility. There's
nothing in that patch that requires the source itself to contain non-
breaking spaces (UTF-8 which I assume is what 0xa0 is).
Perhaps it's something with my system (6.2Release p-9), but I've not had an
issue like this before.
There's a PR for this commit. I've CC'd people on the PR, as this
probably needs some additional focus.
http://www.freebsd.org/cgi/query-pr.cgi?pr=116363
--
| Jeremy Chadwickjdc at parodius.com |
| Parodius Networking http://www.parodius.com/ |
| UNIX Systems Administrator Mountain View, CA, USA |
| Making life hard for others since 1977. PGP: 4BD6C0CB |
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to [EMAIL PROTECTED]
RE: FreeBSD Port: horde-base-3.1.5_1
-Original Message-
From: Jeremy Chadwick [mailto:[EMAIL PROTECTED]
Sent: 19 December 2007 11:34
To: Barry Byrne
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Checked the patched file (NLS.php) and I had something like this;
\xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */
\xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == UTF-8){
\xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,C);
\xa0 \xa0 \xa0 \xa0}
When I replaced the \xa0 with tabs, all was fine again.
The parse error is probably because PHP does not have Unicode or
multibyte character support enabled. The patch file in question
contains actual Unicode characters. You might try rebuilding PHP with
Zend support for multibyte characters (it's an option in
make config)
and see if that improves things.
Jeremy,
Thanks for the quick response.
You're correct in assuming I don't have Multibyte enabled.
However, I just rebuilt php on another machine and enabled multibyte,
then built horde-base on that, but still had the same characters
in the NLS.php file on that, so not sure what the problem is.
Regards,
Barry
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: FreeBSD Port: horde-base-3.1.5_1
On Wed, Dec 19, 2007 at 02:29:40PM -, Barry Byrne wrote:
-Original Message-
From: Jeremy Chadwick [mailto:[EMAIL PROTECTED]
Sent: 19 December 2007 11:34
To: Barry Byrne
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Checked the patched file (NLS.php) and I had something like this;
\xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */
\xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == UTF-8){
\xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,C);
\xa0 \xa0 \xa0 \xa0}
When I replaced the \xa0 with tabs, all was fine again.
The parse error is probably because PHP does not have Unicode or
multibyte character support enabled. The patch file in question
contains actual Unicode characters. You might try rebuilding PHP with
Zend support for multibyte characters (it's an option in
make config)
and see if that improves things.
Jeremy,
Thanks for the quick response.
You're correct in assuming I don't have Multibyte enabled.
However, I just rebuilt php on another machine and enabled multibyte,
then built horde-base on that, but still had the same characters
in the NLS.php file on that, so not sure what the problem is.
Okay, so it's probably a Unicode vs. UTF-8 parser thing.
My comment about the code needing to remain in ASCII stands, though
(this isn't your fault, of course). The patch should really be fixed to
use literal whitespace (ASCII 0x20) or tabs (ASCII 0x09).
I have commit access to fix this, but I want to clear it + discuss with
those involved with the PR first.
--
| Jeremy Chadwickjdc at parodius.com |
| Parodius Networking http://www.parodius.com/ |
| UNIX Systems Administrator Mountain View, CA, USA |
| Making life hard for others since 1977. PGP: 4BD6C0CB |
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: FreeBSD Port: horde-base-3.1.5_1
On Wed, Dec 19, 2007 at 10:37:52AM -, Barry Byrne wrote: Perhaps it's something with my system (6.2Release p-9), but I've not had an issue like this before. UTF-8 isspace fix is in -current and 7.x but is not in 6.x -- http://ache.pp.ru/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: FreeBSD Port: horde-base-3.1.5_1
On Wednesday 19 December 2007, Jeremy Chadwick said:
On Wed, Dec 19, 2007 at 02:29:40PM -, Barry Byrne wrote:
-Original Message-
From: Jeremy Chadwick [mailto:[EMAIL PROTECTED]
Sent: 19 December 2007 11:34
To: Barry Byrne
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Checked the patched file (NLS.php) and I had something like
this;
\xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */
\xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == UTF-8){
\xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,C);
\xa0 \xa0 \xa0 \xa0}
When I replaced the \xa0 with tabs, all was fine again.
The parse error is probably because PHP does not have Unicode
or multibyte character support enabled. The patch file in
question contains actual Unicode characters. You might try
rebuilding PHP with Zend support for multibyte characters (it's
an option in make config)
and see if that improves things.
Jeremy,
Thanks for the quick response.
You're correct in assuming I don't have Multibyte enabled.
However, I just rebuilt php on another machine and enabled
multibyte, then built horde-base on that, but still had the same
characters in the NLS.php file on that, so not sure what the
problem is.
Okay, so it's probably a Unicode vs. UTF-8 parser thing.
My comment about the code needing to remain in ASCII stands, though
(this isn't your fault, of course). The patch should really be
fixed to use literal whitespace (ASCII 0x20) or tabs (ASCII 0x09).
I have commit access to fix this, but I want to clear it + discuss
with those involved with the PR first.
I have re-rolled the patch, please let me know if you still have
problems. It may take a while to get into the tree.
Beech
--
---
Beech Rintoul - FreeBSD Developer - [EMAIL PROTECTED]
/\ ASCII Ribbon Campaign | FreeBSD Since 4.x
\ / - NO HTML/RTF in e-mail | http://www.freebsd.org
X - NO Word docs in e-mail | Latest Release:
/ \ - http://www.FreeBSD.org/releases/6.2R/announce.html
---
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to [EMAIL PROTECTED]
