Re: [RFC] less patches: control the PATH

2017-10-06 Thread Baptiste Daroussin
On Fri, Oct 06, 2017 at 01:11:46PM +, Baptiste Daroussin wrote:
> Hi all,
> 
> Here is a patch to add a new feature I am willing to get for a while:
> https://reviews.freebsd.org/D12603
> 
> What this patch does it basically prepend to PATH a new directory (inside
> WRKDIR)
> 
> A user can control which binary will be found in the PATH of the build 
> sequences
> easily by adding
> BINARY_RENAME=source target
> 
> This will create a sumlink in the WRKDIR/.bin directory:
> ${WRKDIR}/.bin/target -> source
> 
> The goal here to avoid patching a port which needs to use for example gsed
> instead of our bsd sed
> BINARY_RENAMe=gsed sed
> 
> of specify gcc will be gcc7, etc
> 
> This should remove lots of custom patches in the ports tree.
> 
> PS: this should break no port building tool :)
> PS2: the BINARY_RENAME variable name sucks, any better name is welcome :)

renamed BINARY_LINKS which is less worse :)

Best regards,
Bapt


signature.asc
Description: PGP signature


Re: [RFC] less patches: control the PATH

2017-10-06 Thread Guido Falsi
On 10/06/2017 15:11, Baptiste Daroussin wrote:
> Hi all,
> 
> Here is a patch to add a new feature I am willing to get for a while:
> https://reviews.freebsd.org/D12603

> A user can control which binary will be found in the PATH of the build 
> sequences
> easily by adding
> BINARY_RENAME=source target

> PS2: the BINARY_RENAME variable name sucks, any better name is welcome :)
> 

Suggestions from the top of my head:

BINARY_ALIAS

PROGRAM_ALIAS

EXECUTABLE_ALIAS

COMMAND_ALIAS

(Yes I think "alias" expresses the concept better)

-- 
Guido Falsi 
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: [RFC] less patches: control the PATH

2017-10-06 Thread Kyle Evans
On Oct 6, 2017 8:24 AM, "Guido Falsi"  wrote:

On 10/06/2017 15:11, Baptiste Daroussin wrote:
> Hi all,
>
> Here is a patch to add a new feature I am willing to get for a while:
> https://reviews.freebsd.org/D12603

> A user can control which binary will be found in the PATH of the build
sequences
> easily by adding
> BINARY_RENAME=source target

> PS2: the BINARY_RENAME variable name sucks, any better name is welcome :)
>

Suggestions from the top of my head:

BINARY_ALIAS

PROGRAM_ALIAS

EXECUTABLE_ALIAS

COMMAND_ALIAS

(Yes I think "alias" expresses the concept better)

--
Guido Falsi 


+1 for BINARY_ALIAS; concise, descriptive, and accurate
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: [RFC] less patches: control the PATH

2017-10-06 Thread Chris H
On Fri, 6 Oct 2017 15:24:04 +0200 Guido Falsi  wrote

> On 10/06/2017 15:11, Baptiste Daroussin wrote:
> > Hi all,
> > 
> > Here is a patch to add a new feature I am willing to get for a while:
> > https://reviews.freebsd.org/D12603
> 
> > A user can control which binary will be found in the PATH of the build
> > sequences easily by adding
> > BINARY_RENAME=source target
> 
> > PS2: the BINARY_RENAME variable name sucks, any better name is welcome :)
> > 
> 
> Suggestions from the top of my head:
> 
> BINARY_ALIAS
> 
> PROGRAM_ALIAS
> 
> EXECUTABLE_ALIAS
> 
> COMMAND_ALIAS
> 
> (Yes I think "alias" expresses the concept better)
+1
IMHO I think /mentally/ ALIAS really "nails it". :)

--Chris
> 
> -- 
> Guido Falsi 
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"