Re: Hi, I'd like to update the coreos-etcd port!

[Mark Linimon]

On Tue, Nov 10, 2015 at 09:36:48AM -0500, John Barker wrote:
> I went through the earlier steps about finding any outstanding issues, I
> can't see any pending PRs here:
> http://portsmon.freebsd.org/portoverview.py?category=devel=etcd=
> am I looking for it wrong?

No, that should be correct.  You can always use bugzilla to make sure
that portsmon has gotten it right:

  https://bugs.freebsd.org/bugzilla/query.cgi

> The next step in the guide is:
> 
> > If there is no pending PR, the next step is to send an email to the
> > port's maintainer, as shown by make maintainer.

I've always hated that advice :-)  I'd say open a PR.  It gives much
more information as an audit trail.

There is another reference you might want to look at:

  https://wiki.freebsd.org/KubilayKocak/ThePerfectPortsIssue

mcl
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Hi, I'd like to update the coreos-etcd port!

[Big Lebowski]

Hi John,

There's a bit more in that than simply updating the port, and it simply
needs some more of my time. Also, mind, that emailing the maintainer
directly is not the best way of communication, you'd be better if you've
created a PR and/or review for it (one already exists and waits for me to
have some more time).

Said all that, I am working on it ;)

Cheers!

On Mon, Nov 9, 2015 at 8:25 PM, John Barker  wrote:

> Hi there,
>
> I'm interested in updating the coreos-etcd package of FreeBSD and it seems
> like the current maintainer (ro...@freebsd.org) is not responding to email
> right now.
>
> I tried to do this with port submit, but got this:
>
> > # port submit
> > Port submit is currently broken
>
> See forwarded email below.
>
> Cheers,
> John
>
> -- Forwarded message --
> From: John Barker 
> Date: Tue, Nov 3, 2015 at 5:07 PM
> Subject: Hi, I'd like to update the coreos-etcd port!
> To: ro...@freebsd.org
>
>
> Hey there,
>
> This is my first time contributing anything to FreeBSD so I hope I’ve done
> everything right.
>
> The port coreos-etcd is currently building 0.4.6 and I’d like to update
> this to 2.2.1. I’ve included a patch, which I’ve tested on my FreeBSD 10.2
> instance. I didn’t see any evidence of any intention to update, and it
> looks like the last change to the makefile was from 2014.
>
> This may require a manual upgrade to one’s local etcd data if they’ve been
> running 0.4.6. Is that a concern we need to address via ports?
>
> Any thing I’ve missed?
>
> Hope to hear back from you soon!
>
> Cheers,
> John
>
>
>
>
>
> --
>
>
> *John Barker*
>
> Enigma  | Software Engineer
>
> (954) 205-6472 <9542056472>
>
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Hi, I'd like to update the coreos-etcd port!

[John Barker]

On Tue, Nov 10, 2015 at 4:51 AM, Big Lebowski 
wrote:

> Hi John,
>
> There's a bit more in that than simply updating the port, and it simply
> needs some more of my time. Also, mind, that emailing the maintainer
> directly is not the best way of communication, you'd be better if you've
> created a PR and/or review for it (one already exists and waits for me to
> have some more time).
>

Ahh, I'm looking at this here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html

I went through the earlier steps about finding any outstanding issues, I
can't see any pending PRs here:
http://portsmon.freebsd.org/portoverview.py?category=devel=etcd=
am I looking for it wrong?

The next step in the guide is:

> If there is no pending PR, the next step is to send an email to the
port's maintainer, as shown by make maintainer.

perhaps it could be revised to indicate that you should prefer to open a PR
first?


>
> Said all that, I am working on it ;)
>

Thank you, it's appreciated!


>
> Cheers!
>
> On Mon, Nov 9, 2015 at 8:25 PM, John Barker  wrote:
>
>> Hi there,
>>
>> I'm interested in updating the coreos-etcd package of FreeBSD and it seems
>> like the current maintainer (ro...@freebsd.org) is not responding to
>> email
>> right now.
>>
>> I tried to do this with port submit, but got this:
>>
>> > # port submit
>> > Port submit is currently broken
>>
>> See forwarded email below.
>>
>> Cheers,
>> John
>>
>> -- Forwarded message --
>> From: John Barker 
>> Date: Tue, Nov 3, 2015 at 5:07 PM
>> Subject: Hi, I'd like to update the coreos-etcd port!
>> To: ro...@freebsd.org
>>
>>
>> Hey there,
>>
>> This is my first time contributing anything to FreeBSD so I hope I’ve done
>> everything right.
>>
>> The port coreos-etcd is currently building 0.4.6 and I’d like to update
>> this to 2.2.1. I’ve included a patch, which I’ve tested on my FreeBSD 10.2
>> instance. I didn’t see any evidence of any intention to update, and it
>> looks like the last change to the makefile was from 2014.
>>
>> This may require a manual upgrade to one’s local etcd data if they’ve been
>> running 0.4.6. Is that a concern we need to address via ports?
>>
>> Any thing I’ve missed?
>>
>> Hope to hear back from you soon!
>>
>> Cheers,
>> John
>>
>>
>>
>>
>>
>> --
>>
>>
>> *John Barker*
>>
>> Enigma  | Software Engineer
>>
>> (954) 205-6472 <9542056472>
>>
>> ___
>> freebsd-ports@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
>> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
>>
>
>


-- 


*John Barker*

Enigma  | Software Engineer

(954) 205-6472 <9542056472>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"