Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Hello, Dmitry. You wrote 24 сентября 2011 г., 3:36:14: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. This commit breaks building `databases/sqlite3' with ICU support: command line utility can not be linked, as all libiuc-related options are lost. Previous version of sqlite3/Makefile (1.62) works well. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Hello, Dmitry. You wrote 24 сентября 2011 г., 3:36:14: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. devel/dbus could not be built with this commit, too: checking for pkg-config... (cached) /usr/local/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for XML_ParserCreate_MM in -lexpat... no configure: error: Could not find expat.h, check config.log for failed attempts === Script configure failed unexpectedly. It seems, that every port, which rely on `pkg-config' to determine libraries configuration, will fail. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Hello, Dmitry. You wrote 24 сентября 2011 г., 3:36:14: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. Add devel/dbus-glib to the list... Should I make formal PR for all these ports? -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
On Sun, Sep 25, 2011 at 02:41:36PM +0400, Lev Serebryakov wrote: Hello, Dmitry. You wrote 24 2011 ??., 3:36:14: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. Add devel/dbus-glib to the list... Should I make formal PR for all these ports? I could build all those ports just fine ysterday (after the referenced commit went in) and there has not yet been a wide outcry of people having trouble building ports, so I suspect the problem is local to your machine. -- Insert your favourite quote here. Erik Trulsson ertr1...@student.uu.se ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Hello, Erik. You wrote 25 сентября 2011 г., 14:49:19: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. Add devel/dbus-glib to the list... Should I make formal PR for all these ports? I could build all those ports just fine ysterday (after the referenced commit went in) and there has not yet been a wide outcry of people having trouble building ports, so I suspect the problem is local to your machine. It is very strange, as I have csup'ped ports tree without any local changes, and try to portmaster -a my installation. When I've rollback latest changes in these ports, everything works (and upgraded) perfectly. Ports database is Ok, no lost files or dependencies, etc. Many other ports are built without problems, but these three fails to apply proper LDFLAGS, sqlite3 to actual build commands (please note, that problem is only if ICU support is turned on for sqlite3, which is off by default), and tow dbus-related ports on configure stage. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Lev Serebryakov l...@freebsd.org writes: Hello, Dmitry. You wrote 24 сентября 2011 г., 3:36:14: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. devel/dbus could not be built with this commit, too: checking for pkg-config... (cached) /usr/local/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for XML_ParserCreate_MM in -lexpat... no configure: error: Could not find expat.h, check config.log for failed attempts === Script configure failed unexpectedly. It seems, that every port, which rely on `pkg-config' to determine libraries configuration, will fail. I see this, too. Turns out my cvsup mirror is broken. It doesn't have LDFLAGS commit r1.696 for ports/Mk/bsd.port.mk,v while it has r1.86 for ports/devel/dbus/Makefile,v. After using different mirror the issue is gone away. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
* Lev Serebryakov (l...@freebsd.org) wrote: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. Add devel/dbus-glib to the list... Should I make formal PR for all these ports? All three ports build here without problems (sqlite3 with ICU option enabled as well), tinderbox shows no problem either. Here's sqlite3+icu log, for example: http://people.freebsd.org/~amdmi3/sqlite3-icu-3.7.8.log configure command shows that LDFLAGS is used as expected after patch. There has also been a set of exp-runs before I committed the patch, last of which showed no breakages. Please double check your ports tree is in consistent state. If there's a problem with specific CVS mirror, this should be reported. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber: amd...@jabber.ruhttp://www.amdmi3.ru ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
Hello, h. You wrote 25 сентября 2011 г., 18:40:06: I see this, too. Turns out my cvsup mirror is broken. It doesn't have LDFLAGS commit r1.696 for ports/Mk/bsd.port.mk,v while it has r1.86 for ports/devel/dbus/Makefile,v. After using different mirror the issue is gone away. Yep, it looks like cvsup2.ru.freebsd.org has same problem too. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
On Sat, Sep 24, 2011 at 03:36:14AM +0400, Dmitry Marakasov wrote: * Dmitry Marakasov (amd...@amdmi3.ru) wrote: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. Thanks you very much for your work on this. regards, Bapt pgpPCfKrkao7e.pgp Description: PGP signature
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
* Dmitry Marakasov (amd...@amdmi3.ru) wrote: The patch was committed, LDFLAGS and CPPFLAGS and now handled similarily, shouldn't be passed to CONFIGURE_ENV and should be altered by += like C/CXXFLAGS. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber: amd...@jabber.ruhttp://www.amdmi3.ru ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup
* Dmitry Marakasov (amd...@amdmi3.ru) wrote: The patch is ready: http://people.freebsd.org/~amdmi3/ldflags.patch While it's mostly a bunch of similar changes, I'd like community eyes on specific important parts, namely Mk/ changes, python and ruby and generally all := assigns of *FLAGS, as these are dangerous (may refer variables which were not yet defined or which are changed later. However, I don't see any other way to prepend values instead of appending). -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber: amd...@jabber.ruhttp://www.amdmi3.ru ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
