Re: net-mgmt/prometheus update to 1.6.0, comitter requested
Great, thank you! Any feedback on port structure is welcome by me :) -Jev On Thu, Apr 20, 2017 at 11:43 AM Larry Rosenman wrote: > Indeed. I’m working with my Mentor (adamw@, and swills@(of portmgr@)) > and they had the issue with unknown. > > > > I’ll get this done. ☺ > > > > > > -- > > Larry Rosenman http://www.lerctr.org/~ler > > Phone: +1 214-642-9640 <(214)%20642-9640> E-Mail: > l...@lerctr.org > > US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 > > > > > > > > *From: *Jev Björsell > *Date: *Thursday, April 20, 2017 at 1:39 PM > *To: *Larry Rosenman , "freebsd-ports@freebsd.org" < > freebsd-ports@freebsd.org> > *Subject: *Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested > > > > Hi Larry, > > > > I presume you are referring the the strings 'unknown' that appear in the > do-build: portion of the Makefile. > > > > These are set to 'unknown' on purpose, because we do not have a way of > finding out that information unless we do it dynamically at build time. > Doing dynamically is not recommended for several reasons. > > > > This data gets displayed when a user runs `prometheus -version`, and most > of the fields are only really relevant to dev builds anyway. > > > > The crucial information is the software version number which is set. > > > > You can see me exchange on the subject in the ports mailing list archive > here: > > > > https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html > > > > -Jev > > > > > > On Wed, Apr 19, 2017 at 9:23 PM ler wrote: > > Can you fill in the unknown stuff in the version package or should I just > go ahead and do it? > > > > On Apr 19, 2017 at 10:22 PM, > wrote: > > Thanks Larry, > > > > I have updated the patch on the bug, because the upstream project has just > released a minor version/bug fix release. New patch updates us to 1.6.1. > > > > Thanks, > > -Jev > > > > On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman wrote: > > On 4/18/17, 2:41 PM, "Jev Björsell" behalf of j...@ecadlabs.com> wrote: > > Hi All, > > Could I get a committer to apply my latest update patch for net-mg > mt/prometheus? > > Patch is available here: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 > > Thanks so much, > -Jev > > Waiting for my mentor to approve. > > > ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: net-mgmt/prometheus update to 1.6.0, comitter requested
Indeed. I’m working with my Mentor (adamw@, and swills@(of portmgr@)) and they had the issue with unknown. I’ll get this done. ☺ -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: l...@lerctr.org US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 From: Jev Björsell Date: Thursday, April 20, 2017 at 1:39 PM To: Larry Rosenman , "freebsd-ports@freebsd.org" Subject: Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested Hi Larry, I presume you are referring the the strings 'unknown' that appear in the do-build: portion of the Makefile. These are set to 'unknown' on purpose, because we do not have a way of finding out that information unless we do it dynamically at build time. Doing dynamically is not recommended for several reasons. This data gets displayed when a user runs `prometheus -version`, and most of the fields are only really relevant to dev builds anyway. The crucial information is the software version number which is set. You can see me exchange on the subject in the ports mailing list archive here: https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html -Jev On Wed, Apr 19, 2017 at 9:23 PM ler wrote: Can you fill in the unknown stuff in the version package or should I just go ahead and do it? On Apr 19, 2017 at 10:22 PM, wrote: Thanks Larry, I have updated the patch on the bug, because the upstream project has just released a minor version/bug fix release. New patch updates us to 1.6.1. Thanks, -Jev On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman wrote: On 4/18/17, 2:41 PM, "Jev Björsell" wrote: Hi All, Could I get a committer to apply my latest update patch for net-mg mt/prometheus? Patch is available here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 Thanks so much, -Jev Waiting for my mentor to approve. ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested
Hi Larry, I presume you are referring the the strings 'unknown' that appear in the do-build: portion of the Makefile. These are set to 'unknown' on purpose, because we do not have a way of finding out that information unless we do it dynamically at build time. Doing dynamically is not recommended for several reasons. This data gets displayed when a user runs `prometheus -version`, and most of the fields are only really relevant to dev builds anyway. The crucial information is the software version number which is set. You can see me exchange on the subject in the ports mailing list archive here: https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html -Jev On Wed, Apr 19, 2017 at 9:23 PM ler wrote: > Can you fill in the unknown stuff in the version package or should I just > go ahead and do it? > > > > On Apr 19, 2017 at 10:22 PM, > wrote: > > Thanks Larry, > > I have updated the patch on the bug, because the upstream project has just > released a minor version/bug fix release. New patch updates us to 1.6.1. > > Thanks, > -Jev > > On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman wrote: > > On 4/18/17, 2:41 PM, "Jev Björsell" > behalf of j...@ecadlabs.com> wrote: >> >> Hi All, >> >> Could I get a committer to apply my latest update patch for net-mg >> mt/prometheus? >> >> Patch is available here: >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 >> >> Thanks so much, >> -Jev >> >> Waiting for my mentor to approve. >> >> >> >> ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested
Can you fill in the unknown stuff in the version package or should I just go ahead and do it? > > On Apr 19, 2017 at 10:22 PM,wrote: > > > Thanks Larry, > > > I have updated the patch on the bug, because the upstream project has just > released a minor version/bug fix release. New patch updates us to 1.6.1. > > > > Thanks, > > -Jev > > > > > On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenmanwrote: > > > On 4/18/17, 2:41 PM, "Jev Björsell" > behalf of j...@ecadlabs.com> wrote: > > > > Hi All, > > > > Could I get a committer to apply my latest update patch for net-mg > > mt/prometheus? > > > > Patch is available here: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 > > > > Thanks so much, > > -Jev > > > > Waiting for my mentor to approve. > > > > > > > ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: net-mgmt/prometheus update to 1.6.0, comitter requested
Thanks Larry, I have updated the patch on the bug, because the upstream project has just released a minor version/bug fix release. New patch updates us to 1.6.1. Thanks, -Jev On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman wrote: > On 4/18/17, 2:41 PM, "Jev Björsell" behalf of j...@ecadlabs.com> wrote: > > Hi All, > > Could I get a committer to apply my latest update patch for net-mg > mt/prometheus? > > Patch is available here: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 > > Thanks so much, > -Jev > > Waiting for my mentor to approve. > > > > ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: net-mgmt/prometheus update to 1.6.0, comitter requested
On 4/18/17, 2:41 PM, "Jev Björsell" wrote: Hi All, Could I get a committer to apply my latest update patch for net-mg mt/prometheus? Patch is available here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737 Thanks so much, -Jev Waiting for my mentor to approve. ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
