Re: SDL / Pulseaudio

2009-03-08 Thread Marcus von Appen
On, Fri Mar 06, 2009, Andre Heider wrote:

[More pulseaudio related patches]

Thanks. I'll look into that and fix it as appropriate.

Regards
Marcus


pgpqVAeQsHDYv.pgp
Description: PGP signature


Re: SDL / Pulseaudio

2009-03-06 Thread Andre Heider
On Wed, Mar 4, 2009 at 12:24 AM, Marcus von Appen m...@freebsd.org wrote:
 On, Tue Mar 03, 2009, Andre Heider wrote:

 Hi list,

 devel/sdl12 doesn't pick up pulseaudio, no matter if I select it in
 make config or not. I didn't find the time to dig further, but I
 noticed 2 bits:
 - the dependency to libpulse-simple.so.0 isn't set in the Makefile

 I missed that one, sorry. It will be fixed soon.

 - if I run ./configure without args, it correctly finds the lib and
 compiles the SDL audio driver for it

 Is this a known issue or am I missing some other port?

 For some weird reason the --enable-pulseaudio switch will disable
 PulseAudio support in 1.2.13. That'll be fixed as well.

 Thanks for noticing and notifying :-).

 Regards
 Marcus


Hi Marcus,

thanks for the compile fix, it builds fine now with pulseaudio support :)

Unfortunately there're some runtime problems with this SDL driver:

1) setting the envvar PULSE_SERVER to forward the stream to another
box results in 'E: proplist.c: Assertion 'p' failed at
pulse/proplist.c:295, function pa_proplist_contains(). Aborting.'
(thats from the SDL app using pulseaudio). paplay works just fine.
2) inefficency, using not used envvars like PASERVER, etc

I fixed 1) with

 static char *get_progname(void)
 {
char *progname = NULL;
-#ifdef __LINUX__
+#if defined(__LINUX__) || defined (__FreeBSD__)
FILE *fp;
static char temp[BUFSIZ];

This obviously doesn't work for other platforms, but at least its fine
on freebsd for me. Streaming to a Linux pulseaudio server works now :)

for 2) see http://bugzilla.libsdl.org/show_bug.cgi?id=698

I applied 2) (without the additional compatibility path, can't test
that and there's at least an #include missing) and combined it with my
oneliner change. Attached you'll find the results, ready to throw at
files/

Regards,
Andre
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: SDL / Pulseaudio

2009-03-06 Thread Andre Heider
On Fri, Mar 6, 2009 at 9:47 PM, Joe Marcus Clarke mar...@freebsd.org wrote:

 This only works with procfs mounted on /proc, but given that many GNOME
 components already require this, it's probably not a big deal here.

It does, and the right way would be to add a fallback string or
something, so the issue is fixed for every other platform out there.
I'm not even sure if this should be fixed in pulseaudio itself, but at
least the current version abort()s if the passed app name is NULL and
using PULSE_SERVER.

 One thing I've done in console-kit, for example, is to print a message
 when procfs is not mounted.  Perhaps something could be added in SDL as
 well if the fopen() fails.

Sounds like a good idea, but I'm not even sure what that string is
used for - apart from the visible entry in apps like pavucontrol.

Regards,
Andre
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: SDL / Pulseaudio

2009-03-06 Thread Joe Marcus Clarke
Andre Heider wrote:
 On Wed, Mar 4, 2009 at 12:24 AM, Marcus von Appen m...@freebsd.org wrote:
 On, Tue Mar 03, 2009, Andre Heider wrote:

 Hi list,

 devel/sdl12 doesn't pick up pulseaudio, no matter if I select it in
 make config or not. I didn't find the time to dig further, but I
 noticed 2 bits:
 - the dependency to libpulse-simple.so.0 isn't set in the Makefile
 I missed that one, sorry. It will be fixed soon.

 - if I run ./configure without args, it correctly finds the lib and
 compiles the SDL audio driver for it

 Is this a known issue or am I missing some other port?
 For some weird reason the --enable-pulseaudio switch will disable
 PulseAudio support in 1.2.13. That'll be fixed as well.

 Thanks for noticing and notifying :-).

 Regards
 Marcus

 
 Hi Marcus,
 
 thanks for the compile fix, it builds fine now with pulseaudio support :)
 
 Unfortunately there're some runtime problems with this SDL driver:
 
 1) setting the envvar PULSE_SERVER to forward the stream to another
 box results in 'E: proplist.c: Assertion 'p' failed at
 pulse/proplist.c:295, function pa_proplist_contains(). Aborting.'
 (thats from the SDL app using pulseaudio). paplay works just fine.
 2) inefficency, using not used envvars like PASERVER, etc
 
 I fixed 1) with
 
  static char *get_progname(void)
  {
 char *progname = NULL;
 -#ifdef __LINUX__
 +#if defined(__LINUX__) || defined (__FreeBSD__)
 FILE *fp;
 static char temp[BUFSIZ];
 
 This obviously doesn't work for other platforms, but at least its fine
 on freebsd for me. Streaming to a Linux pulseaudio server works now :)

This only works with procfs mounted on /proc, but given that many GNOME
components already require this, it's probably not a big deal here.

One thing I've done in console-kit, for example, is to print a message
when procfs is not mounted.  Perhaps something could be added in SDL as
well if the fopen() fails.

Joe

 
 for 2) see http://bugzilla.libsdl.org/show_bug.cgi?id=698
 
 I applied 2) (without the additional compatibility path, can't test
 that and there's at least an #include missing) and combined it with my
 oneliner change. Attached you'll find the results, ready to throw at
 files/
 
 Regards,
 Andre
 
 
 
 
 ___
 freebsd-ports@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports
 To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


-- 
Joe Marcus Clarke
FreeBSD GNOME Team  ::  gn...@freebsd.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


SDL / Pulseaudio

2009-03-03 Thread Andre Heider
Hi list,

devel/sdl12 doesn't pick up pulseaudio, no matter if I select it in
make config or not. I didn't find the time to dig further, but I
noticed 2 bits:
- the dependency to libpulse-simple.so.0 isn't set in the Makefile
- if I run ./configure without args, it correctly finds the lib and
compiles the SDL audio driver for it

Is this a known issue or am I missing some other port?

Regards,
Andre
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: SDL / Pulseaudio

2009-03-03 Thread Marcus von Appen
On, Tue Mar 03, 2009, Andre Heider wrote:

 Hi list,
 
 devel/sdl12 doesn't pick up pulseaudio, no matter if I select it in
 make config or not. I didn't find the time to dig further, but I
 noticed 2 bits:
 - the dependency to libpulse-simple.so.0 isn't set in the Makefile

I missed that one, sorry. It will be fixed soon.

 - if I run ./configure without args, it correctly finds the lib and
 compiles the SDL audio driver for it
 
 Is this a known issue or am I missing some other port?

For some weird reason the --enable-pulseaudio switch will disable
PulseAudio support in 1.2.13. That'll be fixed as well.

Thanks for noticing and notifying :-).

Regards
Marcus


pgp3fNfQy0HCW.pgp
Description: PGP signature


Re: SDL / Pulseaudio

2009-03-03 Thread Andre Heider
On Wed, Mar 4, 2009 at 12:24 AM, Marcus von Appen m...@freebsd.org wrote:
 On, Tue Mar 03, 2009, Andre Heider wrote:

 Hi list,

 devel/sdl12 doesn't pick up pulseaudio, no matter if I select it in
 make config or not. I didn't find the time to dig further, but I
 noticed 2 bits:
 - the dependency to libpulse-simple.so.0 isn't set in the Makefile

 I missed that one, sorry. It will be fixed soon.

 - if I run ./configure without args, it correctly finds the lib and
 compiles the SDL audio driver for it

 Is this a known issue or am I missing some other port?

 For some weird reason the --enable-pulseaudio switch will disable
 PulseAudio support in 1.2.13. That'll be fixed as well.

 Thanks for noticing and notifying :-).

Thank you for the fast answer and the upcoming fixes ;)


 Regards
 Marcus

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org