Re: The committed package speedup is a little bit flawed
Quoting Garrett Cooper <[EMAIL PROTECTED]> (from Sun, 17 Jun 2007 13:42:45 -0700): Pav Lucistnik wrote: Alexander Leidinger píše v ne 17. 06. 2007 v 18:41 +0200: On a related note, have you got a PR for the "make clean"-speedup? What PR number would that be? I don't know, the patch is not by me. I don't have that patch locally, so, it's probably lost. I think you mean this PR, and it was just committed: http://www.freebsd.org/cgi/query-pr.cgi?pr=112765 No. I was speaking about this one when I talked about some fixes. The clean-speedup patch was not in this PR. I try to lookup the originator (sorry, I can not remember who, he is someone @FreeBSD.org but doesn't show up that frequently on the mailinglists I read or in commits so that I know him very good). I search my INBOX and contact him. Bye, -- Many people are unenthusiastic about your work. http://www.Leidinger.netAlexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: The committed package speedup is a little bit flawed
Pav Lucistnik wrote: Alexander Leidinger píše v ne 17. 06. 2007 v 18:41 +0200: On a related note, have you got a PR for the "make clean"-speedup? What PR number would that be? I don't know, the patch is not by me. I don't have that patch locally, so, it's probably lost. I think you mean this PR, and it was just committed: http://www.freebsd.org/cgi/query-pr.cgi?pr=112765 -Garrett ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: The committed package speedup is a little bit flawed
Alexander Leidinger píše v ne 17. 06. 2007 v 18:41 +0200: > > > On a related note, have you got a PR for the "make clean"-speedup? > > > > What PR number would that be? > > I don't know, the patch is not by me. I don't have that patch locally, so, it's probably lost. -- Pav Lucistnik <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> Sword ownership rights have been under heavy fire since they were determined to be the leading cause of death during the Siege of Acre in the third crusade. signature.asc Description: Toto je digitálně podepsaná část zprávy
Re: The committed package speedup is a little bit flawed
Quoting Pav Lucistnik <[EMAIL PROTECTED]> (Sun, 17 Jun 2007 12:27:52 +0200): > Alexander Leidinger píše v ne 17. 06. 2007 v 12:02 +0200: > > > somehow you didn't got the final patch. > > I went with the latest patch available in the PR. Yeah... somehow we didn't provided the latest version there... > > On a related note, have you got a PR for the "make clean"-speedup? > > What PR number would that be? I don't know, the patch is not by me. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: The committed package speedup is a little bit flawed
Alexander Leidinger píše v ne 17. 06. 2007 v 12:02 +0200:
> somehow you didn't got the final patch.
I went with the latest patch available in the PR.
> Attached is the fastest version
> we where able to come up with. Additionally it contains a safety net
> ("-gt" part) in case there's something wrong (no ORIGIN in +CONTENTS).
> With the current version you run into an error, with the patch you
> don't.
Okay, I'll see when we have space for another exprun.
> On a related note, have you got a PR for the "make clean"-speedup?
What PR number would that be?
--
Pav Lucistnik <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>
Just because you're an angel doesn't mean you have to be a fool.
signature.asc
Description: Toto je digitálně podepsaná část zprávy
The committed package speedup is a little bit flawed
Hi,
somehow you didn't got the final patch. Attached is the fastest version
we where able to come up with. Additionally it contains a safety net
("-gt" part) in case there's something wrong (no ORIGIN in +CONTENTS).
With the current version you run into an error, with the patch you
don't.
It also contains the possibility to only record explicit package
dependencies instead of all implicit dependencies too (you have to set
EXPLICIT_PACKAGE_DEPENDS to some value to change the current default
behavior). This allows to experiment with explicit package
dependencies. If you don't like this part, just remove the
-a -z "${EXPLICIT_PACKAGE_DEPENDS}"
On a related note, have you got a PR for the "make clean"-speedup?
Interested parties can find "inofficial" (as in "not in GNATS for
portmgr testing") patches for this and some more bsd.port.mk
improvements for testing at:
http://www.Leidinger.net/FreeBSD/port-patches/
Bye,
Alexander.
--
"man hier" will explain the way FreeBSD filesystems are normally laid out.
-- David Scheidt <[EMAIL PROTECTED]>
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Index: Mk/bsd.port.mk
===
RCS file: /import/FreeBSD-CVS/ports/Mk/bsd.port.mk,v
retrieving revision 1.569
diff -u -r1.569 bsd.port.mk
--- Mk/bsd.port.mk 16 Jun 2007 19:07:42 - 1.569
+++ Mk/bsd.port.mk 17 Jun 2007 09:49:52 -
@@ -5380,23 +5533,20 @@
ACTUAL-PACKAGE-DEPENDS?= \
if [ "${_LIB_RUN_DEPENDS}" != " " ]; then \
- for pkgname in ${PKG_DBDIR}/*; do \
+ origins=$$(for pkgname in ${PKG_DBDIR}/*; do \
if [ -e $$pkgname/+CONTENTS ]; then \
-a=$${pkgname\#\#*/}; \
-b=`${SED} -n -e "s/@comment ORIGIN://p" $$pkgname/+CONTENTS`; \
-if [ ! -z $$b ]; then \
- origins="$$origins $$a $$b"; \
-fi; \
+${ECHO_CMD} $${pkgname\#\#*/}; \
+${SED} -n -e "s/@comment ORIGIN://p" $$pkgname/+CONTENTS; \
fi; \
- done; \
+ done); \
for dir in ${_LIB_RUN_DEPENDS:C,[^:]*:([^:]*):?.*,\1,}; do \
tmp=$${dir%/*}; \
dir=$${tmp\#\#*/}/$${dir\#\#*/}; \
set -- $$origins; \
- while [ $$\# != 0 ]; do \
-if [ $$dir = $$2 ]; then \
+ while [ $$\# -gt 1 ]; do \
+if [ "$$dir" = "$$2" ]; then \
${ECHO_CMD} $$1:$$dir; \
- if [ -e ${PKG_DBDIR}/$$1/+CONTENTS ]; then \
+ if [ -e ${PKG_DBDIR}/$$1/+CONTENTS -a -z "${EXPLICIT_PACKAGE_DEPENDS}" ]; then \
packagelist="$$packagelist ${PKG_DBDIR}/$$1/+CONTENTS"; \
fi; \
break; \
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
