Re: graphics/libfpx: use of bsd.lib.mk and warnings
On Sat, Jul 28, 2012 at 7:59 PM, Mikhail T. mi+t...@aldan.algebra.com wrote: On 28.07.2012 12:25, Thomas Zander wrote: It also causes the port to use clang when setting CC=clang in /etc/src.conf (!) which fails here. What if you use CC?=clang instead? Thanks, This works: CC?=clang CXX?=clang++ CPP?=clang-cpp Best Riggs ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
On Mon, Jun 11, 2012 at 11:00 PM, Andriy Gapon a...@freebsd.org wrote: I see that graphics/libfpx uses a custom FreeBSD-specific makefile which makes use of bsd.lib.mk and sets WARNS to 3. I think that this is an unsustainable approach. First, the external libraries are not under our control and may adhere to some different policy with respect to warnings. Second, different compilers (gccXY, clang) may be used to compile ports and they may produce new warnings-come-errors. It also causes the port to use clang when setting CC=clang in /etc/src.conf (!) which fails here. I am truly and utterly surprised that nobody seems to have this problem. Riggs ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
On 28.07.2012 12:25, Thomas Zander wrote: It also causes the port to use clang when setting CC=clang in /etc/src.conf (!) which fails here. I am truly and utterly surprised that nobody seems to have this problem. The idea of using bsd.lib.mk is simple: here are the sources, please, build me a shared library :-) Does it fail to build with clang? -mi ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
On Sat, Jul 28, 2012 at 6:28 PM, Andriy Gapon a...@freebsd.org wrote: Does it fail to build with clang? Yes: clang++ -fpic -DPIC -O2 -pipe -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H -Qunused-arguments -fstack-protector -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wpointer-arith -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -fno-rtti -fno-exceptions -fno-strict-aliasing -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/oless/h -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/jpeg -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ole -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/basics -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/oless -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx -I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/. -I/usr/local/include -D_UNIX -c /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/pr_level.cpp -o pr_level.So In file included from /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/viewimg.cpp:49: /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx/f_fpxio.h:146:31: error: 'PFileFlashPixIO::CreateEmptyResolutionLevel' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual PResolutionLevel* CreateEmptyResolutionLevel(int width, int height, int* whichImage); // Make a sub image in create mode ^ /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/ph_image.h:175:31: note: hidden overloaded virtual function 'PHierarchicalImage::CreateEmptyResolutionLevel' declared here virtual PResolutionLevel* CreateEmptyResolutionLevel(int width, int height, long* quelImage); // Make a sub image in create mode ^ In file included from /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/viewimg.cpp:49: /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx/f_fpxio.h:146:31: error: 'PFileFlashPixIO::CreateEmptyResolutionLevel' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual PResolutionLevel* CreateEmptyResolutionLevel(int width, int height, int* whichImage); // Make a sub image in create mode ^ /usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/ph_image.h:175:31: note: hidden overloaded virtual function 'PHierarchicalImage::CreateEmptyResolutionLevel' declared here virtual PResolutionLevel* CreateEmptyResolutionLevel(int width, int height, long* quelImage); // Make a sub image in create mode ^ 1 error generated. *** [viewimg.So] Error code 1 1 error generated. *** [viewimg.o] Error code 1 2 errors *** [do-build] Error code 1 Stop in /usr/ports/graphics/libfpx. In any case, a port should not pick up CC or CXX definitions from /etc/src.conf. Riggs ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
on 28/07/2012 19:28 Andriy Gapon said the following: On 28.07.2012 12:25, Thomas Zander wrote: It also causes the port to use clang when setting CC=clang in /etc/src.conf (!) which fails here. I am truly and utterly surprised that nobody seems to have this problem. The idea of using bsd.lib.mk is simple: here are the sources, please, build me a shared library :-) Does it fail to build with clang? -mi I very much wonder how the above email ended up having From: set to _my_ email address. -- Andriy Gapon ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
On 28.07.2012 13:46, Andriy Gapon wrote: I very much wonder how the above email ended up having From: set to_my_ email address. My apologies. Thunderbird's Virtual Identity extension got confused and I failed to notice :( I am sorry. -mi ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: graphics/libfpx: use of bsd.lib.mk and warnings
On 28.07.2012 12:25, Thomas Zander wrote: It also causes the port to use clang when setting CC=clang in /etc/src.conf (!) which fails here. What if you use CC?=clang instead? Thanks, -mi ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
graphics/libfpx: use of bsd.lib.mk and warnings
[Cc-ing mailing list just in case it is useful for other port maintainers] Mikhail, I see that graphics/libfpx uses a custom FreeBSD-specific makefile which makes use of bsd.lib.mk and sets WARNS to 3. I think that this is an unsustainable approach. First, the external libraries are not under our control and may adhere to some different policy with respect to warnings. Second, different compilers (gccXY, clang) may be used to compile ports and they may produce new warnings-come-errors. Right now, this is an issue for me with gcc46 as a ports compiler. I think that the best solution here is NO_WERROR. What do you and other port guys think about this? -- Andriy Gapon ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
