net/rdesktop segfault

2007-05-25 Thread Max N. Boyarov

Hi,

after clean install xorg7.2 rdesktop segfault at login.

#0  0x2820b73f in XPutImage () from /usr/local/lib/libX11.so.6
(gdb) bt
#0  0x2820b73f in XPutImage () from /usr/local/lib/libX11.so.6
#1  0x08058ce8 in ui_desktop_restore (offset=0, x=191, y=89, cx=417, cy=260)
at xwin.c:3226
#2  0x08065a36 in process_desksave (s=0x80bd700, os=0x80be1cc, present=32, 
delta=16) at orders.c:375
#3  0x080677a9 in process_orders (s=0x80bd700, num_orders=82) at orders.c:1247
#4  0x0806ea16 in rdp5_process (s=0x80bd700) at rdp5.c:85
#5  0x08062423 in rdp_recv (type=0xbfbfe587 "") at rdp.c:99
#6  0x08064dde in rdp_loop (deactivated=0xbfbfe608, ext_disc_reason=0xbfbfe5fc)
at rdp.c:1378
#7  0x08064da8 in rdp_main_loop (deactivated=0xbfbfe608, 
ext_disc_reason=0xbfbfe5fc) at rdp.c:1363
#8  0x0804d281 in main (argc=3, argv=0xbfbfe938) at rdesktop.c:912


-- 
Max N. Boyarov
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-05-25 Thread Max N. Boyarov

> "MNB" == Max N. Boyarov writes:

 MNB>  Hi,

 MNB> after clean install xorg7.2 rdesktop segfault at login.

 MNB> #0  0x2820b73f in XPutImage () from /usr/local/lib/libX11.so.6
 MNB> (gdb) bt
 MNB> #0  0x2820b73f in XPutImage () from /usr/local/lib/libX11.so.6
 MNB> #1  0x08058ce8 in ui_desktop_restore (offset=0, x=191, y=89, cx=417, 
cy=260)
 MNB> at xwin.c:3226

 with debug in libX11

 Loaded symbols for /libexec/ld-elf.so.1
#0  0x28212451 in XPutImage (dpy=0x28412000, d=25165829, gc=0x2841e1d0, 
image=0x0, req_xoffset=0, req_yoffset=0, x=377, y=136, req_width=127, 
req_height=135) at PutImage.c:967
967 if ((req_xoffset + width) > image->width)
(gdb) bt
#0  0x28212451 in XPutImage (dpy=0x28412000, d=25165829, gc=0x2841e1d0, 
image=0x0, req_xoffset=0, req_yoffset=0, x=377, y=136, req_width=127, 
req_height=135) at PutImage.c:967
#1  0x08058ce8 in ui_desktop_restore (offset=0, x=377, y=136, cx=127, cy=135)
at xwin.c:3226


-- 
Max N. Boyarov
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-01 Thread Thomas Spreng
Hi,

Duane Hill wrote:
> From the stand point of a fresh FBSD 6.2 install, rdesktop 1.5.0 works 
> fine here using xorg 7.2. I just logged into an XP pro and 2000 server
> without a segfault.

I've only tested connections to Windows Server 2003 SP2 so far,
rdesktop-1.5.0_1 segfaults every time at the login screen.

I'll try to do some testing on different Windows versions then.

cheers,

tom.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-01 Thread Thomas Spreng
Hi,

> after clean install xorg7.2 rdesktop segfault at login.

same problem here, after upgrading xorg to v7.2 rdesktop segfaults on
each login attempt. This seems to be a known problem with rdesktop.
Based on a PR from Ubuntu, I've created a patch which should resolve
this problem (see attachment).

I'll send it in as a PR tonight.

PS: apply with
(cd /usr/ports/net/rdesktop && patch -p1 < /path/to/patch)

PPS: forgot to cc: to list.

cheers,

tom.

diff -ruN rdesktop.bak/Makefile rdesktop/Makefile
--- rdesktop.bak/Makefile   Sat May 19 22:18:54 2007
+++ rdesktop/Makefile   Fri Jun  1 11:30:39 2007
@@ -7,7 +7,7 @@
 
 PORTNAME=  rdesktop
 PORTVERSION=   1.5.0
-PORTREVISION?= 1
+PORTREVISION?= 2
 CATEGORIES=net comms
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=${PORTNAME}
diff -ruN rdesktop.bak/files/patch-xwin.c rdesktop/files/patch-xwin.c
--- rdesktop.bak/files/patch-xwin.c Thu Jan  1 01:00:00 1970
+++ rdesktop/files/patch-xwin.c Fri Jun  1 11:30:39 2007
@@ -0,0 +1,11 @@
+--- xwin.c.origFri Jun  1 10:27:15 2007
 xwin.c Fri Jun  1 10:28:26 2007
+@@ -3219,7 +3219,7 @@
+   return;
+ 
+   image = XCreateImage(g_display, g_visual, g_depth, ZPixmap, 0,
+-   (char *) data, cx, cy, BitmapPad(g_display), cx * 
g_bpp / 8);
++   (char *) data, cx, cy, g_bpp, 0);
+ 
+   if (g_ownbackstore)
+   {
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Re: net/rdesktop segfault

2007-06-01 Thread Duane Hill

On Fri, 1 Jun 2007, Thomas Spreng wrote:


Hi,


after clean install xorg7.2 rdesktop segfault at login.


same problem here, after upgrading xorg to v7.2 rdesktop segfaults on
each login attempt. This seems to be a known problem with rdesktop.
Based on a PR from Ubuntu, I've created a patch which should resolve
this problem (see attachment).

I'll send it in as a PR tonight.

PS: apply with
(cd /usr/ports/net/rdesktop && patch -p1 < /path/to/patch)

PPS: forgot to cc: to list.

cheers,

tom.


From the stand point of a fresh FBSD 6.2 install, rdesktop 1.5.0 works 
fine here using xorg 7.2. I just logged into an XP pro and 2000 server 
without a segfault.

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-01 Thread Thomas Spreng
Thomas Spreng wrote:
> Hi,
> 
> Duane Hill wrote:
>> From the stand point of a fresh FBSD 6.2 install, rdesktop 1.5.0 works 
>> fine here using xorg 7.2. I just logged into an XP pro and 2000 server
>> without a segfault.
> 
> I've only tested connections to Windows Server 2003 SP2 so far,
> rdesktop-1.5.0_1 segfaults every time at the login screen.
> 
> I'll try to do some testing on different Windows versions then.

Ok, I just did some testing and it looks like it depends on what
framebuffer depth is used.

rdesktop-1.5.0_1 works fine if xorg 7.2 runs with a depth of 24 (32 bpp
framebuffer). If I switch to a depth of 16 on the other hand,
rdesktop-1.5.0_1 segfaults most of the time. It doesn't matter what
color depth I choose for the connection (rdesktop command line argument).

If I apply the patch (which I attached in one of my earlier posts)
everything runs fine, regardless what color depth is used.

All this has been tested on FBSD6.2 using xorg v7.2 (nv driver)
connecting to a Windows 2003 SP2.

Can anyone confirm my results? Or do some tests using other systems/setups?

cheers,

tom.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-05 Thread Max N. Boyarov

> "TS" == Thomas Spreng writes:


 TS> Can anyone confirm my results? Or do some tests using other systems/setups?

 no  segfault on 6.2/xorg 7.2/ati driver and same windows
 but i have segfault with vesa driver, so i think this is xorg trouble
 but patch fix this for rdesktop. 
 
-- 
Max N. Boyarov
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-13 Thread Anders Troback
On Fri, 01 Jun 2007 14:48:13 +0200
Thomas Spreng <[EMAIL PROTECTED]> wrote:

> Thomas Spreng wrote:
> > Hi,
> > 
> > Duane Hill wrote:
> >> From the stand point of a fresh FBSD 6.2 install, rdesktop 1.5.0
> >> works fine here using xorg 7.2. I just logged into an XP pro and
> >> 2000 server without a segfault.
> > 
> > I've only tested connections to Windows Server 2003 SP2 so far,
> > rdesktop-1.5.0_1 segfaults every time at the login screen.
> > 
> > I'll try to do some testing on different Windows versions then.
> 
> Ok, I just did some testing and it looks like it depends on what
> framebuffer depth is used.
> 
> rdesktop-1.5.0_1 works fine if xorg 7.2 runs with a depth of 24 (32
> bpp framebuffer). If I switch to a depth of 16 on the other hand,
> rdesktop-1.5.0_1 segfaults most of the time. It doesn't matter what
> color depth I choose for the connection (rdesktop command line
> argument).

Same here!

> 
> If I apply the patch (which I attached in one of my earlier posts)
> everything runs fine, regardless what color depth is used.

Kind of new to path...please help me, how do I apply it?

> 
> All this has been tested on FBSD6.2 using xorg v7.2 (nv driver)
> connecting to a Windows 2003 SP2.

Tested on 6.2 with nv and sis. Connections to Windows 2000 sp4 and 2003
R2 sp2. Same problem

> 
> Can anyone confirm my results? Or do some tests using other
> systems/setups?
> 
> cheers,
> 
> tom.
> ___
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to
> "[EMAIL PROTECTED]"


-- 
Anders Trobäck
http://www.troback.com/

Windows: "Where do you want to go today?"
Linux: "Where do you want to go tomorrow?"
FreeBSD: "Are you guys coming, or what?"

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: net/rdesktop segfault

2007-06-13 Thread Thomas Spreng

>> If I apply the patch (which I attached in one of my earlier posts)
>> everything runs fine, regardless what color depth is used.
> 
> Kind of new to path...please help me, how do I apply it?

as I have mentioned in the message containing the patch. The following
procedure should do the trick (untested, off the top of my mind).

first of all download the diff file, then issue the following commands:
# cd /usr/ports/net/rdesktop
# patch -p1 < /path/to/rdesktop_1.5.0_2.diff
# portupgrade net/rdesktop

cheers,

tom.

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"