Re: __FreeBSD_version bump? (was: Re: vlc 2.0.3 ProjectM path fix)
On Sat, Aug 18, 2012 at 10:45:10PM +0200, Juergen Lock wrote:
On Wed, Aug 15, 2012 at 10:09:59AM -0700, Kevin Oberman wrote:
On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock n...@jelal.kn-bremen.de
wrote:
On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote:
...
I think I got it: It is only a problem of configuring in the running
vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's all ;-)
Aah-haah! :) I've fixed the default paths and made a new patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before building
the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to deinstall the
old version before building the new one.
Hm well the rtld bug this workaround is for only affects the
pulseaudio and notify knobs, and the workaround doesn't work for
the notify knob so it would only cover half the cases, and also
checking if this is needed in the port would require a
__FreeBSD_version bump which is probably overkill for this bug.
And why is it overkill? I regularly see comments about not wanting to
bump __FreeBSD_version, but it's just an integer (though presented as
a fixed-point fraction). There is no shortage and I never have
understood why people are so hesitant to change it when there is a
real, even if fairly small benefit from the bump.
Hmm. Alexander, what do you think?
Not being Alexander, but appeared on Cc:.
IMO, bumping __FreeBSD_version should not be done frivolous, and routine
bug fixes are definitely not the good reason to bump.
For one, users of HEAD or stable are assumed to run tip of the branch.
If you want defined point of the branch, use release. With this POV,
the usefulness of the bump for bug fix is only a week or two.
Second, bump of __FreeBSD_version signifies major incompatibility between
pre-bumped tree and current one. In the kernel, each bump of version in HEAD
means that new modules cannot be loaded into new kernel.
Bumping for bug fixes is a misuse of the mechanism which was put there
to provide information about major changes in system. For small or
detectable items, use autoconf-like runtime (or build-time *) tests.
* - Usually, the tests must be run-time, and not build-time. This bug is
greatly amplified by use of __FreeBSD_version. The case that initiated
the discussion is probably the first time I ever saw the when build-time
test makes some sense.
pgpoRahquxJaz.pgp
Description: PGP signature
Re: __FreeBSD_version bump? (was: Re: vlc 2.0.3 ProjectM path fix)
On Mon, 20 Aug 2012 13:15:10 +0300
Konstantin Belousov kostik...@gmail.com wrote:
On Sat, Aug 18, 2012 at 10:45:10PM +0200, Juergen Lock wrote:
On Wed, Aug 15, 2012 at 10:09:59AM -0700, Kevin Oberman wrote:
On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock
n...@jelal.kn-bremen.de wrote:
On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote:
...
I think I got it: It is only a problem of configuring in
the running vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's
all ;-)
Aah-haah! :) I've fixed the default paths and made a new
patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before
building the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to
deinstall the old version before building the new one.
Hm well the rtld bug this workaround is for only affects the
pulseaudio and notify knobs, and the workaround doesn't work for
the notify knob so it would only cover half the cases, and also
checking if this is needed in the port would require a
__FreeBSD_version bump which is probably overkill for this bug.
And why is it overkill? I regularly see comments about not
wanting to bump __FreeBSD_version, but it's just an integer
(though presented as a fixed-point fraction). There is no
shortage and I never have understood why people are so hesitant
to change it when there is a real, even if fairly small benefit
from the bump.
Hmm. Alexander, what do you think?
Not being Alexander, but appeared on Cc:.
IMO, bumping __FreeBSD_version should not be done frivolous, and
routine bug fixes are definitely not the good reason to bump.
For one, users of HEAD or stable are assumed to run tip of the branch.
If you want defined point of the branch, use release. With this POV,
the usefulness of the bump for bug fix is only a week or two.
Second, bump of __FreeBSD_version signifies major incompatibility
between pre-bumped tree and current one. In the kernel, each bump of
version in HEAD means that new modules cannot be loaded into new
kernel.
Bumping for bug fixes is a misuse of the mechanism which was put there
to provide information about major changes in system. For small or
detectable items, use autoconf-like runtime (or build-time *) tests.
* - Usually, the tests must be run-time, and not build-time. This bug
is greatly amplified by use of __FreeBSD_version. The case that
initiated the discussion is probably the first time I ever saw the
when build-time test makes some sense.
I agree with Konstantin and I do not see the point to bump the version
just to serve fleeting needs of -stable or -current branch users -
their problems will be gone with upgrade to the tip of the respective
branch and this is the first thing they are expected to do before
reporting a bug anyway.
--
Alexander Kabaev
signature.asc
Description: PGP signature
__FreeBSD_version bump? (was: Re: vlc 2.0.3 ProjectM path fix)
On Wed, Aug 15, 2012 at 10:09:59AM -0700, Kevin Oberman wrote:
On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock n...@jelal.kn-bremen.de wrote:
On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote:
...
I think I got it: It is only a problem of configuring in the running
vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's all ;-)
Aah-haah! :) I've fixed the default paths and made a new patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before building
the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to deinstall the
old version before building the new one.
Hm well the rtld bug this workaround is for only affects the
pulseaudio and notify knobs, and the workaround doesn't work for
the notify knob so it would only cover half the cases, and also
checking if this is needed in the port would require a
__FreeBSD_version bump which is probably overkill for this bug.
And why is it overkill? I regularly see comments about not wanting to
bump __FreeBSD_version, but it's just an integer (though presented as
a fixed-point fraction). There is no shortage and I never have
understood why people are so hesitant to change it when there is a
real, even if fairly small benefit from the bump.
Hmm. Alexander, what do you think?
Thanx, :)
Juergen
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: vlc 2.0.3 ProjectM path fix (was: Re: More rtld trouble)
On Tue, Aug 14, 2012 at 08:31:58PM +0100, Chris Rees wrote: On 14 August 2012 20:24, Juergen Lock n...@jelal.kn-bremen.de wrote: On Tue, Aug 14, 2012 at 06:51:18PM +0200, Rainer Hurling wrote: On 14.08.2012 13:42 (UTC+2), Juergen Lock wrote: On Tue, Aug 14, 2012 at 06:40:14AM +0200, Rainer Hurling wrote: Am 13.08.2012 23:46 (UTC+1) schrieb Juergen Lock: [removed kan and kib from Cc as this is now not about rtld in fact] On Mon, Aug 13, 2012 at 11:11:09PM +0200, Juergen Lock wrote: Hi kib, kan, sorry to bother you again but... :) On Mon, Aug 13, 2012 at 09:53:55PM +0200, Rainer Hurling wrote: [...] (2) Option PROJM builds and installs, but crashes when I try to start it within vlc: No Textures Loaded from /usr/local/share/projectM/textures Segmentation fault (core dumped) As far as I can see, there is no path to projectM/textures (installed from libprojectM) on FreeBSD, but to projectM/presets? I'll have to look at that next... Hmm, cannot seem to reproduce this one, sorry. (Or do I have to do something special in vlc to activate it? I just tried playing a video file...) I have the problem with ProjectM when playing audio files and turn the ProjectM visualizations on. It immediately crashes. Yes, I meanwhile found this too. Maybe our projectm port version is too old? I think I got it: It is only a problem of configuring in the running vlc. You have to set the right path under 'Settings','All','Audio','Visualizing','projectM'. That's all ;-) Aah-haah! :) I've fixed the default paths and made a new patch: http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch Is there anything I can do to the projectM port to make it easier for you? I'll see if I can get it to 2.1.0 shortly. I don't think so, this was just vlc using linux paths. Ok, maybe it could give an error instead of crashing when a font is not found... :) But that's minor. Thanx! Juergen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: vlc 2.0.3 ProjectM path fix
On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote:
...
I think I got it: It is only a problem of configuring in the running
vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's all ;-)
Aah-haah! :) I've fixed the default paths and made a new patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before building
the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to deinstall the
old version before building the new one.
Hm well the rtld bug this workaround is for only affects the
pulseaudio and notify knobs, and the workaround doesn't work for
the notify knob so it would only cover half the cases, and also
checking if this is needed in the port would require a
__FreeBSD_version bump which is probably overkill for this bug.
So I think we'd rather mention the workaround in UPDATING, along
with the bugfix commit link...
Thanx, :)
Juergen
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: vlc 2.0.3 ProjectM path fix
On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock n...@jelal.kn-bremen.de wrote:
On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote:
...
I think I got it: It is only a problem of configuring in the running
vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's all ;-)
Aah-haah! :) I've fixed the default paths and made a new patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before building
the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to deinstall the
old version before building the new one.
Hm well the rtld bug this workaround is for only affects the
pulseaudio and notify knobs, and the workaround doesn't work for
the notify knob so it would only cover half the cases, and also
checking if this is needed in the port would require a
__FreeBSD_version bump which is probably overkill for this bug.
And why is it overkill? I regularly see comments about not wanting to
bump __FreeBSD_version, but it's just an integer (though presented as
a fixed-point fraction). There is no shortage and I never have
understood why people are so hesitant to change it when there is a
real, even if fairly small benefit from the bump.
--
R. Kevin Oberman, Network Engineer
E-mail: kob6...@gmail.com
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
vlc 2.0.3 ProjectM path fix (was: Re: More rtld trouble)
On Tue, Aug 14, 2012 at 06:51:18PM +0200, Rainer Hurling wrote: On 14.08.2012 13:42 (UTC+2), Juergen Lock wrote: On Tue, Aug 14, 2012 at 06:40:14AM +0200, Rainer Hurling wrote: Am 13.08.2012 23:46 (UTC+1) schrieb Juergen Lock: [removed kan and kib from Cc as this is now not about rtld in fact] On Mon, Aug 13, 2012 at 11:11:09PM +0200, Juergen Lock wrote: Hi kib, kan, sorry to bother you again but... :) On Mon, Aug 13, 2012 at 09:53:55PM +0200, Rainer Hurling wrote: On 13.08.2012 21:24 (UTC+2), Rainer Hurling wrote: On 13.08.2012 19:45 (UTC+2), Juergen Lock wrote: On Mon, Aug 13, 2012 at 07:34:45AM +0200, Rainer Hurling wrote: [...] I just posted the workaround for that crash: http://people.freebsd.org/~nox/tmp/vlc-2.0.3-009.patch Thanks for the newest patch! The change from sysconf(_SC_GETPW_R_SIZE_MAX) to LINE_MAX + 1 works nice here. No core dumps any more and sound via pulseaudio is working again :) I'll Cc the pulseaudio port maintainers (gnome@), maybe they have an idea? Did you forgot to Cc gnome@ (even on the other thread)? Yeah, I manually forwarded the mail when I noticed. I tried out a little bit the build without pulseaudio enabled. It seems to me, that the sound of vlc is somewhat noisy or dirty, especially for parts with more dynamics. This scratchy noise grows up when gain control comes over 100% (up to 200% is possible). Can anyone confirm this? I haven't noticed that here, maybe your soundcard is clipping etc due to too high mixer levels? Hmm, possible, but unlikely. This worked pretty good with version 1.1.13 and as I wrote, gain control was set in the middle (100%). But now, with pulseaudio enabled again, there is not problem with damaged sound quality any more. Btw it's still possible that different mixer items cause different clipping etc, for example vol 100 and pcm low sounds worse than vol 75 and pcm higher, etc. (Maybe pulseaudio does that...?) OK, thanks for the hint. I will have a further look at mixer. There are also some combinations like with kmix etc., that are not exactly represented in mixer settings ... And last but not least: When I deinstall vlc I get the following message: pkg_delete: '/usr/local/lib/vlc/plugins/plugins.dat' fails original MD5 checksum - deleted anyway. That's the file whose generating crashed when building with the old vlc still installed, maybe it's regenerated at runtime otherwise? No, it also fails original MD5 checksum with deinstall/reinstall within 2.0.3. Thanks again for your work on this port. Rainer You're welcome! :) Juergen I just found two other problems, which at least occur on my system (10.0-CURRENT amd64): (1) With option NOTIFY enabled I am able to build, but not to install vlc. It gives me: [...] (2) Option PROJM builds and installs, but crashes when I try to start it within vlc: No Textures Loaded from /usr/local/share/projectM/textures Segmentation fault (core dumped) As far as I can see, there is no path to projectM/textures (installed from libprojectM) on FreeBSD, but to projectM/presets? I'll have to look at that next... Hmm, cannot seem to reproduce this one, sorry. (Or do I have to do something special in vlc to activate it? I just tried playing a video file...) I have the problem with ProjectM when playing audio files and turn the ProjectM visualizations on. It immediately crashes. Yes, I meanwhile found this too. Maybe our projectm port version is too old? I think I got it: It is only a problem of configuring in the running vlc. You have to set the right path under 'Settings','All','Audio','Visualizing','projectM'. That's all ;-) Aah-haah! :) I've fixed the default paths and made a new patch: http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch Happy testing! Juergen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: vlc 2.0.3 ProjectM path fix (was: Re: More rtld trouble)
On 14 August 2012 20:24, Juergen Lock n...@jelal.kn-bremen.de wrote: On Tue, Aug 14, 2012 at 06:51:18PM +0200, Rainer Hurling wrote: On 14.08.2012 13:42 (UTC+2), Juergen Lock wrote: On Tue, Aug 14, 2012 at 06:40:14AM +0200, Rainer Hurling wrote: Am 13.08.2012 23:46 (UTC+1) schrieb Juergen Lock: [removed kan and kib from Cc as this is now not about rtld in fact] On Mon, Aug 13, 2012 at 11:11:09PM +0200, Juergen Lock wrote: Hi kib, kan, sorry to bother you again but... :) On Mon, Aug 13, 2012 at 09:53:55PM +0200, Rainer Hurling wrote: On 13.08.2012 21:24 (UTC+2), Rainer Hurling wrote: On 13.08.2012 19:45 (UTC+2), Juergen Lock wrote: On Mon, Aug 13, 2012 at 07:34:45AM +0200, Rainer Hurling wrote: [...] I just posted the workaround for that crash: http://people.freebsd.org/~nox/tmp/vlc-2.0.3-009.patch Thanks for the newest patch! The change from sysconf(_SC_GETPW_R_SIZE_MAX) to LINE_MAX + 1 works nice here. No core dumps any more and sound via pulseaudio is working again :) I'll Cc the pulseaudio port maintainers (gnome@), maybe they have an idea? Did you forgot to Cc gnome@ (even on the other thread)? Yeah, I manually forwarded the mail when I noticed. I tried out a little bit the build without pulseaudio enabled. It seems to me, that the sound of vlc is somewhat noisy or dirty, especially for parts with more dynamics. This scratchy noise grows up when gain control comes over 100% (up to 200% is possible). Can anyone confirm this? I haven't noticed that here, maybe your soundcard is clipping etc due to too high mixer levels? Hmm, possible, but unlikely. This worked pretty good with version 1.1.13 and as I wrote, gain control was set in the middle (100%). But now, with pulseaudio enabled again, there is not problem with damaged sound quality any more. Btw it's still possible that different mixer items cause different clipping etc, for example vol 100 and pcm low sounds worse than vol 75 and pcm higher, etc. (Maybe pulseaudio does that...?) OK, thanks for the hint. I will have a further look at mixer. There are also some combinations like with kmix etc., that are not exactly represented in mixer settings ... And last but not least: When I deinstall vlc I get the following message: pkg_delete: '/usr/local/lib/vlc/plugins/plugins.dat' fails original MD5 checksum - deleted anyway. That's the file whose generating crashed when building with the old vlc still installed, maybe it's regenerated at runtime otherwise? No, it also fails original MD5 checksum with deinstall/reinstall within 2.0.3. Thanks again for your work on this port. Rainer You're welcome! :) Juergen I just found two other problems, which at least occur on my system (10.0-CURRENT amd64): (1) With option NOTIFY enabled I am able to build, but not to install vlc. It gives me: [...] (2) Option PROJM builds and installs, but crashes when I try to start it within vlc: No Textures Loaded from /usr/local/share/projectM/textures Segmentation fault (core dumped) As far as I can see, there is no path to projectM/textures (installed from libprojectM) on FreeBSD, but to projectM/presets? I'll have to look at that next... Hmm, cannot seem to reproduce this one, sorry. (Or do I have to do something special in vlc to activate it? I just tried playing a video file...) I have the problem with ProjectM when playing audio files and turn the ProjectM visualizations on. It immediately crashes. Yes, I meanwhile found this too. Maybe our projectm port version is too old? I think I got it: It is only a problem of configuring in the running vlc. You have to set the right path under 'Settings','All','Audio','Visualizing','projectM'. That's all ;-) Aah-haah! :) I've fixed the default paths and made a new patch: http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch Is there anything I can do to the projectM port to make it easier for you? I'll see if I can get it to 2.1.0 shortly. Chris ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: vlc 2.0.3 ProjectM path fix
...
I think I got it: It is only a problem of configuring in the running
vlc. You have to set the right path under
'Settings','All','Audio','Visualizing','projectM'. That's all ;-)
Aah-haah! :) I've fixed the default paths and made a new patch:
http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch
From your patch:
workaround is to deinstall the old vlc-1.x version before building
the new one.
What about a conflict line ?
CONFLICTS_BUILD=${PORTNAME}-1.*
This allows users to fetch the source but they have to deinstall the
old version before building the new one.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
