Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports
Synopsis: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Responsible-Changed-From-To: freebsd-python-rm Responsible-Changed-By: rm Responsible-Changed-When: Thu Mar 28 20:10:14 UTC 2013 Responsible-Changed-Why: I will take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=177350 ___ freebsd-python@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to freebsd-python-unsubscr...@freebsd.org
Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports
The following reply was made to PR ports/177350; it has been noted by GNATS. From: John Marino dr...@marino.st To: bug-follo...@freebsd.org Cc: Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Date: Mon, 25 Mar 2013 17:26:17 +0100 From that error log, I'd say there was a mistake applying the patch. There is no ANY definition in the compile line which the extra cxx flags are supposed to add. Yes, this patch is to be applied after the existing patch is applied. From that, you can of course regenerate a new single patch for configure. I think there is a misunderstanding about the nature of this PR. py-qt builds on DragonFly Ports because I patched it. It came up on the mail list that somebody wanted it fixed on FreeBSD. I had the solution and I spent a couple of minutes writing a PR to let FreeBSD Ports developers know that. I never meant that these patches were a drop-in fix. I didn't have the time to generate a patch and test in on FreeBSD. I was leaving that up to the port maintainer. In any case, I'd double check the work because applying this patch on top of the existing patches *does* fix it on DragonFly and NetBSD. The error in the log looks like the error I saw before any patch was applied, so that's why I think suspect the patch in this PR wasn't accurately applied. ___ freebsd-python@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to freebsd-python-unsubscr...@freebsd.org
Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports
Hi John, John Marino wrote on 25.03.2013 20:30: The following reply was made to PR ports/177350; it has been noted by GNATS. From: John Marino dr...@marino.st To: bug-follo...@freebsd.org Cc: Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Date: Mon, 25 Mar 2013 17:26:17 +0100 From that error log, I'd say there was a mistake applying the patch. There is no ANY definition in the compile line which the extra cxx flags are supposed to add. Yes, this patch is to be applied after the existing patch is applied. From that, you can of course regenerate a new single patch for configure. I think there is a misunderstanding about the nature of this PR. py-qt builds on DragonFly Ports because I patched it. It came up on the mail list that somebody wanted it fixed on FreeBSD. I had the solution and I spent a couple of minutes writing a PR to let FreeBSD Ports developers know that. I never meant that these patches were a drop-in fix. I didn't have the time to generate a patch and test in on FreeBSD. I was leaving that up to the port maintainer. In any case, I'd double check the work because applying this patch on top of the existing patches *does* fix it on DragonFly and NetBSD. The error in the log looks like the error I saw before any patch was applied, so that's why I think suspect the patch in this PR wasn't accurately applied. Thank you for your efforts. This is what I'm trying to compile: http://people.freebsd.org/~rm/py-qt.tgz Would you please confirm, I merged it right? PS. Unfortunately, this port is unmaintained, so in that case it's up to submitter to provide correct patch. But I had tried to and I fail :). So please help. -- Regards, Ruslan Tinderboxing kills... the drives. ___ freebsd-python@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to freebsd-python-unsubscr...@freebsd.org
Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports
Synopsis: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Responsible-Changed-From-To: freebsd-ports-bugs-freebsd-python Responsible-Changed-By: edwin Responsible-Changed-When: Sun Mar 24 18:00:08 UTC 2013 Responsible-Changed-Why: freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool) http://www.freebsd.org/cgi/query-pr.cgi?pr=177350 ___ freebsd-python@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to freebsd-python-unsubscr...@freebsd.org
