Re: ppp routing bug ?
On 10/26/2017 6:16 PM, Eugene Grosbein wrote: > 27.10.2017 1:04, Mike Tancsa пишет: >> >> the borked route monitor looks like >> >> got message of size 124 on Thu Oct 26 12:21:12 2017 >> RTM_ADD: Add Route: len 124, pid: 29597, seq 2, errno 0, >> flags:>> locks: inits: >> sockaddrs: >> 192.168.134.2 64.7.128.7 >> >> >> got message of size 196 on Thu Oct 26 12:21:13 2017 >> RTM_CHANGE: Change Metrics or flags: len 196, pid: 29597, seq 5, errno >> 0, flags: >> locks: inits: >> sockaddrs: >> 192.168.134.2 64.7.128.7 tun0 98-159-244-185.agas1a-dynamic.dsl.sentex.ca > > That makes sense: ppp send bogus request to the routing socket and > the request has not RTF_HOST flag nor RTA_NETMASK address. > It seems, earlier kernel code masked this bug somehow but it does not now. > > Anyway, we have two bugs here: ppp sending bad request and kernel having > no enough checks for this somehow. > > Fixing ppp part would be easy. Please try this patch: Thanks, that seems to restore the earlier functionality! ---Mike -- --- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, m...@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/ ___ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
Re: buildworld fail in stable/11 @r325033 -- r325029?
On Fri, Oct 27, 2017 at 05:42:18PM +0300, Konstantin Belousov wrote: > ... > Can you confirm that the following patch allows your system to build ? > > Index: lib/libprocstat/libprocstat.c > === > --- lib/libprocstat/libprocstat.c (revision 325038) > +++ lib/libprocstat/libprocstat.c (working copy) > @@ -63,10 +63,10 @@ > #include > #include > #include > +#include > #define _KERNEL > #include > #include > -#include > #include > #include > #include > Index: . > === > Yes: Thanks, Konstantin; that worked rather nicely: FreeBSD localhost 11.1-STABLE FreeBSD 11.1-STABLE #432 r325033M/325033:1101506: Fri Oct 27 08:18:47 PDT 2017 r...@g1-252.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY amd64 Peace, david -- David H. Wolfskill da...@catwhisker.org Unsubstantiated claims of "Fake News" are evidence that the claimant lies again. See http://www.catwhisker.org/~david/publickey.gpg for my public key. signature.asc Description: PGP signature
Re: buildworld fail in stable/11 @r325033 -- r325029?
Bezüglich Konstantin Belousov's Nachricht vom 27.10.2017 16:42 (localtime): > On Fri, Oct 27, 2017 at 04:12:54AM -0700, David Wolfskill wrote: >> This is observed on systems (both my laptop & my build machine) running >> stable/11 @r325003, after updating sources to r325033: >> >> --- libprocstat.o --- >> In file included from /usr/src/lib/libprocstat/libprocstat.c:69: >> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has >> incomplete type 'struct siginfo32' >> struct siginfo32 pl_siginfo;/* siginfo for signal */ >> ^ >> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward >> declaration of 'struct siginfo32' >> struct siginfo32 pl_siginfo;/* siginfo for signal */ >>^ >> >> I don't know that r325029 is to blame, but that was the last commit >> in that area (in the range r325003 - r325033). And there wwer not >> very many commits to stable/11 in that range: > Can you confirm that the following patch allows your system to build ? > > Index: lib/libprocstat/libprocstat.c > === > --- lib/libprocstat/libprocstat.c (revision 325038) > +++ lib/libprocstat/libprocstat.c (working copy) > @@ -63,10 +63,10 @@ > #include > #include > #include > +#include > #define _KERNEL > #include > #include > -#include > #include > #include > #include > Index: . > === > --- . (revision 325038) > +++ . (working copy) > Confirmed. Sorry for the obsolete last post. It's been in the pipeline for build time and haven't checked that you already posted the solution! -harry ___ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
Re: buildworld fail in stable/11 @r325033 -- r325029?
Bezüglich David Wolfskill's Nachricht vom 27.10.2017 13:12 (localtime): > This is observed on systems (both my laptop & my build machine) running > stable/11 @r325003, after updating sources to r325033: > > --- libprocstat.o --- > In file included from /usr/src/lib/libprocstat/libprocstat.c:69: > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has > incomplete type 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ > ^ > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward > declaration of 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ >^ I know nothing about the code changes in r324932 (MFC r316286), but the followup fix r325029 (MFC r320481) seems to have caused the early buildworld failure in stable/11 – for me too. Since clang reported the error referencing some include from obj/tmp (tmp/usr/include/sys/ptrace.h), I found: r316304 (https://svnweb.freebsd.org/base/head/lib/libprocstat/libprocstat.c?view=patch=316304=316303=316304), which I thought could explain the symptom. Seems to be the solution (applies cleanly to stable/11, buildworld succeded). Even a blind squirrel sometimes finds the nut ;-) -harry ___ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
Re: buildworld fail in stable/11 @r325033 -- r325029?
On Fri, Oct 27, 2017 at 04:12:54AM -0700, David Wolfskill wrote: > This is observed on systems (both my laptop & my build machine) running > stable/11 @r325003, after updating sources to r325033: > > --- libprocstat.o --- > In file included from /usr/src/lib/libprocstat/libprocstat.c:69: > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has > incomplete type 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ > ^ > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward > declaration of 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ >^ > > I don't know that r325029 is to blame, but that was the last commit > in that area (in the range r325003 - r325033). And there wwer not > very many commits to stable/11 in that range: Can you confirm that the following patch allows your system to build ? Index: lib/libprocstat/libprocstat.c === --- lib/libprocstat/libprocstat.c (revision 325038) +++ lib/libprocstat/libprocstat.c (working copy) @@ -63,10 +63,10 @@ #include #include #include +#include #define_KERNEL #include #include -#include #include #include #include Index: . === --- . (revision 325038) +++ . (working copy) Property changes on: . ___ Modified: svn:mergeinfo ## -0,0 +0,1 ## Merged /head:r316304 ___ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
Re: buildworld fail in stable/11 @r325033 -- r325029?
FWIW - I had a successful build yesterday on stable/11 r325010; I have not tried anything newer yet. Dan David Wolfskillwrites: > This is observed on systems (both my laptop & my build machine) running > stable/11 @r325003, after updating sources to r325033: > > --- libprocstat.o --- > In file included from /usr/src/lib/libprocstat/libprocstat.c:69: > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has > incomplete type 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ > ^ > /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward > declaration of 'struct siginfo32' > struct siginfo32 pl_siginfo;/* siginfo for signal */ >^ > > I don't know that r325029 is to blame, but that was the last commit > in that area (in the range r325003 - r325033). And there wwer not > very many commits to stable/11 in that range: > > 1. Oct 27 Konstantin Belousov svn commit: r325033 - stable/11/sys/vm > 2. Oct 27 Bryan Drewery svn commit: r325029 - in stable/11: > sys/compat/freeb > 3. Oct 26 Ian Lepore svn commit: r325023 - stable/11/sys/dev/sdhci > 4. Oct 26 Tijl Coosemans svn commit: r325015 - in stable/11/sys: > compat/linsy > 5. Oct 25 Alan Somers svn commit: r325003 - in stable/11: sys/geom > sys/sys > > Peace, > david ___ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
buildworld fail in stable/11 @r325033 -- r325029?
This is observed on systems (both my laptop & my build machine) running stable/11 @r325003, after updating sources to r325033: --- libprocstat.o --- In file included from /usr/src/lib/libprocstat/libprocstat.c:69: /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has incomplete type 'struct siginfo32' struct siginfo32 pl_siginfo;/* siginfo for signal */ ^ /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward declaration of 'struct siginfo32' struct siginfo32 pl_siginfo;/* siginfo for signal */ ^ I don't know that r325029 is to blame, but that was the last commit in that area (in the range r325003 - r325033). And there wwer not very many commits to stable/11 in that range: 1. Oct 27 Konstantin Belousov svn commit: r325033 - stable/11/sys/vm 2. Oct 27 Bryan Drewery svn commit: r325029 - in stable/11: sys/compat/freeb 3. Oct 26 Ian Lepore svn commit: r325023 - stable/11/sys/dev/sdhci 4. Oct 26 Tijl Coosemans svn commit: r325015 - in stable/11/sys: compat/linsy 5. Oct 25 Alan Somers svn commit: r325003 - in stable/11: sys/geom sys/sys Peace, david -- David H. Wolfskill da...@catwhisker.org Unsubstantiated claims of "Fake News" are evidence that the claimant lies again. See http://www.catwhisker.org/~david/publickey.gpg for my public key. signature.asc Description: PGP signature