Re: DANGER WILL ROBINSON! SERIOUS problem with current5.4-PRERELEASE - UPDATE (real this time) #2
On Thu, Mar 31, 2005 at 12:02:20PM -0500, Matthew N. Dodd wrote:
On Wed, 30 Mar 2005, Karl Denninger wrote:
Removing the FIRST delta, which is:
218a219,221
if (!dumping)
callout_reset(request-callout, request-timeout * hz,
(timeout_t*)ata_timeout, request);
appears to get rid of the crashes while not harming data integrity OR the
reqeueing.
I'd be interested to know if the attached patch does anything.
--
10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00
Index: ata-queue.c
===
RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.32.2.6
diff -u -u -r1.32.2.6 ata-queue.c
--- ata-queue.c 23 Mar 2005 04:50:26 - 1.32.2.6
+++ ata-queue.c 31 Mar 2005 17:00:46 -
@@ -217,8 +217,7 @@
}
else {
if (!dumping)
- callout_reset(request-callout, request-timeout * hz,
- (timeout_t*)ata_timeout, request);
+callout_drain(request-callout);
if (request-bio !(request-flags ATA_R_TIMEOUT)) {
ATA_DEBUG_RQ(request, finish bio_taskqueue);
bio_taskqueue(request-bio, (bio_task_t *)ata_completed, request);
Removing the first delta has allowed the system to survive for over 24
hours, albiet while taking retryable errors.
I have not yet attmepted this patch - but will now that I know that the
system is stable with the first delta OUT.
At minimum Matt that first delta has to come out to avoid the pukes and
chokes - whether the above is recommended (by me anyway) I can't say yet -
more as I know it.
--
--
Karl Denninger ([EMAIL PROTECTED]) Internet Consultant Kids Rights Activist
http://www.denninger.netMy home on the net - links to everything I do!
http://scubaforum.org Your UNCENSORED place to talk about DIVING!
http://www.spamcuda.net SPAM FREE mailboxes - FREE FOR A LIMITED TIME!
http://genesis3.blogspot.comMusings Of A Sentient Mind
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: DANGER WILL ROBINSON! SERIOUS problem with current5.4-PRERELEASE - UPDATE (real this time)
On Wed, 30 Mar 2005, Karl Denninger wrote:
Removing the FIRST delta, which is:
218a219,221
if (!dumping)
callout_reset(request-callout, request-timeout * hz,
(timeout_t*)ata_timeout, request);
appears to get rid of the crashes while not harming data integrity OR the
reqeueing.
I'd be interested to know if the attached patch does anything.
--
10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00Index: ata-queue.c
===
RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.32.2.6
diff -u -u -r1.32.2.6 ata-queue.c
--- ata-queue.c 23 Mar 2005 04:50:26 - 1.32.2.6
+++ ata-queue.c 31 Mar 2005 17:00:46 -
@@ -217,8 +217,7 @@
}
else {
if (!dumping)
- callout_reset(request-callout, request-timeout * hz,
- (timeout_t*)ata_timeout, request);
+callout_drain(request-callout);
if (request-bio !(request-flags ATA_R_TIMEOUT)) {
ATA_DEBUG_RQ(request, finish bio_taskqueue);
bio_taskqueue(request-bio, (bio_task_t *)ata_completed, request);
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: DANGER WILL ROBINSON! SERIOUS problem with current5.4-PRERELEASE - UPDATE (real this time)
On Thu, 31 Mar 2005, Karl Denninger wrote: What do you expect the patch to do, given that removing the delta appears to fix the instability problem? I expect the patch to properly stop the callout. -- 10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00 ___ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: DANGER WILL ROBINSON! SERIOUS problem with current5.4-PRERELEASE - UPDATE (real this time)
On Thu, Mar 31, 2005 at 12:19:13PM -0500, Matthew N. Dodd wrote: On Thu, 31 Mar 2005, Karl Denninger wrote: What do you expect the patch to do, given that removing the delta appears to fix the instability problem? I expect the patch to properly stop the callout. Ok, so the implication is that the callouts are/were being triggered and dumped on the floor without it? Would you prefer me to validate that path before or after I attempt to validate that removing the first delta fixes the crashes on my production machine? (Reason for the question is that the latter will require most of the rest of the day and evening, while the former can likely be done by 3-4 pm today) -- -- Karl Denninger ([EMAIL PROTECTED]) Internet Consultant Kids Rights Activist http://www.denninger.netMy home on the net - links to everything I do! http://scubaforum.org Your UNCENSORED place to talk about DIVING! http://www.spamcuda.net SPAM FREE mailboxes - FREE FOR A LIMITED TIME! http://genesis3.blogspot.comMusings Of A Sentient Mind ___ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to [EMAIL PROTECTED]
