Re: buildworld fail in stable/11 @r325033 -- r325029?

[David Wolfskill]

On Fri, Oct 27, 2017 at 05:42:18PM +0300, Konstantin Belousov wrote:
> ...
> Can you confirm that the following patch allows your system to build ?
> 
> Index: lib/libprocstat/libprocstat.c
> ===
> --- lib/libprocstat/libprocstat.c (revision 325038)
> +++ lib/libprocstat/libprocstat.c (working copy)
> @@ -63,10 +63,10 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #define  _KERNEL
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> Index: .
> ===
> 

Yes: Thanks, Konstantin; that worked rather nicely:

FreeBSD localhost 11.1-STABLE FreeBSD 11.1-STABLE #432  
r325033M/325033:1101506: Fri Oct 27 08:18:47 PDT 2017 
r...@g1-252.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY  amd64

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Unsubstantiated claims of "Fake News" are evidence that the claimant lies again.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature

Re: buildworld fail in stable/11 @r325033 -- r325029?

[Harry Schmalzbauer]

 Bezüglich Konstantin Belousov's Nachricht vom 27.10.2017 16:42
(localtime):
> On Fri, Oct 27, 2017 at 04:12:54AM -0700, David Wolfskill wrote:
>> This is observed on systems (both my laptop & my build machine) running
>> stable/11 @r325003, after updating sources to r325033:
>>
>> --- libprocstat.o ---
>> In file included from /usr/src/lib/libprocstat/libprocstat.c:69:
>> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has 
>> incomplete type 'struct siginfo32'
>> struct siginfo32 pl_siginfo;/* siginfo for signal */
>>  ^
>> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward 
>> declaration of 'struct siginfo32'
>> struct siginfo32 pl_siginfo;/* siginfo for signal */
>>^
>>
>> I don't know that r325029 is to blame, but that was the last commit
>> in that area (in the range r325003 -  r325033).  And there wwer not
>> very many commits to stable/11 in that range:
> Can you confirm that the following patch allows your system to build ?
>
> Index: lib/libprocstat/libprocstat.c
> ===
> --- lib/libprocstat/libprocstat.c (revision 325038)
> +++ lib/libprocstat/libprocstat.c (working copy)
> @@ -63,10 +63,10 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #define  _KERNEL
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> Index: .
> ===
> --- . (revision 325038)
> +++ . (working copy)
>

Confirmed.
Sorry for the obsolete last post. It's been in the pipeline for build
time and haven't checked that you already posted the solution!

-harry

___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Re: buildworld fail in stable/11 @r325033 -- r325029?

[Harry Schmalzbauer]

 Bezüglich David Wolfskill's Nachricht vom 27.10.2017 13:12 (localtime):
> This is observed on systems (both my laptop & my build machine) running
> stable/11 @r325003, after updating sources to r325033:
>
> --- libprocstat.o ---
> In file included from /usr/src/lib/libprocstat/libprocstat.c:69:
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has 
> incomplete type 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>  ^
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward 
> declaration of 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>^

I know nothing about the code changes in r324932 (MFC r316286), but the
followup fix r325029 (MFC r320481) seems to have caused the early
buildworld failure in stable/11 – for me too.
Since clang reported the error referencing some include from obj/tmp
(tmp/usr/include/sys/ptrace.h), I found:
r316304
(https://svnweb.freebsd.org/base/head/lib/libprocstat/libprocstat.c?view=patch=316304=316303=316304),
which I thought could explain the symptom.
Seems to be the solution (applies cleanly to stable/11, buildworld
succeded). Even a blind squirrel sometimes finds the nut ;-)

-harry
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Re: buildworld fail in stable/11 @r325033 -- r325029?

[Konstantin Belousov]

On Fri, Oct 27, 2017 at 04:12:54AM -0700, David Wolfskill wrote:
> This is observed on systems (both my laptop & my build machine) running
> stable/11 @r325003, after updating sources to r325033:
> 
> --- libprocstat.o ---
> In file included from /usr/src/lib/libprocstat/libprocstat.c:69:
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has 
> incomplete type 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>  ^
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward 
> declaration of 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>^
> 
> I don't know that r325029 is to blame, but that was the last commit
> in that area (in the range r325003 -  r325033).  And there wwer not
> very many commits to stable/11 in that range:

Can you confirm that the following patch allows your system to build ?

Index: lib/libprocstat/libprocstat.c
===
--- lib/libprocstat/libprocstat.c   (revision 325038)
+++ lib/libprocstat/libprocstat.c   (working copy)
@@ -63,10 +63,10 @@
 #include 
 #include 
 #include 
+#include 
 #define_KERNEL
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
Index: .
===
--- .   (revision 325038)
+++ .   (working copy)

Property changes on: .
___
Modified: svn:mergeinfo
## -0,0 +0,1 ##
   Merged /head:r316304
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Re: buildworld fail in stable/11 @r325033 -- r325029?

[Dan Mack]

FWIW - I had a successful build yesterday on stable/11 r325010; I have
not tried anything newer yet.

Dan

David Wolfskill  writes:

> This is observed on systems (both my laptop & my build machine) running
> stable/11 @r325003, after updating sources to r325033:
>
> --- libprocstat.o ---
> In file included from /usr/src/lib/libprocstat/libprocstat.c:69:
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has 
> incomplete type 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>  ^
> /usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward 
> declaration of 'struct siginfo32'
> struct siginfo32 pl_siginfo;/* siginfo for signal */
>^
>
> I don't know that r325029 is to blame, but that was the last commit
> in that area (in the range r325003 -  r325033).  And there wwer not
> very many commits to stable/11 in that range:
>
> 1. Oct 27 Konstantin Belousov svn commit: r325033 - stable/11/sys/vm
> 2. Oct 27 Bryan Drewery   svn commit: r325029 - in stable/11: 
> sys/compat/freeb
> 3. Oct 26 Ian Lepore  svn commit: r325023 - stable/11/sys/dev/sdhci
> 4. Oct 26 Tijl Coosemans  svn commit: r325015 - in stable/11/sys: 
> compat/linsy
> 5. Oct 25 Alan Somers svn commit: r325003 - in stable/11: sys/geom 
> sys/sys
>
> Peace,
> david
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

buildworld fail in stable/11 @r325033 -- r325029?

[David Wolfskill]

This is observed on systems (both my laptop & my build machine) running
stable/11 @r325003, after updating sources to r325033:

--- libprocstat.o ---
In file included from /usr/src/lib/libprocstat/libprocstat.c:69:
/usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:19: error: field has 
incomplete type 'struct siginfo32'
struct siginfo32 pl_siginfo;/* siginfo for signal */
 ^
/usr/obj/usr/src/tmp/usr/include/sys/ptrace.h:148:9: note: forward declaration 
of 'struct siginfo32'
struct siginfo32 pl_siginfo;/* siginfo for signal */
   ^

I don't know that r325029 is to blame, but that was the last commit
in that area (in the range r325003 -  r325033).  And there wwer not
very many commits to stable/11 in that range:

1. Oct 27 Konstantin Belousov svn commit: r325033 - stable/11/sys/vm
2. Oct 27 Bryan Drewery   svn commit: r325029 - in stable/11: 
sys/compat/freeb
3. Oct 26 Ian Lepore  svn commit: r325023 - stable/11/sys/dev/sdhci
4. Oct 26 Tijl Coosemans  svn commit: r325015 - in stable/11/sys: 
compat/linsy
5. Oct 25 Alan Somers svn commit: r325003 - in stable/11: sys/geom 
sys/sys

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Unsubstantiated claims of "Fake News" are evidence that the claimant lies again.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature