Re: cvs commit: src/sys/kern vfs_subr.c

[Kelly Yancey]

On Sun, 13 Oct 2002, Stefan Farfeleder wrote:

 On Sun, Oct 13, 2002 at 07:22:17PM +0400, Dmitry Morozovsky wrote:
  On Sun, 13 Oct 2002, Dmitry Morozovsky wrote:
 
  DM On Sun, 13 Oct 2002, Kelly Yancey wrote:
  DM
  DM KY kbyanc  2002/10/13 00:38:41 PDT
  DM KY
  DM KY   Modified files:(Branch: RELENG_4)
  DM KY sys/kern vfs_subr.c
  DM KY   Log:
  DM KY   Use sys/queue.h macros rather than fondling implementation details.
  DM
  DM Kelly, it seems this commit broke -stable (see PR/44007)
 
  ... and I can confirm that backing out this change revert -stable to working
 
  (patch for band-aiding follows)
 
  Index: sys/kern/vfs_subr.c
  ===
  RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
  retrieving revision 1.249.2.28
  diff -u -r1.249.2.28 vfs_subr.c
  --- sys/kern/vfs_subr.c 13 Oct 2002 07:38:41 -  1.249.2.28
  +++ sys/kern/vfs_subr.c 13 Oct 2002 15:17:55 -
  @@ -1256,7 +1256,7 @@
  KASSERT(bp-b_vp != NULL, (pbrelvp: NULL));
 
  /* XXX REMOVE ME */
  -   if (!TAILQ_NEXT(bp, b_vnbufs)) {
  +   if (bp-b_vnbufs.tqe_next != NULL) {
  panic(
  relpbuf(): b_vp was probably reassignbuf()d %p %x,
  bp,
 
 

 The line should probably read:

 if (TAILQ_NEXT(bp, b_vnbufs) != NULL) {


  Yeah, I inverted the sense.  Sorry.

  Kelly

--
Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org}
Join distributed.net Team FreeBSD: http://www.posi.net/freebsd/Team-FreeBSD/


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-stable in the body of the message

Re: cvs commit: src/sys/kern vfs_subr.c

[Kelly Yancey]

On Sun, 13 Oct 2002, Dmitry Morozovsky wrote:

 On Sun, 13 Oct 2002, Ian Dowse wrote:

 ID KY   Use sys/queue.h macros rather than fondling implementation details.
 ID 
 ID Kelly, it seems this commit broke -stable (see PR/44007)
 ID
 ID As this seemed to affect quite a few people, I went ahead and checked
 ID in the obvious fix in case it is a few hours until Kelly returns.
 ID Thanks to you and others for identifying the changed that caused
 ID this!
 ID
 ID Can somebody confirm that revision 1.249.2.29 of vfs_subr.c does
 ID indeed fix the relpbuf() panics?

 I just patch vfs_subr.c with your change, and confirm that machine is up and
 running ;-)

 Thanks for your quick reaction -- broken -stable is not The Right Thing [tm]!


  Ian, thanks for catching this so quick.  I don't know why my test machine
didn't panic, but the error is so obvious it should have.  Thanks again,

  Kelly

--
Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org}
Join distributed.net Team FreeBSD: http://www.posi.net/freebsd/Team-FreeBSD/


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-stable in the body of the message