Re: xffm - xfsamba4 broken in 5-stable?

2005-06-04 Thread Torfinn Ingolfsen
On Sat, 04 Jun 2005 20:27:35 +0200
Torfinn Ingolfsen <[EMAIL PROTECTED]> wrote:

> Ok, so you just removed that line from tubo.c?

Reading the line in context shows that this might indeed be the correct
fix, here is the context:
#ifdef  __FreeBSD__
/* This apparently does the bug workaround for wait failure
 * on FreeBSD 5.1: */
 if (kill(PID,SIGCONT) == 0) return TRUE;
#endif

Perhaps this should be removed, or at least fixed so that it only is
needed on FreeBSD 5.1.

> I wonder if this is the correct way to fix it, but anyway, I'm going
> to try it.

And it worked. I did a 'make extract' in the xfce4-fm port directory,
removed the offending line 'if (kill(PID...', and did a 'make deinstall'
followed by a 'make reinstall'.
Now xfsamba4 works like it did before.
-- 
Regards, 
Torfinn Ingolfsen,
Norway

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: xffm - xfsamba4 broken in 5-stable?

2005-06-04 Thread Torfinn Ingolfsen
On Tue, 31 May 2005 20:39:47 +0300
Andriy Gapon <[EMAIL PROTECTED]> wrote:

> if (kill(PID,SIGCONT) == 0) return TRUE;
> 
> [ cut  lorts of interesting text ]
> 
> Removing that line fixed xfsamba4 for me, but I encountered another

Ok, so you just removed that line from tubo.c?
I wonder if this is the correct way to fix it, but anyway, I'm going to
try it.

> problem after that, my PDC (NT4) doesn't respond to the following
> request (Samba3 client):
>   nmblookup -A 
> so instead I had to use
>   nmblookup -M -S -- -

FWIW, my (non-working) xfsamba4 uses 'nmblookup -M -- -' (that dash M
double dash  dash)

> and this made xfsamba4 perfectly well.

Perhaps you should send-pr this information.
-- 
Regards
Torfinn Ingolfsen,
Norway

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


xffm - xfsamba4 broken in 5-stable?

2005-05-31 Thread Andriy Gapon

I've had the same problem and I think everybody using recent FreeBSD has
it. The culprit seems to be the following line in tubo.c:

if (kill(PID,SIGCONT) == 0) return TRUE;

I am not sure about other OS's and what POSIX mandates in this case, but
FreeBSD 5.4 allows to send signals to child processes that have exited
but have not been reaped by parent. They show up in ps like this:
 5320  pd  Z+ 0:00,05 

Because of the quoted line of code nmblookup processes are never reaped
and xfsamba4 goes into infinite loop.

Probably FreeBSD 5.1 had problems with respect to the described
situation (it was an experimental release after all) and that line was a
work-around for some FreeBSD bug, but now it actually breaks things.

Removing that line fixed xfsamba4 for me, but I encountered another
problem after that, my PDC (NT4) doesn't respond to the following
request (Samba3 client):
nmblookup -A 
so instead I had to use
nmblookup -M -S -- -
and this made xfsamba4 perfectly well.


P.S. just found the following about POSIX, kill, and defunct child
processes:

http://www.opengroup.org/onlinepubs/009695399/functions/kill.html

Existing implementations vary on the result of a kill() with pid
indicating an inactive process (a terminated process that has not been
waited for by its parent). Some indicate success on such a call (subject
to permission checking), while others give an error of [ESRCH]. Since
the definition of process lifetime in this volume of IEEE Std
1003.1-2001 covers inactive processes, the [ESRCH] error as described is
inappropriate in this case. In particular, this means that an
application cannot have a parent process check for termination of a
particular child with kill(). (Usually this is done with the null
signal; this can be done reliably with waitpid().)

-- 
Andriy Gapon
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


xffm - xfsamba4 broken in 5-stable?

2005-03-17 Thread Torfinn Ingolfsen
Hi,

Are there any known problems with xfsamba4 (part of xffm, which is part
of the xfce desktop) in FreeBSD 5-stable?

The problem is that I can start xffm (or xfsamba4) and try to access the
SMB Network. xffm says "Lloading...",  the status window shows 
"XFSAMBA> nmblookup -M -- -" and then nothing happens. If I run the
same nmblookup command from the same shell (and the same user) it
completes immediately.

It works on 4-stable, with xfce 4.0.6:
[EMAIL PROTECTED] uname -a
FreeBSD kg-htpc.kg4.no 4.9-STABLE FreeBSD 4.9-STABLE #4: Sat Apr  3
16:54:21 CEST 2004 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/HERMES 
i386

[EMAIL PROTECTED] pv | grep xfce4-fm
xfce4-fm-4.0.6_1=  up-to-date with port


I have tried this on two machines with 5-stable, one is from November
[EMAIL PROTECTED] uname -a
FreeBSD kg-work.kg4.no 5.3-STABLE FreeBSD 5.3-STABLE #1: Sun Nov 14
20:19:11 CET 2004 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/SS51G 
i386

and the other from February:
[EMAIL PROTECTED] uname -a
FreeBSD kg-jobbpc3.kg4.no 5.3-STABLE FreeBSD 5.3-STABLE #1: Sat Feb  5
20:36:25 CET 2005 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/T41 
i386

xfce is version 4.2.0:
xfce4-fm-4.2.0  =  up-to-date with port
xfce4-fm-4.2.0_1=  up-to-date with port

I have read through /usr/ports/UPDATING but coldn't find any hints
there, I have searched Google, and I have checked xffm on Freshports.
Nowhere have I found a hint that will help me fix this.

Any hints appreciated.
-- 
Regards,
Torfinn Ingolfsen,
Norway

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[EMAIL PROTECTED]"