[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 Fernando Apesteguía changed: What|Removed |Added Flags||merge-quarterly+ --- Comment #16 from Fernando Apesteguía --- Done. Thanks for looking at this! -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #15 from commit-h...@freebsd.org --- A commit references this bug: Author: fernape Date: Thu Nov 12 11:22:09 UTC 2020 New revision: 554951 URL: https://svnweb.freebsd.org/changeset/ports/554951 Log: MFH: r554949 mail/cclient: Unbreak in 11.4 and 12.2 Dimitry sent a more generic patch that workarounds the problem in mail/cclient instead of its consumers. Related to r554904. PR: 250740 Submitted by: d...@freebsd.org Reported by: co...@fbug.ksac.uk Approved by: ports-secteam (blanket, build fix) Changes: _U branches/2020Q4/ branches/2020Q4/mail/cclient/Makefile branches/2020Q4/mail/cclient/files/patch-src_c-client_c-client.h -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #14 from commit-h...@freebsd.org --- A commit references this bug: Author: fernape Date: Thu Nov 12 11:18:35 UTC 2020 New revision: 554949 URL: https://svnweb.freebsd.org/changeset/ports/554949 Log: mail/cclient: Unbreak in 11.4 and 12.2 Dimitry sent a more generic patch that workarounds the problem in mail/cclient instead of its consumers. Related to r554904. PR: 250740 Submitted by: d...@freebsd.org Reported by: co...@fbug.ksac.uk MFH: 2020Q4 (blanket, build fix) Changes: head/mail/cclient/Makefile head/mail/cclient/files/patch-src_c-client_c-client.h -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #13 from Colin --- (In reply to Dimitry Andric from comment #12) Thanks Dmitry. Just to confirm cclient and mailsync also build cleanly on my system after applying your patch. This may be a more general approach, if there are other ports still dependent on cclient. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #12 from Dimitry Andric --- Created attachment 219566 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=219566=edit Work around the #define hacks in c-client.h Here's an alternative patch, which should also make mailsync compile with clang++, on 12.2-R. Basically, it undefines all the keywords again before including osdep.h (which is the root cause of the original errors), then redefines them again. It's ugly but it works. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #11 from Colin --- (In reply to Fernando Apesteguía from comment #9) Thank you both. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 Fernando Apesteguía changed: What|Removed |Added Resolution|--- |FIXED Status|New |Closed --- Comment #10 from Fernando Apesteguía --- Committed, We should probably expire mail/cclient and consequently mail/mailsync when the former breaks again. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #9 from Fernando Apesteguía --- (In reply to Dimitry Andric from comment #7) Thanks for the exaplanation :) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #8 from commit-h...@freebsd.org --- A commit references this bug: Author: fernape Date: Wed Nov 11 17:25:22 UTC 2020 New revision: 554904 URL: https://svnweb.freebsd.org/changeset/ports/554904 Log: mail/mailsync: Unbreak in 11.4 and 12.2 This port is broken in 12.2 and 11.4, but not in 12.1 or 13-current. The problem is the old mail/cclient doing things like redefining C++ keywords. Workaround this by building with GCC in those releases where it is broken. PR: 250740 Submitted by: co...@fbug.ksac.uk Changes: head/mail/mailsync/Makefile -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #7 from Dimitry Andric --- (In reply to Fernando Apesteguía from comment #4) First of all, the c-client software was clearly written before C++ existed, since it uses C++ keywords as struct member names, so that is why they have to hack around it with #defining those keywords to something non-conflicting. However, those defines should *not* be active when including any system headers, and that is clearly violated by the c-client.h file. It is simply totally broken, and you were lucky that it worked at all. In any case, it is likely not about clang or clang++, but about the used libc++ headers. If you use C++, libc++ overrides certain standard C headers such as stdio.h, string.h, etc. Since the c-client headers are including multiple system headers with 'private' redefined, this wreaks havoc when it eventually goes into libc++'s own headers. I guess g++ doesn't work that way, but I haven't investigated. In my opinion, c-client is obsolete software which is clearly incompatible with C++, and should either be patched up to relatively non-ancient standards, or ditched altogether. Note that mailsync itself does not look much better. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 Colin changed: What|Removed |Added Attachment #219563|text/x-log |text/plain mime type|| --- Comment #6 from Colin --- Created attachment 219563 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=219563=edit Poudriere build log under 12.2-RELEASE/LLVM10 with patch applied -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 --- Comment #5 from Colin --- (In reply to Fernando Apesteguía from comment #1) I confirm that, with that patch applied, it then builds successfully in my 12.2R environment. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740
--- Comment #4 from Fernando Apesteguía ---
(In reply to Dimitry Andric from comment #3)
Hi Dimitry!
Yes, it does something similar with "and", "or"... and workarounds the problem
by using -fno-name-operators.
Having a look at the code it looks like the author thought that flag would
protect them:
extern "C" {
/* If you use gcc, you may also have to use -fno-operator-names */
#define private cclientPrivate /* private to c-client */
#define and cclientAnd /* C99 doesn't realize that ISO 646 is dead */
#define or cclientOr
#define not cclientNot
#endif
Now, my question is why does it work in different versions of clang, including
the most recent one but seems to fail from time to time across versions?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740 Dimitry Andric changed: What|Removed |Added CC||d...@freebsd.org --- Comment #3 from Dimitry Andric --- (In reply to Fernando Apesteguía from comment #1) > /usr/include/c++/v1/type_traits:1364:1: error: unknown type name > 'cclientPrivate' > private: > ^ > /usr/local/include/c-client/c-client.h:35:17: note: expanded from macro > 'private' > #define private cclientPrivate /* private to c-client */ > ^ I don't know where this port got the idea that it's OK to redefine C++ keywords, and expect anything to keep working? Remove that nonsense and it might start working. :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 250740] mail/mailsync 12.2-RELEASE breaks package build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250740
Fernando Apesteguía changed:
What|Removed |Added
Severity|Affects Only Me |Affects Some People
CC||toolch...@freebsd.org
--- Comment #2 from Fernando Apesteguía ---
^Triage: adding toolchain@ to see if they can shed some light here.
It seems we have a bug/limitation that shows up and hides depending of the
version.
So without the patch:
11.4{amd64,i386}: Fails
12.1{amd64,i386}: OK
12.2amd64: Fails
13-current: OK (r366283)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
