Re: Lock annotations: enable them for libpthread, libstdthreads
On Sat, Aug 30, 2014 at 07:33:27AM +0200, Ed Schouten wrote: On 28 August 2014 19:34, Ed Schouten e...@80386.nl wrote: My gut feeling is that impact is minimal. Buildworlds seem to take approximately the same time, mainly because we don't have that many annotated objects/functions/expressions. I will do some measurements. Some measurements: I've done five 'make buildworlds' with -Wthread-safety and five without. This was just a single-threaded build (no -j). Real time to build world: -Wthread-safety 1:12:55.60 1:12:48.81 1:12:56.33 1:12:44.58 1:12:48.14 -Wno-thread-safety 1:12:50.50 1:12:52.43 1:12:48.20 1:12:42.85 1:12:43.19 That said, this a pretty fast box (i7 4770) with 32 GB of RAM. Unfortunately, I currently don't have any system running FreeBSD that is significantly slower than that. So if you still have any concerns regarding build times, I would really appreciate it if you'd test this patch yourself. Thanks for testing. The above reduces my fear of feature creep where each change only adds a little bit more time to buildworld. -- Steve ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org
Re: Lock annotations: enable them for libpthread, libstdthreads
Hi, On 28 August 2014 19:34, Ed Schouten e...@80386.nl wrote: My gut feeling is that impact is minimal. Buildworlds seem to take approximately the same time, mainly because we don't have that many annotated objects/functions/expressions. I will do some measurements. Some measurements: I've done five 'make buildworlds' with -Wthread-safety and five without. This was just a single-threaded build (no -j). Real time to build world: -Wthread-safety 1:12:55.60 1:12:48.81 1:12:56.33 1:12:44.58 1:12:48.14 -Wno-thread-safety 1:12:50.50 1:12:52.43 1:12:48.20 1:12:42.85 1:12:43.19 That said, this a pretty fast box (i7 4770) with 32 GB of RAM. Unfortunately, I currently don't have any system running FreeBSD that is significantly slower than that. So if you still have any concerns regarding build times, I would really appreciate it if you'd test this patch yourself. Thanks, -- Ed Schouten e...@80386.nl ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org
Re: Lock annotations: enable them for libpthread, libstdthreads
On 28 August 2014 10:34, Ed Schouten e...@80386.nl wrote: On 28 August 2014 19:18, Steve Kargl s...@troutmask.apl.washington.edu wrote: What it is the performance penalty (time and memory)? That is, buildworld already takes a long time on my system because of clang. My gut feeling is that impact is minimal. Buildworlds seem to take approximately the same time, mainly because we don't have that many annotated objects/functions/expressions. I will do some measurements. Would you please test on something that isn't the latest generation hardware? Even just a core 2 duo would be fine. -a ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org
