Re: usb/149675: commit references a PR
The following reply was made to PR usb/149675; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: usb/149675: commit references a PR
Date: Sun, 28 Nov 2010 07:28:18 + (UTC)
Author: thompsa
Date: Sun Nov 28 07:28:10 2010
New Revision: 215986
URL: http://svn.freebsd.org/changeset/base/215986
Log:
MFC r213872
Fix forwarding of Line Register Status changes to TTY layer.
PR: usb/149675
Modified:
stable/8/sys/dev/usb/serial/usb_serial.c
Directory Properties:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
Modified: stable/8/sys/dev/usb/serial/usb_serial.c
==
--- stable/8/sys/dev/usb/serial/usb_serial.c Sun Nov 28 07:23:05 2010
(r215985)
+++ stable/8/sys/dev/usb/serial/usb_serial.c Sun Nov 28 07:28:10 2010
(r215986)
@@ -942,6 +942,7 @@ ucom_cfg_status_change(struct usb_proc_m
uint8_t new_msr;
uint8_t new_lsr;
uint8_t onoff;
+ uint8_t lsr_delta;
tp = sc->sc_tty;
@@ -965,6 +966,7 @@ ucom_cfg_status_change(struct usb_proc_m
return;
}
onoff = ((sc->sc_msr ^ new_msr) & SER_DCD);
+ lsr_delta = (sc->sc_lsr ^ new_lsr);
sc->sc_msr = new_msr;
sc->sc_lsr = new_lsr;
@@ -977,6 +979,30 @@ ucom_cfg_status_change(struct usb_proc_m
ttydisc_modem(tp, onoff);
}
+
+ if ((lsr_delta & ULSR_BI) && (sc->sc_lsr & ULSR_BI)) {
+
+ DPRINTF("BREAK detected\n");
+
+ ttydisc_rint(tp, 0, TRE_BREAK);
+ ttydisc_rint_done(tp);
+ }
+
+ if ((lsr_delta & ULSR_FE) && (sc->sc_lsr & ULSR_FE)) {
+
+ DPRINTF("Frame error detected\n");
+
+ ttydisc_rint(tp, 0, TRE_FRAMING);
+ ttydisc_rint_done(tp);
+ }
+
+ if ((lsr_delta & ULSR_PE) && (sc->sc_lsr & ULSR_PE)) {
+
+ DPRINTF("Parity error detected\n");
+
+ ttydisc_rint(tp, 0, TRE_PARITY);
+ ttydisc_rint_done(tp);
+ }
}
void
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
Re: USB controller error logged when resuming after suspend
On Fri, Nov 26, 2010 at 1:49 AM, Bruce Cran wrote: > On Thu, 25 Nov 2010 20:46:42 -0600 > Brandon Gooch wrote: > >> It's becoming more well known that the USB stack isn't >> "suspend/resume" safe at this point. Have you tried building your USB >> systems as kernel modules and unloading/loading them via >> /etc/rs.suspend|resume? I used to have luck doing that here, but >> recently that has broken as well (running HEAD). > > I'm not so interested in using suspend/resume as a real feature, > but more as a developer to report issues so that in the future we can > perhaps have it working for end-users. Apparently there's lots of > infrastructure work that still needs to be done before it's going to be > reliable unfortunately. Do you mean USB subsystem infrastructure, or something more far-reaching? It seems to me that it's SO close to being functional; in fact, I've taken to not loading any USB drivers at all on my notebook, which seems to be the only "reliable" way of using suspend/resume -- that's not to say that it's perfect, but Pretty Good(TM). Also, If we could round-up the various sysctl settings and document them in one place([1] or [2]), I imagine many users would have suspend/resume as a workable feature, at least on amd64... -Brandon [1] http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/acpi-debug.html [2] http://www.freebsd.org/doc/en/articles/laptop/article.html or ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
Re: usb/149039: commit references a PR
The following reply was made to PR usb/149039; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: usb/149039: commit references a PR Date: Sat, 27 Nov 2010 19:39:35 + (UTC) Author: thompsa Date: Sat Nov 27 19:39:29 2010 New Revision: 215947 URL: http://svn.freebsd.org/changeset/base/215947 Log: MFC r213803 USB network (UHSO): - Correct network interface flags. PR: usb/149039 Submitted by:Fredrik Lindberg Modified: stable/8/sys/dev/usb/net/uhso.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/mips/alchemy/ (props changed) stable/8/sys/mips/atheros/ (props changed) stable/8/sys/mips/cavium/ (props changed) stable/8/sys/mips/cavium/dev/ (props changed) stable/8/sys/mips/rmi/ (props changed) stable/8/sys/mips/rmi/dev/ (props changed) stable/8/sys/mips/sibyte/ (props changed) Modified: stable/8/sys/dev/usb/net/uhso.c == --- stable/8/sys/dev/usb/net/uhso.cSat Nov 27 19:38:40 2010 (r215946) +++ stable/8/sys/dev/usb/net/uhso.cSat Nov 27 19:39:29 2010 (r215947) @@ -1560,7 +1560,7 @@ uhso_attach_ifnet(struct uhso_softc *sc, ifp->if_init = uhso_if_init; ifp->if_start = uhso_if_start; ifp->if_output = uhso_if_output; - ifp->if_flags = 0; + ifp->if_flags = IFF_BROADCAST | IFF_MULTICAST | IFF_NOARP; ifp->if_softc = sc; IFQ_SET_MAXLEN(&ifp->if_snd, ifqmaxlen); ifp->if_snd.ifq_drv_maxlen = ifqmaxlen; ___ svn-src-...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
