Re: Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Alex Deiter
Hi Kal,

Thanks a lot for your patch!
I`m apply  this patch and my bt mouse work fine again!

For Hans:

 Which daemon is driving the BT mouse?
bthidd

patch for bthidd(8) works fine only WITH your patches for:
lib/libusbhid/data.c
sys/dev/usb/usb_hid.c
sys/dev/usb/usbhid.h

Thanks a lot!

2010/5/7 Kai Wang kaiwan...@gmail.com:
 On Fri, May 07, 2010 at 01:58:13AM +0400, Alex Deiter wrote:
 Hi,

 Bluetooth mouse support is broken after Revision 205728:

 http://svn.freebsd.org/viewvc/base?view=revisionrevision=205728

 When I move the mouse  - cursor stays in same place but moves the
 current position of the console.

 Proposed patch as an attachment. Could you please revew this ?

 Hi Alex,

 If we adopt your patch, usbhidctl(1) and usbhidaction(1) will be
 broken again on device with multiple report IDs.

 Could you please try if the attached patch for the bthidd(8)
 daemon works as well?

 Thanks,
 Kai




-- 
--
Alex Deiter
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Alex Deiter
Hi Hans,

I`m apply  patch for bthidd from Kal and my bt mouse work fine again!

 Which daemon is driving the BT mouse?
bthidd

patch from Kal for bthidd(8) works fine only WITH your patches for:
lib/libusbhid/data.c
sys/dev/usb/usb_hid.c
sys/dev/usb/usbhid.h

Thanks a lot!

2010/5/7 Hans Petter Selasky hsela...@c2i.net:
 On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
 Hi,

 Thanks a lot for your reply!
 I`m applied patches and rebuild kernel and world.
 After system reboot problem still persist:

 PS/2 mouse work fine
 USB mouse work fine
 Bluetooth mouse doesn't'work - see attached video (can be view with
  mplayer)

 P.S. with my patch bt mouse work fine

 Thanks a lot!

 Which daemon is driving the BT mouse?

 --HPS




-- 
--
Alex Deiter
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org


Revision 205728: broken bluetooth mouse support

2010-05-06 Thread Alex Deiter
Hi,

Bluetooth mouse support is broken after Revision 205728:

http://svn.freebsd.org/viewvc/base?view=revisionrevision=205728

When I move the mouse  - cursor stays in same place but moves the
current position of the console.

Proposed patch as an attachment. Could you please revew this ?

Thanks a lot!

--
Alex Deiter
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org


usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-06 Thread Alex Deiter

Number: 146367
Category:   usb
Synopsis:   [PATCH] Revision 205728: broken bluetooth mouse support
Confidential:   no
Severity:   serious
Priority:   medium
Responsible:freebsd-usb
State:  open
Quarter:
Keywords:   
Date-Required:
Class:  sw-bug
Submitter-Id:   current-users
Arrival-Date:   Fri May 07 03:50:01 UTC 2010
Closed-Date:
Last-Modified:
Originator: Alex Deiter
Release:9.0
Organization:
N/A
Environment:
today 9.0-current (Revision 207680)
Description:
Hi,

Bluetooth mouse support is broken after Revision 205728:

http://svn.freebsd.org/viewvc/base?view=revisionrevision=205728

When I move the mouse  - cursor stays in same place but moves the
current position of the console.

Proposed patch as an attachment. Could you please revew this ?

Thanks a lot!

How-To-Repeat:

Fix:
please review patch

Patch attached with submission follows:

--- lib/libusbhid/data.c.orig   2010-05-07 01:26:45.192120194 +0400
+++ lib/libusbhid/data.c2010-05-07 01:55:56.114702254 +0400
@@ -40,15 +40,10 @@
const uint8_t *buf;
uint32_t hpos;
uint32_t hsize;
-   uint32_t data;
+   int32_t data;
int i, end, offs;
 
buf = p;
-
-   /* Skip report ID byte. */
-   if (h-report_ID  0)
-   buf++;
-
hpos = h-pos;  /* bit position of data */
hsize = h-report_size; /* bit length of data */
 


Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org