Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Hans Petter Selasky
On Friday 07 May 2010 05:49:43 Alex Deiter wrote:
> Alex Deiter
> 

Hi,

The first part of the patch is not correct. The ID byte should be included in 
the buffer or you need to extend the buffer. Note that the kernel version of 
hid_get_data() is different at this point.

The second part of your patch is correct, and indicates a merge glitch, due to 
changing the signedness of the data type some time back.

Can you try the following patch in kernel and user-space and see that it works 
for your BT-mouse and USB-mouse?

http://p4web.freebsd.org/@@177882?ac=10

--HPS
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Hans Petter Selasky
The following reply was made to PR usb/146367; it has been noted by GNATS.

From: Hans Petter Selasky 
To: freebsd-usb@freebsd.org
Cc: Alex Deiter ,
 freebsd-gnats-sub...@freebsd.org
Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
Date: Fri, 7 May 2010 09:38:49 +0200

 On Friday 07 May 2010 05:49:43 Alex Deiter wrote:
 > Alex Deiter
 > 
 
 Hi,
 
 The first part of the patch is not correct. The ID byte should be included in 
 the buffer or you need to extend the buffer. Note that the kernel version of 
 hid_get_data() is different at this point.
 
 The second part of your patch is correct, and indicates a merge glitch, due to 
 changing the signedness of the data type some time back.
 
 Can you try the following patch in kernel and user-space and see that it works 
 for your BT-mouse and USB-mouse?
 
 http://p4web.freebsd.org/@@177882?ac=10
 
 --HPS
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Hans Petter Selasky
On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
> Hi,
> 
> Thanks a lot for your reply!
> I`m applied patches and rebuild kernel and world.
> After system reboot problem still persist:
> 
> PS/2 mouse work fine
> USB mouse work fine
> Bluetooth mouse doesn't'work - see attached video (can be view with
>  mplayer)
> 
> P.S. with my patch bt mouse work fine
> 
> Thanks a lot!

Which daemon is driving the BT mouse?

--HPS
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Hans Petter Selasky
The following reply was made to PR usb/146367; it has been noted by GNATS.

From: Hans Petter Selasky 
To: Alex Deiter 
Cc: freebsd-usb@freebsd.org,
 freebsd-gnats-sub...@freebsd.org
Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
Date: Fri, 7 May 2010 12:14:14 +0200

 On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
 > Hi,
 > 
 > Thanks a lot for your reply!
 > I`m applied patches and rebuild kernel and world.
 > After system reboot problem still persist:
 > 
 > PS/2 mouse work fine
 > USB mouse work fine
 > Bluetooth mouse doesn't'work - see attached video (can be view with
 >  mplayer)
 > 
 > P.S. with my patch bt mouse work fine
 > 
 > Thanks a lot!
 
 Which daemon is driving the BT mouse?
 
 --HPS
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Kai Wang
On Fri, May 07, 2010 at 12:14:14PM +0200, Hans Petter Selasky wrote:
> On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
> > Hi,
> > 
> > Thanks a lot for your reply!
> > I`m applied patches and rebuild kernel and world.
> > After system reboot problem still persist:
> > 
> > PS/2 mouse work fine
> > USB mouse work fine
> > Bluetooth mouse doesn't'work - see attached video (can be view with
> >  mplayer)
> > 
> > P.S. with my patch bt mouse work fine
> > 
> > Thanks a lot!
> 
> Which daemon is driving the BT mouse?

It is the bthidd(8) daemon. I've proposed a patch here:

http://lists.freebsd.org/pipermail/freebsd-usb/2010-May/008675.html

But I can not test it since I don't have any bluetooth mouse or keyboard.

Kai
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Kai Wang
The following reply was made to PR usb/146367; it has been noted by GNATS.

From: Kai Wang 
To: Hans Petter Selasky 
Cc: Alex Deiter , freebsd-gnats-sub...@freebsd.org,
freebsd-usb@freebsd.org
Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse
 support
Date: Fri, 7 May 2010 12:21:46 +0200

 On Fri, May 07, 2010 at 12:14:14PM +0200, Hans Petter Selasky wrote:
 > On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
 > > Hi,
 > > 
 > > Thanks a lot for your reply!
 > > I`m applied patches and rebuild kernel and world.
 > > After system reboot problem still persist:
 > > 
 > > PS/2 mouse work fine
 > > USB mouse work fine
 > > Bluetooth mouse doesn't'work - see attached video (can be view with
 > >  mplayer)
 > > 
 > > P.S. with my patch bt mouse work fine
 > > 
 > > Thanks a lot!
 > 
 > Which daemon is driving the BT mouse?
 
 It is the bthidd(8) daemon. I've proposed a patch here:
 
 http://lists.freebsd.org/pipermail/freebsd-usb/2010-May/008675.html
 
 But I can not test it since I don't have any bluetooth mouse or keyboard.
 
 Kai
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Alex Deiter
Hi Hans,

I`m apply  patch for bthidd from Kal and my bt mouse work fine again!

> Which daemon is driving the BT mouse?
bthidd

patch from Kal for bthidd(8) works fine only WITH your patches for:
lib/libusbhid/data.c
sys/dev/usb/usb_hid.c
sys/dev/usb/usbhid.h

Thanks a lot!

2010/5/7 Hans Petter Selasky :
> On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
>> Hi,
>>
>> Thanks a lot for your reply!
>> I`m applied patches and rebuild kernel and world.
>> After system reboot problem still persist:
>>
>> PS/2 mouse work fine
>> USB mouse work fine
>> Bluetooth mouse doesn't'work - see attached video (can be view with
>>  mplayer)
>>
>> P.S. with my patch bt mouse work fine
>>
>> Thanks a lot!
>
> Which daemon is driving the BT mouse?
>
> --HPS
>



-- 
--
Alex Deiter
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support

2010-05-07 Thread Alex Deiter
The following reply was made to PR usb/146367; it has been noted by GNATS.

From: Alex Deiter 
To: Hans Petter Selasky 
Cc: freebsd-usb@freebsd.org, freebsd-gnats-sub...@freebsd.org
Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse 
support
Date: Fri, 7 May 2010 14:39:48 +0400

 Hi Hans,
 
 I`m apply  patch for bthidd from Kal and my bt mouse work fine again!
 
 > Which daemon is driving the BT mouse?
 bthidd
 
 patch from Kal for bthidd(8) works fine only WITH your patches for:
 lib/libusbhid/data.c
 sys/dev/usb/usb_hid.c
 sys/dev/usb/usbhid.h
 
 Thanks a lot!
 
 2010/5/7 Hans Petter Selasky :
 > On Friday 07 May 2010 12:13:15 Alex Deiter wrote:
 >> Hi,
 >>
 >> Thanks a lot for your reply!
 >> I`m applied patches and rebuild kernel and world.
 >> After system reboot problem still persist:
 >>
 >> PS/2 mouse work fine
 >> USB mouse work fine
 >> Bluetooth mouse doesn't'work - see attached video (can be view with
 >>  mplayer)
 >>
 >> P.S. with my patch bt mouse work fine
 >>
 >> Thanks a lot!
 >
 > Which daemon is driving the BT mouse?
 >
 > --HPS
 >
 
 
 
 -- 
 --
 Alex Deiter
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"