Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
On Friday 07 May 2010 05:49:43 Alex Deiter wrote: Alex Deiter Hi, The first part of the patch is not correct. The ID byte should be included in the buffer or you need to extend the buffer. Note that the kernel version of hid_get_data() is different at this point. The second part of your patch is correct, and indicates a merge glitch, due to changing the signedness of the data type some time back. Can you try the following patch in kernel and user-space and see that it works for your BT-mouse and USB-mouse? http://p4web.freebsd.org/@@177882?ac=10 --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
The following reply was made to PR usb/146367; it has been noted by GNATS. From: Hans Petter Selasky hsela...@c2i.net To: freebsd-usb@freebsd.org Cc: Alex Deiter alex.dei...@gmail.com, freebsd-gnats-sub...@freebsd.org Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support Date: Fri, 7 May 2010 09:38:49 +0200 On Friday 07 May 2010 05:49:43 Alex Deiter wrote: Alex Deiter Hi, The first part of the patch is not correct. The ID byte should be included in the buffer or you need to extend the buffer. Note that the kernel version of hid_get_data() is different at this point. The second part of your patch is correct, and indicates a merge glitch, due to changing the signedness of the data type some time back. Can you try the following patch in kernel and user-space and see that it works for your BT-mouse and USB-mouse? http://p4web.freebsd.org/@@177882?ac=10 --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
On Friday 07 May 2010 12:13:15 Alex Deiter wrote: Hi, Thanks a lot for your reply! I`m applied patches and rebuild kernel and world. After system reboot problem still persist: PS/2 mouse work fine USB mouse work fine Bluetooth mouse doesn't'work - see attached video (can be view with mplayer) P.S. with my patch bt mouse work fine Thanks a lot! Which daemon is driving the BT mouse? --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
The following reply was made to PR usb/146367; it has been noted by GNATS. From: Hans Petter Selasky hsela...@c2i.net To: Alex Deiter alex.dei...@gmail.com Cc: freebsd-usb@freebsd.org, freebsd-gnats-sub...@freebsd.org Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support Date: Fri, 7 May 2010 12:14:14 +0200 On Friday 07 May 2010 12:13:15 Alex Deiter wrote: Hi, Thanks a lot for your reply! I`m applied patches and rebuild kernel and world. After system reboot problem still persist: PS/2 mouse work fine USB mouse work fine Bluetooth mouse doesn't'work - see attached video (can be view with mplayer) P.S. with my patch bt mouse work fine Thanks a lot! Which daemon is driving the BT mouse? --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
On Fri, May 07, 2010 at 12:14:14PM +0200, Hans Petter Selasky wrote: On Friday 07 May 2010 12:13:15 Alex Deiter wrote: Hi, Thanks a lot for your reply! I`m applied patches and rebuild kernel and world. After system reboot problem still persist: PS/2 mouse work fine USB mouse work fine Bluetooth mouse doesn't'work - see attached video (can be view with mplayer) P.S. with my patch bt mouse work fine Thanks a lot! Which daemon is driving the BT mouse? It is the bthidd(8) daemon. I've proposed a patch here: http://lists.freebsd.org/pipermail/freebsd-usb/2010-May/008675.html But I can not test it since I don't have any bluetooth mouse or keyboard. Kai ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
The following reply was made to PR usb/146367; it has been noted by GNATS. From: Kai Wang kaiwan...@gmail.com To: Hans Petter Selasky hsela...@c2i.net Cc: Alex Deiter alex.dei...@gmail.com, freebsd-gnats-sub...@freebsd.org, freebsd-usb@freebsd.org Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support Date: Fri, 7 May 2010 12:21:46 +0200 On Fri, May 07, 2010 at 12:14:14PM +0200, Hans Petter Selasky wrote: On Friday 07 May 2010 12:13:15 Alex Deiter wrote: Hi, Thanks a lot for your reply! I`m applied patches and rebuild kernel and world. After system reboot problem still persist: PS/2 mouse work fine USB mouse work fine Bluetooth mouse doesn't'work - see attached video (can be view with mplayer) P.S. with my patch bt mouse work fine Thanks a lot! Which daemon is driving the BT mouse? It is the bthidd(8) daemon. I've proposed a patch here: http://lists.freebsd.org/pipermail/freebsd-usb/2010-May/008675.html But I can not test it since I don't have any bluetooth mouse or keyboard. Kai ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
Hi Hans, I`m apply patch for bthidd from Kal and my bt mouse work fine again! Which daemon is driving the BT mouse? bthidd patch from Kal for bthidd(8) works fine only WITH your patches for: lib/libusbhid/data.c sys/dev/usb/usb_hid.c sys/dev/usb/usbhid.h Thanks a lot! 2010/5/7 Hans Petter Selasky hsela...@c2i.net: On Friday 07 May 2010 12:13:15 Alex Deiter wrote: Hi, Thanks a lot for your reply! I`m applied patches and rebuild kernel and world. After system reboot problem still persist: PS/2 mouse work fine USB mouse work fine Bluetooth mouse doesn't'work - see attached video (can be view with mplayer) P.S. with my patch bt mouse work fine Thanks a lot! Which daemon is driving the BT mouse? --HPS -- -- Alex Deiter ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support
Number: 146367 Category: usb Synopsis: [PATCH] Revision 205728: broken bluetooth mouse support Confidential: no Severity: serious Priority: medium Responsible:freebsd-usb State: open Quarter: Keywords: Date-Required: Class: sw-bug Submitter-Id: current-users Arrival-Date: Fri May 07 03:50:01 UTC 2010 Closed-Date: Last-Modified: Originator: Alex Deiter Release:9.0 Organization: N/A Environment: today 9.0-current (Revision 207680) Description: Hi, Bluetooth mouse support is broken after Revision 205728: http://svn.freebsd.org/viewvc/base?view=revisionrevision=205728 When I move the mouse - cursor stays in same place but moves the current position of the console. Proposed patch as an attachment. Could you please revew this ? Thanks a lot! How-To-Repeat: Fix: please review patch Patch attached with submission follows: --- lib/libusbhid/data.c.orig 2010-05-07 01:26:45.192120194 +0400 +++ lib/libusbhid/data.c2010-05-07 01:55:56.114702254 +0400 @@ -40,15 +40,10 @@ const uint8_t *buf; uint32_t hpos; uint32_t hsize; - uint32_t data; + int32_t data; int i, end, offs; buf = p; - - /* Skip report ID byte. */ - if (h-report_ID 0) - buf++; - hpos = h-pos; /* bit position of data */ hsize = h-report_size; /* bit length of data */ Release-Note: Audit-Trail: Unformatted: ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org