Re: XFCE upgraded to 4.16
On 09/01/21 22:29, Andrea Venturoli wrote:
On 1/9/21 11:59 AM, Andrea Venturoli wrote:
Right now I reached an usable config on my desktop, but I will try and
get suck a backtrace and I'll come back if I succeed.
Here it is:
(gdb) bt
#0 0x000800e95287 in g_filename_from_uri () at
/usr/local/lib/libglib-2.0.so.0
#1 0x002103a7 in install_theme (widget=0x80361c3f0,
uris=0x80463bf98, builder=0x802d504e0) at main.c:881
#2 0x0020f949 in appearance_settings_install_theme_cb
(widget=0x803631180, builder=0x802d504e0) at main.c:1000
#3 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#4 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#5 0x000800dc8ee6 in g_signal_emit () at
/usr/local/lib/libgobject-2.0.so.0
#6 0x0008008ab72e in () at /usr/local/lib/libgtk-3.so.0
#7 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#8 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#9 0x000800dc8ee6 in g_signal_emit () at
/usr/local/lib/libgobject-2.0.so.0
#10 0x0008008abd36 in () at /usr/local/lib/libgtk-3.so.0
#11 0x000800b8dc18 in () at /usr/local/lib/libgtk-3.so.0
#12 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#13 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#14 0x000800dc8ee6 in g_signal_emit () at
/usr/local/lib/libgobject-2.0.so.0
#15 0x0008009817f1 in () at /usr/local/lib/libgtk-3.so.0
#16 0x000800db588c in g_cclosure_marshal_VOID__BOXEDv () at
/usr/local/lib/libgobject-2.0.so.0
#17 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#18 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#19 0x000800dc8ee6 in g_signal_emit () at
/usr/local/lib/libgobject-2.0.so.0
#20 0x00080097f69e in () at /usr/local/lib/libgtk-3.so.0
#21 0x000800983395 in () at /usr/local/lib/libgtk-3.so.0
#22 0x00080094341c in gtk_event_controller_handle_event () at
/usr/local/lib/libgtk-3.so.0
#23 0x000800b35d9c in () at /usr/local/lib/libgtk-3.so.0
#24 0x000800b882c1 in () at /usr/local/lib/libgtk-3.so.0
#25 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#26 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#27 0x000800dc8ee6 in g_signal_emit () at
/usr/local/lib/libgobject-2.0.so.0
#28 0x000800b35ad9 in () at /usr/local/lib/libgtk-3.so.0
#29 0x0008009d1c5f in gtk_propagate_event () at
/usr/local/lib/libgtk-3.so.0
#30 0x0008009d17ef in gtk_main_do_event () at
/usr/local/lib/libgtk-3.so.0
#31 0x0008002e43a1 in () at /usr/local/lib/libgdk-3.so.0
#32 0x000800319877 in () at /usr/local/lib/libgdk-3.so.0
#33 0x000800eb9a7e in g_main_context_dispatch () at
/usr/local/lib/libglib-2.0.so.0
#34 0x000800eb9e24 in () at /usr/local/lib/libglib-2.0.so.0
#35 0x000800eba17a in g_main_loop_run () at
/usr/local/lib/libglib-2.0.so.0
#36 0x0008009d111b in gtk_main () at /usr/local/lib/libgtk-3.so.0
#37 0x0020cb2d in main (argc=1, argv=0x7fffe660) at
main.c:1307
In frame #1 (install_theme) we have:
static void
install_theme (GtkWidget *widget, gchar **uris, GtkBuilder *builder)
{
...
for (i = 0; uris[i] != NULL; i++)
{
...
However in the caller (at frame #2, i.e.
appearance_settings_install_theme_cb):
gchar **uris;
GtkFileChooser *chooser = GTK_FILE_CHOOSER (dialog);
uris = g_new0 (gchar *, 1);
filename = gtk_file_chooser_get_filename (chooser);
uris[0] = g_filename_to_uri (filename, NULL, NULL);
install_theme (window, uris, builder);
So what I think happens is that the loop processes uri[0], which holds
the filename, but fails to find a NULL after it, since it was never
allocated.
Guess it should read:
uris = g_new0 (gchar *, 2);
Of course this should be fixed upstream, but in the meantime I'm
attaching a patch that solves for me.
I need to take a better look to be sure, but yes, your patch looks
correct at first sight.
I'm going to test it and also submit upstream (with attribution, obviously!)
--
Guido Falsi
___
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 1/9/21 10:29 PM, Andrea Venturoli wrote: Of course this should be fixed upstream, but in the meantime I'm attaching a patch that solves for me. Sorry. The patch was removed by the list. Here it is as plain text: files/patch-dialogs_appearance_settings_main.c: --- dialogs/appearance-settings/main.c.orig 2021-01-09 18:02:18 UTC +++ dialogs/appearance-settings/main.c @@ -994,7 +994,7 @@ appearance_settings_install_theme_cb (GtkButton *widge gchar **uris; GtkFileChooser *chooser = GTK_FILE_CHOOSER (dialog); -uris = g_new0 (gchar *, 1); +uris = g_new0 (gchar *, 2); filename = gtk_file_chooser_get_filename (chooser); uris[0] = g_filename_to_uri (filename, NULL, NULL); install_theme (window, uris, builder); ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 1/9/21 11:59 AM, Andrea Venturoli wrote:
Right now I reached an usable config on my desktop, but I will try and
get suck a backtrace and I'll come back if I succeed.
Here it is:
(gdb) bt
#0 0x000800e95287 in g_filename_from_uri () at
/usr/local/lib/libglib-2.0.so.0
#1 0x002103a7 in install_theme (widget=0x80361c3f0, uris=0x80463bf98,
builder=0x802d504e0) at main.c:881
#2 0x0020f949 in appearance_settings_install_theme_cb
(widget=0x803631180, builder=0x802d504e0) at main.c:1000
#3 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#4 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#5 0x000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0
#6 0x0008008ab72e in () at /usr/local/lib/libgtk-3.so.0
#7 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#8 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#9 0x000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0
#10 0x0008008abd36 in () at /usr/local/lib/libgtk-3.so.0
#11 0x000800b8dc18 in () at /usr/local/lib/libgtk-3.so.0
#12 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#13 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#14 0x000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0
#15 0x0008009817f1 in () at /usr/local/lib/libgtk-3.so.0
#16 0x000800db588c in g_cclosure_marshal_VOID__BOXEDv () at
/usr/local/lib/libgobject-2.0.so.0
#17 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#18 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#19 0x000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0
#20 0x00080097f69e in () at /usr/local/lib/libgtk-3.so.0
#21 0x000800983395 in () at /usr/local/lib/libgtk-3.so.0
#22 0x00080094341c in gtk_event_controller_handle_event () at
/usr/local/lib/libgtk-3.so.0
#23 0x000800b35d9c in () at /usr/local/lib/libgtk-3.so.0
#24 0x000800b882c1 in () at /usr/local/lib/libgtk-3.so.0
#25 0x000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0
#26 0x000800dc8488 in g_signal_emit_valist () at
/usr/local/lib/libgobject-2.0.so.0
#27 0x000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0
#28 0x000800b35ad9 in () at /usr/local/lib/libgtk-3.so.0
#29 0x0008009d1c5f in gtk_propagate_event () at /usr/local/lib/libgtk-3.so.0
#30 0x0008009d17ef in gtk_main_do_event () at /usr/local/lib/libgtk-3.so.0
#31 0x0008002e43a1 in () at /usr/local/lib/libgdk-3.so.0
#32 0x000800319877 in () at /usr/local/lib/libgdk-3.so.0
#33 0x000800eb9a7e in g_main_context_dispatch () at
/usr/local/lib/libglib-2.0.so.0
#34 0x000800eb9e24 in () at /usr/local/lib/libglib-2.0.so.0
#35 0x000800eba17a in g_main_loop_run () at /usr/local/lib/libglib-2.0.so.0
#36 0x0008009d111b in gtk_main () at /usr/local/lib/libgtk-3.so.0
#37 0x0020cb2d in main (argc=1, argv=0x7fffe660) at main.c:1307
In frame #1 (install_theme) we have:
static void
install_theme (GtkWidget *widget, gchar **uris, GtkBuilder *builder)
{
...
for (i = 0; uris[i] != NULL; i++)
{
...
However in the caller (at frame #2, i.e.
appearance_settings_install_theme_cb):
gchar **uris;
GtkFileChooser *chooser = GTK_FILE_CHOOSER (dialog);
uris = g_new0 (gchar *, 1);
filename = gtk_file_chooser_get_filename (chooser);
uris[0] = g_filename_to_uri (filename, NULL, NULL);
install_theme (window, uris, builder);
So what I think happens is that the loop processes uri[0], which holds
the filename, but fails to find a NULL after it, since it was never
allocated.
Guess it should read:
uris = g_new0 (gchar *, 2);
Of course this should be fixed upstream, but in the meantime I'm
attaching a patch that solves for me.
bye
av.
___
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 09/01/21 11:59, Andrea Venturoli wrote: On 1/8/21 8:33 PM, Guido Falsi wrote: So, in the end, I think the messages about chflags were just warnings and could be ignored; the problem lies elsewhere. I agree. There is no way then to diagnose this any further without a backtrace. Right now I reached an usable config on my desktop, but I will try and get suck a backtrace and I'll come back if I succeed. I can try that, since I am almost sure the bug you hit is easily reproducible. But to do that I need some time to rebuild ports with debug symbols enabled and setup a VM. -- Guido Falsi ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 09/01/21 12:14, Guido Falsi wrote: On 09/01/21 12:09, Andrea Venturoli wrote: On 1/8/21 8:42 PM, Guido Falsi wrote: ANyway, thinking about it, if the chflag errors are just warnings like you say above, then setting a custom TMPDIR will not be needed even with your setup. So there is no need for a warning anyway. Guido, you are losing sight with the heart of the problem, i.e. without TMPDIR, xfce4-appearance-settings tries to create a temporary directory in / (and obviously fails). This has nothing to do with where home is or what filesystem it's using. I've proposed a patch upstream to fix this where it should be fixed. Depending on the existence of a variable and not having a sensible default is an upstream bug. Ref: https://gitlab.xfce.org/xfce/xfce4-settings/-/merge_requests/41 Forgot to mention, I plan to integrate this patch in the ports tree, but I need to better test it before doing that. -- Guido Falsi ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 09/01/21 12:09, Andrea Venturoli wrote: On 1/8/21 8:42 PM, Guido Falsi wrote: I don't agree. Using a network file system for home directory if problematic at present. Most software uses sqlite databases for configurations which explicitly does not support networked file systems. and other problems could arise. >> >> Such a note should be attached to most software in the ports tree. >> Firefox and thunderbird (and most other browsers AFAIK) just to name >> two which use sqlite DBs heavily. (This is going OT, but Sqlite, in their FAQ, only suggest against *multiple processes* accessing the same database over NFS. ThunderBird works perfectly in such a setup as it's only one user/program accessing the database.) Thunderbird will work fine until it will have problems. Anyway you are obviouslt free to run your system any way you'd like to. ANyway, thinking about it, if the chflag errors are just warnings like you say above, then setting a custom TMPDIR will not be needed even with your setup. So there is no need for a warning anyway. Guido, you are losing sight with the heart of the problem, i.e. without TMPDIR, xfce4-appearance-settings tries to create a temporary directory in / (and obviously fails). This has nothing to do with where home is or what filesystem it's using. I've proposed a patch upstream to fix this where it should be fixed. Depending on the existence of a variable and not having a sensible default is an upstream bug. Ref: https://gitlab.xfce.org/xfce/xfce4-settings/-/merge_requests/41 IMVVHO, if TMPDIR is something a FreeBSD will most probably NOT have, then it should be changed into something else. Or at least the user should know it must be set. I made a mistake saying that it would have to be set. I said that because I thought that /tmp (a sensible fallback default and what I propose upstream) would not have been a working one on your setup, but that's not the case. So patching upstream to fallback on /tmp is more reasonable. bye av. -- Guido Falsi ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 1/8/21 8:42 PM, Guido Falsi wrote: I don't agree. Using a network file system for home directory if problematic at present. Most software uses sqlite databases for configurations which explicitly does not support networked file systems. and other problems could arise. >> >> Such a note should be attached to most software in the ports tree. >> Firefox and thunderbird (and most other browsers AFAIK) just to name >> two which use sqlite DBs heavily. (This is going OT, but Sqlite, in their FAQ, only suggest against *multiple processes* accessing the same database over NFS. ThunderBird works perfectly in such a setup as it's only one user/program accessing the database.) ANyway, thinking about it, if the chflag errors are just warnings like you say above, then setting a custom TMPDIR will not be needed even with your setup. So there is no need for a warning anyway. Guido, you are losing sight with the heart of the problem, i.e. without TMPDIR, xfce4-appearance-settings tries to create a temporary directory in / (and obviously fails). This has nothing to do with where home is or what filesystem it's using. IMVVHO, if TMPDIR is something a FreeBSD will most probably NOT have, then it should be changed into something else. Or at least the user should know it must be set. bye av. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
Re: XFCE upgraded to 4.16
On 1/8/21 8:33 PM, Guido Falsi wrote: So, in the end, I think the messages about chflags were just warnings and could be ignored; the problem lies elsewhere. I agree. There is no way then to diagnose this any further without a backtrace. Right now I reached an usable config on my desktop, but I will try and get suck a backtrace and I'll come back if I succeed. bye & Thanks av. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
FreeBSD ports you maintain which are out of date
Dear port maintainer, The portscout new distfile checker has detected that one or more of your ports appears to be out of date. Please take the opportunity to check each of the ports listed below, and if possible and appropriate, submit/commit an update. If any ports have already been updated, you can safely ignore the entry. You will not be e-mailed again for any of the port/version combinations below. Full details can be found at the following URL: http://portscout.freebsd.org/x...@freebsd.org.html Port| Current version | New version +-+ sysutils/catfish| 4.15.0 | 4.16.0 +-+ If any of the above results are invalid, please check the following page for details on how to improve portscout's detection and selection of distfiles on a per-port basis: http://portscout.freebsd.org/info/portscout-portconfig.txt Reported by:portscout! ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
