[Freeciv-Dev] (PR#39332) lt.po is broken! (S2_1)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39332 Good daytime! branches/S2_1 Revision: 12914 `make dist` failed due to: lt.po:9412: number of format specifications in 'msgid' and 'msgstr' does not match Therefore snapshot building does not work... So I ask Andrius Stikonas to fix lt.po as soon as possible. PS. All po files are regenerated during `make dist` so line number may differ. Problem lines: #. TRANS: Republic of the Polish #: client/text.c:1095 #, c-format msgid %s of the %s msgstr .; PPS. `msgfmt -c lt.po` shows all problems. -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39332) lt.po is broken! (S2_1)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39332 On 4/10/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39332 Good daytime! branches/S2_1 Revision: 12914 `make dist` failed due to: lt.po:9412: number of format specifications in 'msgid' and 'msgstr' does not match Therefore snapshot building does not work... So I ask Andrius Stikonas to fix lt.po as soon as possible. PS. All po files are regenerated during `make dist` so line number may differ. Problem lines: #. TRANS: Republic of the Polish #: client/text.c:1095 #, c-format msgid %s of the %s msgstr .; PPS. `msgfmt -c lt.po` shows all problems. I don't have development access right now but when I see errors/warnings like this I usually just mark the string as fuzzy and move on. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fix for PR#39330
Hi,
Attached to this message is a patch to fix the issue reported in
PR#39330. Basically, the problem seems to be that cities can see unknown
terrain, and this is considered acceptable and normal. But, in at least
one place in the code that possibility is overlooked. In a player's view
of a tile, the terrain ptr may be NULL (indicating it is unknown).
Attempts to reference a member, such as 'type', of such a NULL ptr
obviously results in a segfault.
Eric
Index: server/maphand.c
===
--- server/maphand.c(revision 12911)
+++ server/maphand.c(working copy)
@@ -476,9 +476,9 @@
struct player_tile *plrtile = map_get_player_tile(ptile, pplayer);
info.known = TILE_KNOWN_FOGGED;
- info.type = plrtile-terrain-index;
+ info.type = plrtile-terrain ? plrtile-terrain-index : -1;
for (spe = 0; spe S_LAST; spe++) {
- info.special[spe] = BV_ISSET(plrtile-special, spe);
+info.special[spe] = BV_ISSET(plrtile-special, spe);
}
info.resource = plrtile-resource ? plrtile-resource-index : -1;
info.continent = ptile-continent;
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39333) 2.0.9 White Bar Appears After Crash
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39333 Hi! We continued our main game today. At one point of the game the game suddenly froze for Kimmo (2.0.9, gtk2-client, Windows). When he restarted the client, everything seemed to work normally. However, when the next turn changed, a strange white bar appeared in the center of the view and stuck there. It remained there until the turn changed when the City Dialog was open. You can see a screenshot illustrating the issue here: http://130.233.28.150/freeciv/white_bar.jpg (323 KB). Lauri Uotinen (relaying the bug report by Kimmo Tanskanen) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39335) Re: Fix for PR#39330
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39335 On 4/10/07, Eric McDonald [EMAIL PROTECTED] wrote: Hi, Attached to this message is a patch to fix the issue reported in PR#39330. Basically, the problem seems to be that cities can see unknown terrain, and this is considered acceptable and normal. But, in at least one place in the code that possibility is overlooked. In a player's view of a tile, the terrain ptr may be NULL (indicating it is unknown). Attempts to reference a member, such as 'type', of such a NULL ptr obviously results in a segfault. Good catch but the bug is deeper. We do NEED to know the terrain type here since the tile is being sent as TILE_KNOWN_FOGGED. Can you find a way to reproduce the problem and figure out why a known tile has unknown terrain type? That should not be possible. P.S. Send future reports to the bug tracker. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
