Re: [Freeciv-Dev] (PR#39530) Wonders don't allow units
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39530 On Thu, 23 Aug 2007 Marko Lindqvist wrote: Actual problem is that unit improvement requirement has no ruleset defined range. Building is always required in City range. This is what we usually want for normal buildings, and for some wonders. Just changing hardcoded range to be Player for wonders would replace bug with another. Do we want *all* the wonders to provide unit building abilities in all cities? No, please. Several wonders may affect all the nation (or even world), several may affect only one city. Why this should differ for units? -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39608) Surrender command
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39608
When the surrender command failed, it's written:
/endgame: You cannot surrender now.
It should be:
/surrender: You cannot surrender now.
--- server/stdinhand.c.old 2007-08-24 11:40:04.0 +0200
+++ server/stdinhand.c 2007-08-24 11:40:44.0 +0200
@@ -3666,7 +3666,7 @@
caller-player-surrendered = TRUE;
return TRUE;
} else {
-cmd_reply(CMD_END_GAME, caller, C_FAIL, _(You cannot surrender
now.));
+cmd_reply(CMD_SURRENDER, caller, C_FAIL, _(You cannot surrender
now.));
return FALSE;
}
}
--- server/stdinhand.c.old 2007-08-24 11:40:04.0 +0200
+++ server/stdinhand.c 2007-08-24 11:40:44.0 +0200
@@ -3666,7 +3666,7 @@
caller-player-surrendered = TRUE;
return TRUE;
} else {
-cmd_reply(CMD_END_GAME, caller, C_FAIL, _(You cannot surrender now.));
+cmd_reply(CMD_SURRENDER, caller, C_FAIL, _(You cannot surrender now.));
return FALSE;
}
}
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39609) BUG: Escape from goto/connect/etc clears update_unit_info_label()
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39609 As I was testing several related bugs (PR#29982, PR#39339, PR#39430): goto_get_turns: Assertion unit_is_in_focus(punit) failed I found that hitting escape caused the list of focused units to disappear. Clicking anywhere on the map restores the list. The simple explanation, in client/control.c key_cancel_action(), set_hover_state(NULL, HOVER_NONE, ACTIVITY_LAST, ORDER_LAST); update_unit_info_label(hover_units); set_hover_state() has just set hover_units to NULL. This should actually be get_units_in_focus(), as they are still in focus. === Further checking shows that this is one of only two places that hover_units is actually used. In fact, every other call to update_unit_info_label() is passing get_units_in_focus() or the equivalent pfocus_units. This is the only exception -- and it's wrong! (Ignoring the problem that gui-mui still only handles a single unit.) Obviously, the assert() requires all goto units are in pfocus_units. There's no explanation for why hover_units exist. It is always either NULL or identical to pfocus_units. There's no code that changes hover_units to ever make it any different from pfocus_units. Does anybody remember? Otherwise, I'm getting rid of it. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39611) BETA6 cannot find libggz
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39611 configure doesn't look for ggzlib in the standard path: On plain Debian Etch: ./configure --enable-client=no --with-ggz-server checking for GGZ library: libggz... no configure: error: Could not configure GGZ server support. See above messages. configure:16019: checking for GGZ library: libggz configure: 16080: /usr/local/include/ggz.h tried /usr/local/lib configure:16136: result: no configure:16463: error: Could not configure GGZ server support. See above messages. $ locate ggz-config /usr/bin/ggz-config /usr/share/locale/de/LC_MESSAGES/ggz-config.mo /usr/share/man/man6/ggz-config.6.gz ./configure --enable-client=no --with-ggz-server --with-ggzconfig=/usr/bin/ggz-config doesn't solve it: checking for GGZ library: libggz... no configure: error: Could not configure GGZ server support. See above messages. configure:16019: checking for GGZ library: libggz configure: 16080: /usr/local/include/ggz.h tried /usr/local/lib configure:16136: result: no configure:16463: error: Could not configure GGZ server support. See above messages. -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
