[Freeciv-Dev] gui-sdl and S2_1

2007-09-10 Thread Christian Prochaska
Since there has been some discussion about the stability of
translatable strings in the stable branch recently, I'd like to know
what's your opinion about updates of the SDL client in S2_1.
Personally, I'd like to keep the S2_1/2.1.x version in sync with the
trunk version as long as possible (or at least until 2.2 gets
released), since it's still missing basic features, has several
usability problems and it's unclear how well I'll be able to catch up
with future changes in trunk that might require bigger changes to the
GUI. It's also unclear if a 2.2 version will still compile and run on
a Pocket PC, which might not be the case anymore if memory usage
increases too much or if new dependency libraries are added that don't
compile or work on this platform. So, you see there are several
reasons to continue work on the SDL client in S2_1, but this will
surely break translation every now and then. If you consider this to
be a big problem, a possible solution might be to fork the gui-sdl
directory in S2_1 and leave one "as is" (fully translated, but hardly
updated) and the other one untranslated, but with regular updates of
all kinds. What do you think?

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] gui-sdl and S2_1

2007-09-10 Thread Per I. Mathisen
On Mon, 10 Sep 2007, Christian Prochaska wrote:
> Since there has been some discussion about the stability of
> translatable strings in the stable branch recently, I'd like to know
> what's your opinion about updates of the SDL client in S2_1.
> Personally, I'd like to keep the S2_1/2.1.x version in sync with the
> trunk version as long as possible (or at least until 2.2 gets
> released), since it's still missing basic features, has several
> usability problems and it's unclear how well I'll be able to catch up
> with future changes in trunk that might require bigger changes to the
> GUI. It's also unclear if a 2.2 version will still compile and run on
> a Pocket PC, which might not be the case anymore if memory usage
> increases too much or if new dependency libraries are added that don't
> compile or work on this platform. So, you see there are several
> reasons to continue work on the SDL client in S2_1, but this will
> surely break translation every now and then. If you consider this to
> be a big problem, a possible solution might be to fork the gui-sdl
> directory in S2_1 and leave one "as is" (fully translated, but hardly
> updated) and the other one untranslated, but with regular updates of
> all kinds. What do you think?

Once 2.1.0 is released, the string freeze in S2_1 will thaw, and you can 
do bigger changes to the gui-sdl code than you should do now, at risk of 
delaying 2.1.0 even further. IMHO.

   - Per

Carpe noctem

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] gui-sdl and S2_1

2007-09-10 Thread Daniel Markstedt
On 9/10/07, Christian Prochaska <[EMAIL PROTECTED]> wrote:
> Since there has been some discussion about the stability of
> translatable strings in the stable branch recently, I'd like to know
> what's your opinion about updates of the SDL client in S2_1.
> Personally, I'd like to keep the S2_1/2.1.x version in sync with the
> trunk version as long as possible (or at least until 2.2 gets
> released), since it's still missing basic features, has several
> usability problems and it's unclear how well I'll be able to catch up
> with future changes in trunk that might require bigger changes to the
> GUI. It's also unclear if a 2.2 version will still compile and run on
> a Pocket PC, which might not be the case anymore if memory usage
> increases too much or if new dependency libraries are added that don't
> compile or work on this platform. So, you see there are several
> reasons to continue work on the SDL client in S2_1, but this will
> surely break translation every now and then. If you consider this to
> be a big problem, a possible solution might be to fork the gui-sdl
> directory in S2_1 and leave one "as is" (fully translated, but hardly
> updated) and the other one untranslated, but with regular updates of
> all kinds. What do you think?
>

My general comment is that gui-sdl may be partially exempted from the
don't-touch-the-strings rule, simply because it still is pretty much
in alpha stage and incomplete. Of the guis only gui-gtk2 should be
treated with care IMO, as it is Freeciv's 'public face.'

Most translations of gui-sdl are terribly incomplete anyways (it was
localized very late)...

 ~Daniel

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-10 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=39693 >

Daniel Markstedt wrote:
> It's IMHO ok to add new translatable strings while implementing new
> functionality. What should be avoided is making minor adjustments to
> existing ones.
> 
Wasn't new functionality, was a 2.1 bug fix.  But OK, I'll change later
today.  I didn't want to delay 2.1.0.

OTOH, all those English grammar mistakes in the new unit help are going to
require translation fixes anyway



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39642) en_US.po

2007-09-10 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=39642 >

I strongly disagree with the creation of en_US.po

Strings that exist, and need trivial fixing for grammar (not content),
should be updated in both the code source and *all* the translation *.po
keys.  It's easy to do, and there's no effort needed by translators

That's how I've been handling it already.  Surely, we all have sed, or
its GUI equivalent?!?!

Strings that change in content and semantics have to be vetted by
translators anyway, having en_US.po doesn't help!



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#15854) goto.c:860: Assertion `unit_is_in_focus(punit)' failed

2007-09-10 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=15854 >

Marko Lindqvist wrote:

>  Ok, it *is* possible to add focus units when goto is active. Replaced
> assert() with hover cancel. This is all that S2_1 needs. For trunk we
> may consider adding new goto_map for additional units in focus (if
> they are allowed to ignore already set waypoints, this should not be
> hard)
> 
This is the wrong solution.

What is needed instead is a queue of future focus units, and the server
wakeup merely adds to the head of the queue.  (I think there's something
like that already.)  If the client user is already doing something, the
server shouldn't interrupt the UI.

Besides, the current design wouldn't work when there were lots of players.
Sentries will wake up all over the map, and the focus constantly bounce.

If six units wake, they should just add to the queue

(And the answer to the earlier question is, I've never played with more
than 2 humans.  I value your testing with many players!)



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39642) en_US.po

2007-09-10 Thread Egor Vyscrebentsov

http://bugs.freeciv.org/Ticket/Display.html?id=39642 >

On Mon, 10 Sep 2007 06:01:34 -0700 William Allen Simpson wrote:

> I strongly disagree with the creation of en_US.po
>
> Strings that exist, and need trivial fixing for grammar (not content),
> should be updated in both the code source and *all* the translation *.po
> keys.

I'm agree that en_US.po is not a silver bullet. But I think neither you
nor me nor somebody else can't fix all translation changes. Simple
fix in english may become very untrivial task in other language.
('%2s %1s' for [quite easy] example)

> It's easy to do, and there's no effort needed by translators
>
> That's how I've been handling it already.  Surely, we all have sed, or
> its GUI equivalent?!?!

Erm, is it right that "it's easy"? I'm sure that I *never* placed 'msgid'
twice in one line. But once I've fixed that. See also Marko's fixes
of fuzzies. And sed never was a translation tool! Marking string
as fuzzy is more fair thing that to change it manually (or automatically
not by 'make update-po' [*]) without giving translator a notice.

[*] And update-po changes only msgids, marking string as fuzzy.

But this is not about en_US.po.

> Strings that change in content and semantics have to be vetted by
> translators anyway, having en_US.po doesn't help!

Agree.
But you may look to my second answer in this ticket.
And you may find sentences in archive of the list that english is
not the ideal language for freeciv, but we have no better.

-- 
Thanks, evyscr



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39690) Remove embassy concept

2007-09-10 Thread Per I. Mathisen

http://bugs.freeciv.org/Ticket/Display.html?id=39690 >

On Sat, 8 Sep 2007, Per I. Mathisen wrote:
> This experimental and mostly untested patch removes the embassy concept
> from the game.

I am surprised by the lack of comments on this ticket. If subsequent 
testing does not reveal any problems, and none objects within 24 hours, I 
will commit it.

   - Per



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39686) [Bug] Unit pointer used after move_unit()

2007-09-10 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=39686 >

On 08/09/2007, Marko Lindqvist  wrote:
>
>  move_unit()

 ...

>  Now some
> callers are ready to segfault when ever moving unit dies due to
> autoattack or by entering barbarian hut (or some other reason?).

 If nothing comes up in further testing, I commit fixes to all
branches later this week (when time permits).


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39652) Fwd: Patch for SkyOS compilation

2007-09-10 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=39652 >

On 09/09/2007, Marko Lindqvist  wrote:
> On 03/09/07, Marko Lindqvist wrote:
> >
> >  Well, I have no environment to *test*, but I wrote patch anyway. This
> > updates also mingw32 handling to present autoconf standards
> > (AC_CANONICAL_HOST has been recommended since autoconf-2.13)
>
>  Noticed that configure.ac already had AC_CANONICAL_TARGET. Replaced
> that with AC_CANONICAL_HOST as Freeciv is not cross-compiler (autoconf
> naming of build/host/target is sometimes confusing).

 I can't test all the environments this patch affects, but can't help
that. I consider this ready for commit.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39676) [Patch] Script to help auth server setup

2007-09-10 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=39676 >

On 09/09/2007, Marko Lindqvist  wrote:
>
> On 06/09/07, Marko Lindqvist  wrote:
> >
> >  This should make it much easier to setup authentication enabled
> > server (if you have auth enabled freeciv binaries)
>
>  This adds it to distribution, but not to installation.

 Script could use some improvements, but leaving that to some future
ticket. Both script and distribution patch ready for commit.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39678) [Patch] Requirement list sanity checking

2007-09-10 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=39678 >

On 09/09/2007, Marko Lindqvist  wrote:
>
> On 07/09/07, Marko Lindqvist wrote:
> >
> >  This adds checking of requirement list sanity to ruleset load.
>
>  This handles requirement lists for effects only. Other requirements
> are in requirement vectors (not in lists).

 Leaving further improvements to other tickets (implementation is by
current standards, not by what #39643 will require). I consider this
ready for commit.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39653) S2_1 needs wait cursor gfx

2007-09-10 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=39653 >

On 10/09/2007, Marko Lindqvist  wrote:
>
>  Here is spec change. Updated cursors.png attached to ticket.

 Nobody has commented to #17793 if wait cursors really should be
ported to S2_1. Both this and #17793 are ready, but I'll wait to
Thursday (and then until I have time) before committing either.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39698) 'classic' terrain for 2.1.99

2007-09-10 Thread Daniel Markstedt

http://bugs.freeciv.org/Ticket/Display.html?id=39698 >

I'm trying to make a 2.1-style ruleset+tileset to be able to create
2.1-compatible maps with the editor. Have run into a snag with the
tileset, though, as I haven't been able to understand the esoteric
differences in the two tileset formats (tilespec4 &
tilespec4.2007.Jul.13).

The latest error message (with attached files) I'm getting is:

1: Missing errno mapping for Winsock error #10093. Please report this
message at http://bugs.freeciv.org/.

(This is on Windows XP)

In earlier tries I got errors about missing 'ocean' or 'arctic' gfx.

 ~Daniel



classic_terrain.tar.gz
Description: GNU Zip compressed data
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev