[Freeciv-Dev] (PR#40101) S2_1: 'minplayers' typo
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40101 Good daytime! S2_1 contains two typos: mirules.nplayers used against minplayers. One is in commentary, other in line that is sent to metaserver... Typos don't affect game process. (But you can see them on metaserver.) Attached is patch for S2_1, should be applyable to S2_2 and trunk (both have same typos.) -- Thanks, evyscr Index: server/settings.c === --- server/settings.c (revision 14387) +++ server/settings.c (working copy) @@ -409,7 +409,7 @@ /* Options affecting numbers of players and AI players. These only * affect the start of the game and can not be adjusted after that. - * (Actually, mirules.nplayers does also affect reloads: you can't start a + * (Actually, minplayers does also affect reloads: you can't start a * reload game until enough players have connected (or are AI).) */ GEN_INT(minplayers, game.info.min_players, Index: server/meta.c === --- server/meta.c (revision 14387) +++ server/meta.c (working copy) @@ -359,7 +359,7 @@ s = end_of_strn(s, rest); my_snprintf(s, rest, vn[]=%svv[]=%d, -my_url_encode(mirules.nplayers), game.info.min_players); +my_url_encode(minplayers), game.info.min_players); s = end_of_strn(s, rest); my_snprintf(s, rest, vn[]=%svv[]=%d, ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40101) minplayers typo
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40101 I tried to figure out how that came into the code base, and wasn't successful. It's not in 2.0, and none of my searching found it. Ah well, I wish all our problems were so easy to solve Thanks! Committed trunk revision 14412. Committed S2_2 revision 14413. Committed S2_1 revision 14414. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40100) vestigial city_map removal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40100 Just noting in passing that there's Yet Another Copy of the city worker in citymap.c, this time as an -(pcity-id). What a mess! We have a citymap (whole world), city_map for each city, the world tiles, and player tiles With conversions from city_maps to CMA that I don't even want to think about at the moment. Also, the packet interface to the client sends this data per city, instead of per tile, so every tiny change sends a huge city packet. The code spends an inordinate amount of time circling outward from tiles looking for adjacent cities to update. Unfortunately, it's sufficiently embedded that ripping the entire thing out entirely is too hard. I'll have to break it down into steps. The first step will be trying to come up with a sensible naming scheme for functions, and combining many cases of nearly identical code into common functions. Maybe that will be enough to figure out how a city size is munged every few dozen turns! ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40102) testing
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40102 Please ignore this ticket. I'm trying to see if I'm able to open new tickets by email again (was broken for me last I tried)... ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] wikia spam filter whitelist addition
In case the people (or person) that is responsible for the wikia freeciv pages does not often check the main freeciv forums, I would like to request that freeciv\.freeforums\.org be added to the wikia spam whitelist at http://freeciv.wikia.com/wiki/MediaWiki:Spam-whitelist so that I can update the Warclient wikia page with a proper link to the warclient project forums (currently I am blocked from doing so by the spam filter, unless I add extraneous strings to the link url). Thanks. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
