Re: [Freeciv-Dev] (PR#40492) Main menu items not staying open unless left mouse button is held down (Vista 64bit)
http://bugs.freeciv.org/Ticket/Display.html?id=40492 > This was posted on the forums. Not sure if it helps or not but I figured it would be good to add it. I also found the menu problem, but found a workaround. It's caused by the minimap. If you undock the minimap and move it away from the menu's, they will stay open when clicked once. (undock the minimap by clicking on the bar next to it) Code-wise, my guess is that it's caused by the highly inefficient gtk drawing code. Cheers! Dennis On Sat, Sep 20, 2008 at 3:14 PM, Dennis d'Entremont < [EMAIL PROTECTED]> wrote: > > > On Sat, Sep 20, 2008 at 9:04 AM, Daniel Markstedt <[EMAIL PROTECTED]>wrote: > >> >> http://bugs.freeciv.org/Ticket/Display.html?id=40492 > >> >> > [EMAIL PROTECTED] - Wed Sep 17 18:55:06 2008]: >> > >> > I am running Windows Vista Ultimate and FreeCIV 2.1.6 GTK. When I click >> on >> > the main menu items (i.e File menu item) they will not remain open >> unless I >> > keep the left mouse button pressed down. >> > I even uninstalled the program and cleaned out all the files then >> > reinstalled to see if it was a problem with the installation but that >> did >> > not appear to help. I haven't tried on a 32bit Vista installation so it >> > could be a Vista specific problem rather than a 64/32 bit problem. >> > >> > >> >> Running the same Freeciv version on Vista Home Premium SP1 32bit, I cannot >> reproduce this. >> >> Have you tried other GTK apps on the same system? How about earlier >> versions of Freeciv? >> >> Best, >> ~Daniel > > > I am running other GTK apps (mainly Inkscape) and that one works fine. > Pidgin (GAIM) also works ok. I tried downloading version 2.1.99 and it > appears to be happening as well and on version 2.1.5 also. It starts off > that you can see the outline of the menu then it actually draws the entire > menu but a second or so later it disappears. > > I suspect it might be related to the 64bit version of Vista because I am > unable to reproduce it on my 32bit Vista laptop. Is there some kind of dump > our output that I can get and pass along to make it easier? > > -- > Dennis d'Entremont > IT Professional CNA, MCP, A+, ITIL > LinkedIn Profile - http://www.linkedin.com/in/dennisdentremont > http://www.techalpha.net - Tech Alpha Computer Forums > http://epcsolutions.ca - EasyPC Solutions > http://eComStation.ca - Your Canadian Source for eCS and OS/2 Software! > http://Haikuware.com - Software for Haiku > http://Haiku-OS.org - Haiku Operating System > -- Dennis d'Entremont IT Professional CNA, MCP, A+, ITIL LinkedIn Profile - http://www.linkedin.com/in/dennisdentremont http://www.techalpha.net - Tech Alpha Computer Forums http://epcsolutions.ca - EasyPC Solutions http://eComStation.ca - Your Canadian Source for eCS and OS/2 Software! http://Haikuware.com - Software for Haiku http://Haiku-OS.org - Haiku Operating System This was posted on the forums. Not sure if it helps or not but I figured it would be good to add it.I also found the menu problem, but found a workaround. It's caused by the minimap. If you undock the minimap and move it away from the menu's, they will stay open when clicked once. (undock the minimap by clicking on the bar next to it) Code-wise, my guess is that it's caused by the highly inefficient gtk drawing code.Cheers!DennisOn Sat, Sep 20, 2008 at 3:14 PM, Dennis d'Entremont <[EMAIL PROTECTED]> wrote: On Sat, Sep 20, 2008 at 9:04 AM, Daniel Markstedt <[EMAIL PROTECTED]> wrote: http://bugs.freeciv.org/Ticket/Display.html?id=40492 > > [[EMAIL PROTECTED] - Wed Sep 17 18:55:06 2008]: > > I am running Windows Vista Ultimate and FreeCIV 2.1.6 GTK. When I click on > the main menu items (i.e File menu item) they will not remain open unless I > keep the left mouse button pressed down. > I even uninstalled the program and cleaned out all the files then > reinstalled to see if it was a problem with the installation but that did > not appear to help. I haven't tried on a 32bit Vista installation so it > could be a Vista specific problem rather than a 64/32 bit problem. > > Running the same Freeciv version on Vista Home Premium SP1 32bit, I cannot reproduce this. Have you tried other GTK apps on the same system? How about earlier versions of Freeciv? Best, ~DanielI am running other GTK apps (mainly Inkscape) and that one works fine. Pidgin (GAIM) also works ok. I tried downloading version 2.1.99 and it appears to be happening as well and on version 2.1.5 also. It starts off that you can see the outline of the menu then it actually draws the entire menu but a second or so later it disappears. I suspect it might be related to the 64bit version of Vista because I am unable to reproduce it on my 32bit Vista laptop. Is there some kind of dump our output that I can get and pass along to make it easier? -- Dennis d'EntremontIT Professional CNA, MCP, A+, ITILLinkedIn Profile - http://www.linkedin.com/in/dennisdentremont http://www.techalpha.net - Tech Alpha Computer Forums http://epcsol
[Freeciv-Dev] (PR#40463) Registration
http://bugs.freeciv.org/Ticket/Display.html?id=40463 > > [EMAIL PROTECTED] - Wed Aug 27 09:40:39 2008]: > > Hello! > > How can I register at bugs.freeciv.org? Registration on > freeciv.wikia.com doesn't works. Registering in wikia will only allow you to edit articles under the name that you registered. There is no registration for the bug tracker. If you send in good bug reports and patches (via email to the address shown in the image in the top left of the bug tracker main page), and express a desire to to contribute further, then one of the admins will provide you with a login. --- 頭の中で誰かがピアノを引いているんだ！ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40450) Entertainers, Scientists, and Taxmen in city Settings
http://bugs.freeciv.org/Ticket/Display.html?id=40450 > > [EMAIL PROTECTED] - Tue Aug 19 15:03:19 2008]: > > It seems the Scientists and Taxmen do not place workmen on any city > tiles when a city grows to the next size (size 1 to 2...); whereas if > Entertainer is set, it seems to put a worker on a city tile. > I would think it should be the other way around? There should really be 4 settings: new citizens become workers (i.e. work a tile), entertainers, scientists or taxmen. I have verified that in the current version the "entertainers" setting behaves like the first one (set to work a tile), with no way to have new citizens become entertainers. It should not be too hard to implement this last setting, but given that this specialist setting feature is not really used that often and largely superseded by the cma this is not a pressing problem. -- 冬以外、森の中で遊びます。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40445) Compile error with --enable-debug=yes (freeciv 2.1.6)
http://bugs.freeciv.org/Ticket/Display.html?id=40445 >
Thanks for the bug report, I have verified the compile
warning and converted your written solution to a small
patch that I will commit soon.
---
ガソリンを持ってきた。今夜は燃えようぜ！
diff --git a/server/sernet.c b/server/sernet.c
index e742f1a..1e933a7 100644
--- a/server/sernet.c
+++ b/server/sernet.c
@@ -711,7 +711,8 @@ enum server_events server_sniff_all_input(void)
if (didget >= 1) {
buffer[didget-1] = '\0'; /* overwrite newline character */
didget--;
-freelog(LOG_DEBUG, "Got line: \"%s\" (%ld, %ld)", buffer, didget, len);
+freelog(LOG_DEBUG, "Got line: \"%s\" (%ld, %ld)", buffer,
+(long int) didget, (long int) len);
}
#else /* HAVE_GETLINE */
buffer = malloc(BUF_SIZE + 1);
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40505) Bug: Government help text not displayed in Help government pages.
http://bugs.freeciv.org/Ticket/Display.html?id=40505 > The help text defined in government.ruleset is not displayed on the help page for the government. This means that any effects that do not result in an automatically generated string can not be explained manually, and are thus invisible. _ Uniek: Onbeperkt chatten op je mobiel voor maar € 2,95 per maand! http://www.overaljevriendenbijje.nl/#superdeal The help text defined in government.ruleset is not displayed on the help page for the government. This means that any effects that do not result in an automatically generated string can not be explained manually, and are thus invisible.Het beste van Windows, nu ook online. Deel jouw wereld met Windows Live. Download nu. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40505) Bug: Government help text not displayed in Help government pages.
http://bugs.freeciv.org/Ticket/Display.html?id=40505 >
Thanks for bringing this to attention. The government
help text buffer was being truncated by a bug that was
introduced in revision 14233 (tickets 40012, 40013)[1].
The attached patch is a minimal fix for the problem, and
also fixes the misleading comment header for the function
insert_allows (which I guess may have contributed to the
original bug).
It would be wonderful if someone could clean up the help
text code to remove static buffers, macros and general
inefficiencies, and make it more translator friendly (i.e.
no stitching together of sentence fragements), but I will
not cry [much] if it does not happen any time soon.
(For bored freeciv-dev lurkers only:)
[1] For a nice WTF compare the patches (du2.14230, du2.14228)
in the aforementioned tickets to the actual changes in r14233
http://svn.gna.org/viewcvs/freeciv?view=rev&rev=14233
with respect to client/helpdata.c; search string "insert_allows".
---
怒った群集は死刑を要求した。
diff --git a/client/helpdata.c b/client/helpdata.c
index 1b089a8..84a70a1 100644
--- a/client/helpdata.c
+++ b/client/helpdata.c
@@ -218,7 +218,7 @@ static void insert_requirement(struct requirement *req,
}
/
- Append text for what this requirement source allows. Something like
+ Generate text for what this requirement source allows. Something like
"Allows Communism government (with University technology).\n\n"
"Allows Mfg. Plant building (with Factory building).\n\n"
@@ -226,6 +226,10 @@ static void insert_requirement(struct requirement *req,
This should be called to generate helptext for every possible source
type. Note this doesn't handle effects but rather production
requirements (currently only building reqs).
+
+ NB: This function overwrites any existing buffer contents by writing the
+ generated text to the start of the given 'buf' pointer (i.e. it does
+ NOT append like cat_snprintf).
/
static void insert_allows(struct req_source *psource,
char *buf, size_t bufsz)
@@ -1301,7 +1305,7 @@ void helptext_government(char *buf, size_t bufsz, struct government *gov,
/* Effects */
CATLSTR(buf, bufsz, _("Features:\n"));
- insert_allows(&source, buf, bufsz);
+ insert_allows(&source, buf + strlen(buf), bufsz - strlen(buf));
effect_list_iterate(get_req_source_effects(&source), peffect) {
Output_type_id output_type = O_LAST;
struct unit_class *unitclass = NULL;
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
