[Freeciv-Dev] (PR#16811) Issue tracking system for Freeciv
http://bugs.freeciv.org/Ticket/Display.html?id=16811 > > [s1kevin - Mon Dec 29 07:06:22 2008]: > > This bug has been open since May of '06. Is anyone taking > my offer to assist moving from RT to Bugzilla seriously? > If not, please close this issue. > > I believe this is the best way I can contribute now to > the development of Freeciv - by providing what I feel > is a far superior issue tracking system with much better > search capabilities and more transparency to help encourage > developer participation (even new developers). If you use > Eclipse as your development environment, it has support > for task management (via Mylyn) directly in Bugzilla. > > I might be willing to assist in Freeciv code development, > but at this point, I'd want to use an issue tracking > system that supports me as both a user and a developer. > From my perspective, RT is not designed for software > development projects. Bugzilla is. Here is what needs to happen: 1. A host for the bug tracker must be found. This is either a machine someone can install/configure bugzilla on, or a service hosting bugzilla. 2. The current RT system needs to be frozen, all new requests redirected to the new tracker, and the public bug report address updated everywhere. 3. Current outstanding tickets and history should be moved to the new tracker. The problem has always been 1, since a dedicated machine (e.g. in a data center) costs money, or a free service is restricted (e.g. in allowed space) or missing some key functionality. Assuming a solution to the above exists, 2 is hard because the only people (person?) with the required access to the RT machine is not an active developer and/or checks freeciv-dev only infrequently (besides probably not having the time to make the changes in RT, if that is even possible). 3 is not crucial; I assume there are less than 100 important open tickets, which can be moved by hand as they are handled, and the RT system could be kept in "read-only" mode to make the history available (in the minimum-effort scenario). If as you said using bugzilla would help encourage developer contributions from the community then I am strongly for it. This project is in great need of help from competent coders to handle bug reports, assist less experienced programmers with their ideas, and fix the design mistakes that have broken past working features (e.g. borders) and are causing new development to stagnate. --- サンタクロースではなく、キッコーマンだよ。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#16811) Issue tracking system for Freeciv
http://bugs.freeciv.org/Ticket/Display.html?id=16811 > FWIW, the launchpad developers would help you import your bug history into launchpad. I can't say for certain that it does RT imports, but it does already integrate with RT instances - so you can add bugs to the freeciv bug tracker through launchpad right now so that any freeciv bugs related to ubuntu come back to freeciv as well. https://bugs.launchpad.net/bugs/bugtrackers/freeciv-rt https://bugs.launchpad.net/freeciv You can interact with bugs on launchpad through email as well as the web interface. One possible issue is that launchpad uses global bug numbers, so there wouldn't be a direct mapping from old numbers to new numbers. It may be possible to have bugs tagged with their RT bug number so you could still search by that. Cheers, Roger ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Windows Installer source code
I am looking for the source code to produce the Windows Installer. Specifically with the GTK2 client. I look through the source tarball I downloaded and I don't find it. I was able to successfully build Freeciv in a MSYS environment, but the installation is stuck in that environment, dependent on the user running MSYS. I want all the .dlls to get installed in the app directory so that it's standalone, so that I can test how it would behave for a Windows end user. I figure someone has already got those sources / scripts somewhere, they are just not in source control? It would be nice to have them publically available so that other people can reproduce and test the build. I know you Unixen are used to having every single imaginable library as a readily installed package and centrally shared for all apps, but Windows culture is exactly the opposite. No packages for open source libraries, no sharing, every app replicates its own libraries and doesn't trust anyone else to provide versions of them. Sure there is Cygwin but that's not Windows. I did get a MinGW/MSYS build system together, with a fair amount of manual labor installing libraries. Actually I updated the Install-Windows wiki page a bit, if anyone noticed. http://freeciv.wikia.com/wiki/Install-Windows Mostly, life is easier if you grab the all-in-one GTK+ stack. Cheers, Brandon Van Every ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40615) [Editor] Remove border/territory tool
http://bugs.freeciv.org/Ticket/Display.html?id=40615 >
I can't see how to logically design a "border editing tool" with
the current or any assumed future border system so here is a patch
that removes it. If I or someone else thinks of a use for this tool
that makes sense, it can of course be easily reinstated.
---
この国境は天命である。
client/editor.c | 10 --
client/gui-gtk-2.0/editgui.c |7 ---
common/packets.def |6 --
server/edithand.c| 34 --
4 files changed, 0 insertions(+), 57 deletions(-)
diff --git a/client/editor.c b/client/editor.c
index d5b89f8..1f6be9e 100644
--- a/client/editor.c
+++ b/client/editor.c
@@ -177,9 +177,6 @@ void editor_init(void)
| ETF_HAS_COPY_PASTE, _("Create city.\nShortcut: c"));
tool_init(ETT_VISION, _("Vision"), ETF_HAS_SIZE,
_("Modify player's tile knowledge.\nShortcut: v"));
- tool_init(ETT_TERRITORY, _("Territory"),
-ETF_HAS_SIZE | ETF_HAS_APPLIED_PLAYER,
-_("Change tile ownership.\nShortcut: b"));
tool_init(ETT_STARTPOS, _("Start Position"), ETF_HAS_APPLIED_PLAYER,
_("Place a player start position.\nShortcut: p"));
@@ -861,10 +858,6 @@ void editor_apply_tool(const struct tile *ptile,
}
break;
- case ETT_TERRITORY:
-dsend_packet_edit_territory(my_conn, x, y, erase ? -1 : apno, size);
-break;
-
case ETT_STARTPOS:
dsend_packet_edit_startpos(my_conn, x, y, erase ? -1 : apno);
break;
@@ -1196,9 +1189,6 @@ struct sprite *editor_tool_get_sprite(enum editor_tool_type ett)
case ETT_VISION:
return sprites->vision;
break;
- case ETT_TERRITORY:
-return sprites->territory;
-break;
case ETT_STARTPOS:
return sprites->startpos;
break;
diff --git a/client/gui-gtk-2.0/editgui.c b/client/gui-gtk-2.0/editgui.c
index 2168cc2..f9d1b55 100644
--- a/client/gui-gtk-2.0/editgui.c
+++ b/client/gui-gtk-2.0/editgui.c
@@ -513,7 +513,6 @@ static struct editbar *editbar_create(void)
editbar_add_tool_button(eb, ETT_UNIT);
editbar_add_tool_button(eb, ETT_CITY);
editbar_add_tool_button(eb, ETT_VISION);
- editbar_add_tool_button(eb, ETT_TERRITORY);
editbar_add_tool_button(eb, ETT_STARTPOS);
separator = gtk_vseparator_new();
@@ -1407,9 +1406,6 @@ static GdkPixbuf *get_tool_value_pixbuf(enum editor_tool_type ett,
case ETT_VISION:
sprite = sprites->vision;
break;
- case ETT_TERRITORY:
-sprite = sprites->territory;
-break;
case ETT_STARTPOS:
sprite = sprites->startpos;
break;
@@ -1643,9 +1639,6 @@ gboolean handle_edit_key_press(GdkEventKey *ev)
case GDK_v:
new_ett = ETT_VISION;
break;
- case GDK_b:
-new_ett = ETT_TERRITORY;
-break;
case GDK_p:
new_ett = ETT_STARTPOS;
break;
diff --git a/common/packets.def b/common/packets.def
index 8455fda..300fac4 100644
--- a/common/packets.def
+++ b/common/packets.def
@@ -1471,12 +1471,6 @@ PACKET_EDIT_TILE_BASE=157;cs,handle-per-conn,dsend
UINT8 size;
end
-PACKET_EDIT_TERRITORY=158;cs,handle-per-conn,dsend
- COORD x, y; key
- PLAYER owner; # -1 (or other out of range) for erasing
- UINT8 size;
-end
-
PACKET_EDIT_STARTPOS=159;cs,handle-per-conn,dsend
COORD x, y; key
NATION nation; # -1 for erase
diff --git a/server/edithand.c b/server/edithand.c
index 3656184..46f0612 100644
--- a/server/edithand.c
+++ b/server/edithand.c
@@ -1194,40 +1194,6 @@ void handle_edit_toggle_fogofwar(struct connection *pc, int plr_no)
}
/
- Change the "ownership" of the tile(s) at the given coordinates.
-/
-void handle_edit_territory(struct connection *pc, int x, int y, int owner,
- int size)
-{
- struct player *pplayer;
- struct tile *ptile_center;
-
- ptile_center = map_pos_to_tile(x, y);
- if (!ptile_center) {
-notify_conn(pc->self, NULL, E_BAD_COMMAND,
-_("Cannot edit territory of tile (%d, %d) because "
- "it is not on the map!"), x, y);
-return;
- }
-
- /* NULL is ok; represents "no owner". */
- pplayer = player_by_number(owner);
-
- conn_list_do_buffer(game.est_connections);
- square_iterate(ptile_center, size - 1, ptile) {
-if (tile_owner(ptile) == pplayer
-|| tile_city(ptile) != NULL) {
- continue;
-}
-/* FIXME: This does not play well with border code
- * once edit mode is exited. */
-tile_set_owner(ptile, pplayer);
-send_tile_info(NULL, ptile, FALSE);
- } square_iterate_end;
- conn_list_do_unbuffer(game.est_connections);
-}
-
-/
Set the given position to be the start position for the given nation.
*
[Freeciv-Dev] (PR#40605) timer_list_size() crash
http://bugs.freeciv.org/Ticket/Display.html?id=40605 > > [book - Sat Dec 20 04:05:05 2008]: > > > [cazf...@gmail.com - Fri Dec 19 11:08:09 2008]: > > > > 2.1.8, using fantasy ruleset > > > > Program terminated with signal 11, Segmentation fault. > > [New process 20595] > > #0 0x0042a01b in genlist_size () > > (gdb) bt full > > #0 0x0042a01b in genlist_size () > > No locals. > > #1 0x004e6e40 in timer_list_size () > > No locals. > > #2 0x004e6d8d in close_connection () > > No locals. > > [...] > > > > This is probably related to the fact that incoming connection was > > rejected by auth code. > > > > > > I'm not sure if this is bug in official Freeciv. I have local > > modification for prohibiting login with certain accounts, and bug > > might be in that modification. > > I have seen a very similar backtrace in the past; this > is probably due to an attempted used of a NULL genlist. > The attached patches for S2_1 and trunk add checks for > the NULL list and should at least prevent crashing. I committed the patches; if you find any more clues as to the original cause of the bug or you still experience problems, feel free to re-open the ticket. --- 正確な時計が必要なのです。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
