[Freeciv-Dev] [bug #13618] [Patch] Tile_Workable effect
URL: http://gna.org/bugs/?13618 Summary: [Patch] Tile_Workable effect Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 06/03/2009 at 17:23 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: Attached patch adds Tile_Workable effect. City can work only those tiles where effect is active. ___ File Attachments: --- Date: Wednesday 06/03/2009 at 17:23 Name: TileWorkableEft.diff Size: 4kB By: cazfi http://gna.org/bugs/download.php?file_id=5879 ___ Reply to this item at: http://gna.org/bugs/?13618 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13619] [Bugfix] Double Farmland bonus on city center tiles
URL: http://gna.org/bugs/?13619 Summary: [Bugfix] Double Farmland bonus on city center tiles Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 06/03/2009 at 17:25 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: If player makes real Farmland to city center tile, (s)he will still get normal bonus out of it - in addition to automatic city center famland effect. Fix attached ___ File Attachments: --- Date: Wednesday 06/03/2009 at 17:25 Name: CCDoubleFarmlandBonusFix.diff Size: 988B By: cazfi http://gna.org/bugs/download.php?file_id=5880 ___ Reply to this item at: http://gna.org/bugs/?13619 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13620] [Wichlist] Gfx layer about native tiles
URL: http://gna.org/bugs/?13620 Summary: [Wichlist] Gfx layer about native tiles Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 06/03/2009 at 17:30 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: There should be optional (toggle in view-menu) graphics layer displaying which tiles currently active unit can enter. Non-native tiles could be shown, for example, as red similar to how unworkable tiles are shown in city dialog. ___ Reply to this item at: http://gna.org/bugs/?13620 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13604] [patch] show effect of pollution on illness
Update of bug #13604 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13604 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-commits] r15710 - /trunk/doc/README.effects
done ... Am Wednesday 03 June 2009 11:13:20 schrieb Matthias Pfafferodt: [send also to the mailing list] I will update the wiki file for the effect 'Shield2Gold_Factor' and the unit flag 'Shield2Gold'. Matthias 2009/6/3 Madeline Book madeline.b...@gmail.com: Author: mbook Date: Wed Jun  3 02:03:16 2009 New Revision: 15710 URL: http://svn.gna.org/viewcvs/freeciv?rev=15710view=rev Log: Updated effect docs in light of the last patch. Modified:   trunk/doc/README.effects Please update new effects and unit flags to http://freeciv.wikia.com/wiki/Editing_rulesets too. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13621] [patch] load game settings from ruleset
URL: http://gna.org/bugs/?13621 Summary: [patch] load game settings from ruleset Project: Freeciv Submitted by: syntron Submitted on: Mittwoch 03.06.2009 um 23:18 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: game settings (the 'set' command) can not be stored in the rulesets. If you change the ruleset with the 'rulesetdir' command the settings have to be restored by hand. The attached patch adds a [game] section to the game.ruleset file, where the game settings can be set for the ruleset. They are set if the ruleset is changed and a message about changed settings is printed. changes: - load [game] section of game.ruleset file - change default, civ1 and civ2 rulesets - change 'set borders 4' in the default ruleset to borders = 1 as the value 4 is not allowed (1 = enabled) ___ File Attachments: --- Date: Mittwoch 03.06.2009 um 23:18 Name: set.patch.diff Size: 10kB By: syntron http://gna.org/bugs/download.php?file_id=5883 ___ Reply to this item at: http://gna.org/bugs/?13621 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13621] [patch] load game settings from ruleset
Follow-up Comment #1, bug #13621 (project freeciv):
Some basic things I noticed looking at the
patch:
You can just use the simpler
for (op = settings; op-name; op++)
instead of 'do {} while' to iterate over
settings. (Maybe there should be a settings
_iterate macro.)
You probably do not need to send info to
clients (if that is what you mean by update
in load_ruleset_game_set()) since there will
be a send_game_info() some time after. But
check this please.
You do not need the 'bool check' argument
to ruleset_set_cmd().
You do not need the '{} /* no error */' stuff.
Instead of looking up the value twice in
order to check that it exists, just pass in
the op's current value the first time. So:
val_bool = secfile_lookup_bool_default(pfile, *op-bool_value, game.%s,
op-name);
if (val_bool == *op-bool_value) {
...
and similarly for the other setting types
(of course strcmp for strings).
Do not declare and initialize variables over
case labels in a switch statement. Declare
them all in the enclosing scope of the switch
statement, or right after the starting brace of
the switch (before cases), or make a new scope
in each case where you need new variables.
Do not add header includes to other headers
unless there really is no way to avoid it.
In this case please just include fc_types.h in
the c file, not in ruleset.h.
厳しいだが、不公平ではない。
___
Reply to this item at:
http://gna.org/bugs/?13621
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
