[Freeciv-Dev] [bug #13621] [patch] load game settings from ruleset
Follow-up Comment #5, bug #13621 (project freeciv): The attached version has some minor style and formatting improvements and is more or less good enough to commit, I think. There is though the obvious problem that ruleset_set_cmd() does not handle setting side-effects like the set_command() function does. Really what should be done is to factor out the changing of the setting's value into a separate function that is called by both of them. So set_command() would parse its command line and call the function, and ruleset_set_cmd() would parse the [game] section of the section file and call the function. Thus the special side-effects would be handled in just one place by design. But this can be left for another patch (this patch adds the appropriate FIXMEs as future reminders). トイレの上の天井に掛けてある。 (file #5931) ___ Additional Item Attachment: File name: version4-13621-set.patch.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?13621 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #13661] [Patch] Fix SDL client compilation
Sorry for the compiling errors in the clients. If I send another patch which touchs client code I will try to test/compile all clients to check for such simple errors ... Matthias Pfafferodt Am Tuesday 09 June 2009 23:38:18 schrieb Marko Lindqvist: URL: http://gna.org/bugs/?13661 Summary: [Patch] Fix SDL client compilation Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 06/10/2009 at 00:38 Category: client-sdl Severity: 3 - Normal Priority: 9 - Immediate Status: None Assigned to: cazfi Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: To be committed immediately ___ File Attachments: --- Date: Wednesday 06/10/2009 at 00:38 Name: FixSDLCompile.diff Size: 964B By: cazfi http://gna.org/bugs/download.php?file_id=5926 ___ Reply to this item at: http://gna.org/bugs/?13661 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13621] [patch] load game settings from ruleset
Follow-up Comment #6, bug #13621 (project freeciv):
Thanks for looking at this patch.
Could A cleanup for the FIXME reminders
be the following:
- a function game_setting(op, bool *bval,
int *ival, char* sval) which set the
requested option (in stdinhand.c)
switch (op-stype) {
case SSET_BOOL:
... checks + set value ...
case SSET_INT:
... checks + set value ...
case SSET_STRING:
... checks + set value ...
}
... do special things at the end ...
- call the function in stdinhand.c after the
command argument is converted to bool/int/string
and in ruleset.c after the value is read from
the ruleset file
- handling of aifill and auto_ai_ toggle only if
needed
___
Reply to this item at:
http://gna.org/bugs/?13621
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13645] [Patch] Fuel usage checks instead of is_air_unit()
Follow-up Comment #1, bug #13645 (project freeciv): Updated against svn (file #5933) ___ Additional Item Attachment: File name: UtypeFuel_13645-2.diff Size:13 KB ___ Reply to this item at: http://gna.org/bugs/?13645 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13666] [Patch] Scenario victory
URL: http://gna.org/bugs/?13666 Summary: [Patch] Scenario victory Project: Freeciv Submitted by: cazfi Submitted on: Thursday 06/11/2009 at 01:30 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: This patch adds Player:victory() method to scripting API. It can be used to create custom victory conditions for scenarios. ___ File Attachments: --- Date: Thursday 06/11/2009 at 01:30 Name: Victory.diff Size: 6kB By: cazfi http://gna.org/bugs/download.php?file_id=5934 ___ Reply to this item at: http://gna.org/bugs/?13666 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13667] Game end message not visible
URL: http://gna.org/bugs/?13667 Summary: Game end message not visible Project: Freeciv Submitted by: cazfi Submitted on: Thursday 06/11/2009 at 01:35 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: Game end message (one listing winner) should go to messages tab by default. It never appears there. If I configure it to appear in output window, it shows just fine. I guess it gets sent in the end of the last turn and messages tab gets cleared before user has chance to see it. ___ Reply to this item at: http://gna.org/bugs/?13667 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
