[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

[pepeto]

URL:
  

 Summary: [Patch] Chat colors and other improvements
 Project: Freeciv
Submitted by: pepeto
Submitted on: Tuesday 07/07/2009 at 06:40
Category: general
Severity: 1 - Wish
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

The attached patch grants the function needed to obtain what I begin to
describe in my wikia user page
(http://freeciv.wikia.com/wiki/User:Pepeto/Chat_improvements_ideas).




___

File Attachments:


---
Date: Tuesday 07/07/2009 at 06:40  Name: featured_text.diff  Size: 38kB   By:
pepeto



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13890] [Patch] Transform unit

[Marko Lindqvist]

URL:
  

 Summary: [Patch] Transform unit
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tuesday 07/07/2009 at 02:59
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

Attached patch makes it possible for units to transform in to other units.

I needed this to make something like "Cannon build crew" unit which, after
built in city, can move to site where cannon should be placed. Then the crew
transforms itself in to immobile "Cannon" unit. Cannon cannot transform to
anything.
Of course this new moddability feature can be used to many other things as
well, as long as AI's inability to use this feature is not a problem.

As implemented in this patch, transforming takes no time. It works like unit
upgrade does (sharing most of the code with upgrading).



___

File Attachments:


---
Date: Tuesday 07/07/2009 at 02:59  Name: TransformUnit.diff  Size: 15kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13889] Attempt to move unit with 0 move rate crashes client

[Marko Lindqvist]

URL:
  

 Summary: Attempt to move unit with 0 move rate crashes
client
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tuesday 07/07/2009 at 02:48
Category: client
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

If one tries to move unit that has 0 move_rate (cannot move by itself),
client crashes.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13879] Rename *_worklist function to worklist_*

[pepeto]

Follow-up Comment #2, bug #13879 (project freeciv):

Yes, it is intentional.  It just duplicates the init_worklist() done in
worklist_load() (just following call).  Moreover, this function was already
removed in trunk/.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13879] Rename *_worklist function to worklist_*

[Marko Lindqvist]

Follow-up Comment #1, bug #13879 (project freeciv):

S2_1 version of the patch removes init_worklist() / worklist_init() from
savegame.c. Why? Is that intentional?


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13885] [Patch] @bindir@ instead of @prefix@/bin in .dsc.in files

[Marko Lindqvist]

URL:
  

 Summary: [Patch] @bindir@ instead of @prefix@/bin in .dsc.in
files
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tuesday 07/07/2009 at 00:06
Category: bootstrap
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

Currently .dsc.in files set path to executables to be @prefix@/bin meaning
bindir set separately from prefix does not work. Fix attached.



___

File Attachments:


---
Date: Tuesday 07/07/2009 at 00:06  Name: GgzBindir.diff  Size: 862B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13798] [Patch] Gen-movement version of slowinvasions setting

[Marko Lindqvist]

Update of bug #13798 (project freeciv):

  Status:None => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13845] [Patch] Help mentions if unit has no "TerrainDefense" flag

[Marko Lindqvist]

Update of bug #13845 (project freeciv):

  Status:None => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13832] [Patch] Launch freeciv-gtk2 instead of non-existend civclient

[Marko Lindqvist]

Update of bug #13832 (project freeciv):

  Status:None => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13847] Build of multiple clients fails when one of them is ggz enabled gtk

[Marko Lindqvist]

Follow-up Comment #3, bug #13847 (project freeciv):

Updated against svn

(file #6152)
___

Additional Item Attachment:

File name: EmbedGgzMultiClient_13847-3.diff Size:11 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40274) [Patch] connectmsg command

[Marko Lindqvist]

http://bugs.freeciv.org/Ticket/Display.html?id=40274 >

2008/6/21 Madeline Book :
>
> The widget that holds the text of the connect message (a label
> I believe it is) should be set to allow selecting text (e.g.
> for copy and pasting). Especially if the message would be used
> to display website addresses or somesuch.

 Original patch was written for 2.1 server and had to work with
already released clients. So exsting events system was used which
meant that standard event popup was used.

 When implementing this for 2.2 we are of course free to change
network protocol and to create completely new dialog for connect
message. Attached version of the patch does just that.

 If nobody objects, I'll commit this version. At least some
implementation should go to 2.2. If someone thinks that warclient
implementation should be ported and is willing to do that, I'm ready
to consider it instead (without checking the details I don't yet
promise that I would accept it).


 - ML

diff -Nurd -X.diff_ignore freeciv/client/gui-ftwl/dialogs.c freeciv/client/gui-ftwl/dialogs.c
--- freeciv/client/gui-ftwl/dialogs.c	2009-06-26 03:00:27.0 +0300
+++ freeciv/client/gui-ftwl/dialogs.c	2009-07-06 22:20:03.0 +0300
@@ -53,6 +53,17 @@
 }
 
 /**
+  Popup a dialog to display connection message from server.
+**/
+void popup_connect_msg(const char *headline, const char *message)
+{
+  /* FIXME: Needs proper implementation.
+   *Now just puts to chat window so message is not completely lost. */
+
+  append_output_window(message);
+}
+
+/**
   Popup a generic dialog to display some generic information.
 **/
 void popup_notify_dialog(const char *caption, const char *headline,
diff -Nurd -X.diff_ignore freeciv/client/gui-gtk-2.0/dialogs.c freeciv/client/gui-gtk-2.0/dialogs.c
--- freeciv/client/gui-gtk-2.0/dialogs.c	2009-06-26 03:00:26.0 +0300
+++ freeciv/client/gui-gtk-2.0/dialogs.c	2009-07-06 21:57:02.0 +0300
@@ -173,6 +173,14 @@
   gtk_widget_destroy(w);
 }
 
+/
+  User clicked close for connect message dialog
+*/
+static void notify_connect_msg_response(GtkWidget *w, gint response)
+{
+  gtk_widget_destroy(w);
+}
+
 /**
   Popup a dialog to display information about an event that has a
   specific location.  The user should be given the option to goto that
@@ -225,6 +233,35 @@
   gtk_widget_show(shell);
 }
 
+/**
+  Popup a dialog to display connection message from server.
+**/
+void popup_connect_msg(const char *headline, const char *message)
+{
+  GtkWidget *shell, *label;
+  
+  shell = gtk_dialog_new_with_buttons(headline,
+NULL,
+0,
+NULL);
+  setup_dialog(shell, toplevel);
+  gtk_dialog_set_default_response(GTK_DIALOG(shell), GTK_RESPONSE_CLOSE);
+  gtk_window_set_position(GTK_WINDOW(shell), GTK_WIN_POS_CENTER_ON_PARENT);
+
+  label = gtk_label_new(message);
+  gtk_label_set_selectable(GTK_LABEL(label), 1);
+
+  gtk_container_add(GTK_CONTAINER(GTK_DIALOG(shell)->vbox), label);
+  gtk_widget_show(label);
+
+  gtk_dialog_add_button(GTK_DIALOG(shell), GTK_STOCK_CLOSE,
+			GTK_RESPONSE_CLOSE);
+
+  g_signal_connect(shell, "response", G_CALLBACK(notify_connect_msg_response),
+   NULL);
+  gtk_widget_show(shell);
+}
+
 /
 ...
 */
diff -Nurd -X.diff_ignore freeciv/client/gui-sdl/dialogs.c freeciv/client/gui-sdl/dialogs.c
--- freeciv/client/gui-sdl/dialogs.c	2009-06-26 03:03:16.0 +0300
+++ freeciv/client/gui-sdl/dialogs.c	2009-07-06 23:00:23.0 +0300
@@ -211,6 +211,14 @@
   			a: %s\nb: %s",headline, lines );
 }
 
+/**
+  Popup a dialog to display connection message from server.
+**/
+void popup_connect_msg(const char *headline, const char *message)
+{
+  freelog(LOG_ERROR, "popup_connect_msg() PORT ME");
+}
+
 /* --- */
 struct ADVANCED_DLG *pNotifyDlg = NULL;
 
diff -Nurd -X.diff_ignore freeciv/client/gui-stub/dialogs.c freeciv/client/gui-stub/dialogs.c
--- freeciv/client/gui-stub/dialogs.c	2008-10-27 04:14:03.0 +0200
+++ freeciv/client/gui-stub/dialogs.c	2009-07-06 22:20:33.

[Freeciv-Dev] [bug #13884] Misspelled Canadian City Name

[Joel Kenny]

URL:
  

 Summary: Misspelled Canadian City Name
 Project: Freeciv
Submitted by: duskeagle
Submitted on: Monday 07/06/2009 at 15:13
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

In data/nation/canadian.ruleset, Niagara Falls is mispelled as "Niagara
Fall". The small patch below fixes this issue.

Citation for the spelling of the name: http://niagarafalls.ca/



___

File Attachments:


---
Date: Monday 07/06/2009 at 15:13  Name: canadian_cities_patch.diff  Size:
711B   By: duskeagle



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Gna email problems

[Daniel Markstedt]

On Mon, Jul 6, 2009 at 3:28 PM, Marko Lindqvist wrote:
> 2009/7/6 Daniel Markstedt :
>> On Sun, Jul 5, 2009 at 8:24 AM, Pepeto wrote:
>>> 2009/7/4 cazfi wrote:
 It seems that commit messages are not being sent to freeciv-commits.

>>>
>>> I already experienced this problem when I started to work in warclient.
>>> It is actually due to the sebnding rights.  I think Book is not allowed
>>> to send e-mails to the commit mailing list.  An administrator should fix
>>> that.
>>>
>>
>> Madeline, are you subscribed to the freeciv-commits list? If you're
>> not, try subscribing and I think the problems will go away.
>
>  There is no problem. Madeline's commit messages are coming from
> freeciv-commits just fine. Just for a couple of days nobody's messages
> were coming. Since then those messages have come, couple of days late.
> Same problem seemed to be with all freeciv mailing lists.
>
>
>  - ML
>

Ok I see. So the problem resolved itself, so to speak.

Daniel

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

[Marko Lindqvist]

Follow-up Comment #2, bug #13843 (project freeciv):

This new submenu lists all buildable base types - ruleset can specify
arbitrary number of them. This is quite similar to "Change Government"
submenu.

Having almost duplicate entries for fortresses and airbases is far from
optimal. Nobody has yet come out with good suggestion how to handle this in a
better way. We cannot reserve keys for all possible base types, so items in
"Build Base" menu have none. Inreased moddability should not make use of
default ruleset harder, so Fortress and Airbase in default ruleset should
keep their keys ('f' & 'e'). Old entries under "Orders" menu refer to these.
Also, clients other than gtk have no generic base building possibility
similar to "Build Base" menu.
Entries under "Build Base" build exactly the selected base type. "Build
Fortress" and "Build Airbase" on the other hand build first available base
type that has gui-type "Fortress" or "Airbase", respectively. "First
available" may depend on terrain, unit type, known technologies... So it's
even possible that if you have several focus units and select "Build
Fortress", some of the focus units start building "Fortress" and others
"Tower".

Hope this helps to understand current situation.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13880] [Patch] make universal_kind_name working with enum universals_n

[Marko Lindqvist]

Update of bug #13880 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13879] Rename *_worklist function to worklist_*

[Marko Lindqvist]

Update of bug #13879 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13881] [Patch] Init pf nodes only once

[Marko Lindqvist]

Update of bug #13881 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Gna email problems

[Marko Lindqvist]

2009/7/6 Daniel Markstedt :
> On Sun, Jul 5, 2009 at 8:24 AM, Pepeto wrote:
>> 2009/7/4 cazfi wrote:
>>> It seems that commit messages are not being sent to freeciv-commits.
>>>
>>
>> I already experienced this problem when I started to work in warclient.
>> It is actually due to the sebnding rights.  I think Book is not allowed
>> to send e-mails to the commit mailing list.  An administrator should fix
>> that.
>>
>
> Madeline, are you subscribed to the freeciv-commits list? If you're
> not, try subscribing and I think the problems will go away.

 There is no problem. Madeline's commit messages are coming from
freeciv-commits just fine. Just for a couple of days nobody's messages
were coming. Since then those messages have come, couple of days late.
Same problem seemed to be with all freeciv mailing lists.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

[Bernd Jendrissek]

On Fri, Jul 3, 2009 at 2:00 AM, Madeline
Book wrote:
> I also prefer the 0 rule because if we realize that
> case labels are essentially the same as goto labels,

Yesterday I was genuinely tempted for a minute to write some map
guessing code as:

  switch (tile_get_known(ptile)) {
  case TILE_KNOWN_FOGGED:
if (guessed_terrain->index == ptile->terrain->index) {
  case TILE_KNOWN:
  if (is_resource_valid(something_or_other)) { ... }
}
break;
...

I am going to assume that taking full advantage of the realization is
Strictly Verboten!

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13881] [Patch] Init pf nodes only once

[pepeto]

URL:
  

 Summary: [Patch] Init pf nodes only once
 Project: Freeciv
Submitted by: pepeto
Submitted on: Monday 07/06/2009 at 10:45
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

The nodes in the pf code are usually initialized once.  But in the case the
node was not reachable, it usually re-initialize next time the node is
tested.  Basically, this is totally useless, because the informations in the
node structures are not supposed to change.




___

File Attachments:


---
Date: Monday 07/06/2009 at 10:45  Name: S2_1_pf_init_node.diff  Size: 4kB  
By: pepeto


---
Date: Monday 07/06/2009 at 10:45  Name: trunk_pf_init_node.diff  Size: 4kB  
By: pepeto



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13880] [Patch] make universal_kind_name working with enum universals_n

[pepeto]

URL:
  

 Summary: [Patch] make universal_kind_name working with enum
universals_n
 Project: Freeciv
Submitted by: pepeto
Submitted on: Monday 07/06/2009 at 10:38
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

In current trunk/, there are two function to do exactly the name task.  There
are universal_kind_name() and universal_type_rule_name().  Whereas, one such
function which takes a "enum universals_n" as argument is needed, notably in
savegame.c to avoid some hack.



___

File Attachments:


---
Date: Monday 07/06/2009 at 10:38  Name: trunk_universal_kind_name.diff  Size:
5kB   By: pepeto



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13879] Rename *_worklist function to worklist_*

[pepeto]

URL:
  

 Summary: Rename *_worklist function to worklist_*
 Project: Freeciv
Submitted by: pepeto
Submitted on: Monday 07/06/2009 at 10:33
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

init_worklist() becomes worklist_init().
copy_worklist() becomes worklist_copy().




___

File Attachments:


---
Date: Monday 07/06/2009 at 10:33  Name: S2_1_worklist_rename.diff  Size: 9kB 
 By: pepeto


---
Date: Monday 07/06/2009 at 10:33  Name: trunk_worklist_rename.diff  Size: 8kB
  By: pepeto



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Gna email problems

[Daniel Markstedt]

On Sun, Jul 5, 2009 at 8:24 AM, Pepeto wrote:
> 2009/7/4 cazfi wrote:
>> It seems that commit messages are not being sent to freeciv-commits.
>>
>> Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv
>>
>>
>> - ML
>
> I already experienced this problem when I started to work in warclient.
> It is actually due to the sebnding rights.  I think Book is not allowed
> to send e-mails to the commit mailing list.  An administrator should fix
> that.
>

Madeline, are you subscribed to the freeciv-commits list? If you're
not, try subscribing and I think the problems will go away.

Daniel

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev