[Freeciv-Dev] [bug #14702] Building a city with multiple settlers on single tile

2009-11-08 Thread Mity

URL:
  http://gna.org/bugs/?14702

 Summary: Building a city with multiple settlers on single
tile
 Project: Freeciv
Submitted by: mity
Submitted on: Sunday 11/08/2009 at 14:51
Category: client-gtk-2.0
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

freeciv version 2.1.9

When selecting multiple settlers and building new city, multiple pop-up
dialogs appear (per settler in selection) asking for new city name even in
case when all the settlers are on the same tile. 

I would expect that for a tile with some selected settler(s) on it exactly
one such dialog appears and other settlers on such tile are only used to
expand size of the new city.

The easiest way to reproduce: 
(1) Move multiple settlers to single tile.
(2) Press 'k'.
(3) Press 'b'.





___

File Attachments:


---
Date: Sunday 11/08/2009 at 14:51  Name: snapshot1.png  Size: 304kB   By: mity
screenshot
http://gna.org/bugs/download.php?file_id=7243

___

Reply to this item at:

  http://gna.org/bugs/?14702

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14705] Window dimensions should be restored at the main menu

2009-11-08 Thread Daniel Markstedt

URL:
  http://gna.org/bugs/?14705

 Summary: Window dimensions should be restored at the main
menu
 Project: Freeciv
Submitted by: dmarks
Submitted on: 월요일 2009년 11월 09일 at 00:20
Category: client-gtk-2.0
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

The main menu window should always have the same initial dimensions when you
return to it - just enough to display the splash and buttons.

My testcase is:
1)Connect to a server with a longer intro message - I tested on one of
Cazfi's 'Ancients' servers.
2)Note how the window is resized to include the intro message at the bottom
3)Disconnect and return to the main menu
4)Note the window dimensions

Expected behavior:
*As you return to the main menu, the initial dimensions of the window is
restored

Actual behavior:
*The window dimensions from step 2 are retained at the main menu, making it
too tall (and hard to resize on my MacBook ;) ).




___

Reply to this item at:

  http://gna.org/bugs/?14705

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14705] Window dimensions should be restored at the main menu

2009-11-08 Thread Daniel Markstedt

Update of bug #14705 (project freeciv):

 Release: = 2.1.9+ svn 16326   
Operating System:None = Mac OS 


___

Reply to this item at:

  http://gna.org/bugs/?14705

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1266] add option to restrict the use of road and rails for enemies

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #8, patch #1266 (project freeciv):

updated patch; changes:

* rename the function to restrict_infra()
* change logic: TRUE = infrastructure restricted

(file #7244)
___

Additional Item Attachment:

File name:
20091108-restrictinfra-0001-add-option-to-restrict-the-use-of-road-and-rails-for.diff
Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?1266

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1356] use specnum.h for the event types

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #5, patch #1356 (project freeciv):

There should be a hint, that E_LAST should be used as the last element of the
list (the number needs to be updated). Would it be possible to add
SPECENUM_LAST to generate_specenum.py?

___

Reply to this item at:

  http://gna.org/patch/?1356

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1330 (project freeciv):

Updated patch; the overview and the happiness page of the gtk citydialog are
changed. The aim is to show as much information as possible in the available
space. It is mainly needed if the variable city radius is used. The following
images are attached:

citydlg-old.png - the old city dialog (current trunk)
citydlg-new.png - the new citydialog
citydlg-new+cityradius.png - the new city dialog with the variable city radii
patches

The patch is independent from the patch series 'variable city radii'.

(file #7245, file #7246, file #7247)
___

Additional Item Attachment:

File name: 20091108-gtk_citydlg-0001-update-city-dialog-for-gtk-2.0.diff
Size:30 KB
File name: citydlg-new.pngSize:407 KB
File name: citydlg-old.pngSize:387 KB


___

Reply to this item at:

  http://gna.org/patch/?1330

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14707] Selected theme does not apply until game starts

2009-11-08 Thread John

URL:
  http://gna.org/bugs/?14707

 Summary: Selected theme does not apply until game starts
 Project: Freeciv
Submitted by: kinetic
Submitted on: Sunday 11/08/2009 at 18:29
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

When I select a theme (in this case, QTCurve) and save the options, and
freeciv closed and reopened, the main menu uses the freeciv theme (with
qtcurve buttons) as does the pregame menu, but when the game starts, the
qtcurve theme comes into effect. 

attached is screenshots of the main menu, pregame and ingame, without
changing any settings.
2.2 r16320



___

File Attachments:


---
Date: Sunday 11/08/2009 at 18:29  Name: mainmenu.png  Size: 515kB   By:
kinetic

http://gna.org/bugs/download.php?file_id=7248
---
Date: Sunday 11/08/2009 at 18:29  Name: ingame.png  Size: 112kB   By: kinetic

http://gna.org/bugs/download.php?file_id=7249
---
Date: Sunday 11/08/2009 at 18:29  Name: pregame.png  Size: 245kB   By:
kinetic

http://gna.org/bugs/download.php?file_id=7250

___

Reply to this item at:

  http://gna.org/bugs/?14707

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #2, patch #1330 (project freeciv):

add missing file as jpg: citydlg-new+cityradius.jpg

two more images showing a city with the largest possible radius:

happiness page: citydlg2-new+cityradius-happiness.jpg
overview page: citydlg2-new+cityradius.jpg

(file #7251, file #7252, file #7253)
___

Additional Item Attachment:

File name: citydlg2-new+cityradius-happiness.jpg Size:127 KB
File name: citydlg2-new+cityradius.jpgSize:111 KB
File name: citydlg-new+cityradius.jpg Size:70 KB


___

Reply to this item at:

  http://gna.org/patch/?1330

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1234] more than one build slot for units

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #7, patch #1234 (project freeciv):

updated patch; changes:

* add effect to give at least one build slot to each city
* cleanup; patch is independent from the variable city radii patch series
* small changes to the gtk client

___

Reply to this item at:

  http://gna.org/patch/?1234

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1234] more than one build slot for units

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #8, patch #1234 (project freeciv):

a city with more build slots is shown in file #7252

___

Reply to this item at:

  http://gna.org/patch/?1234

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14306] save all settings in the savegame

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #3, bug #14306 (project freeciv):

patch for S2_1; save_compress_type is not used in this version

(file #7254)
___

Additional Item Attachment:

File name: 0002-save-all-settings-in-the-savegame-S2_1.diff Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?14306

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #7, bug #13869 (project freeciv):

use the setting struct as argument to the validation functions as proposed by
pepeto; this way it is a simplification as only one prototype is needed for
all validation (and action) functions

(file #7255)
___

Additional Item Attachment:

File name:
20091108-settings-0001-simplify-validation-functions-using-the-following-pro.diff
Size:18 KB


___

Reply to this item at:

  http://gna.org/bugs/?13869

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13871] [patch 05/07] add setting action callback function

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #6, bug #13871 (project freeciv):

using the struct setting as argument in the callback functions

(file #7256)
___

Additional Item Attachment:

File name: 20091108-settings-0002-add-settting-action-callback-function.diff
Size:40 KB


___

Reply to this item at:

  http://gna.org/bugs/?13871

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1284] update reset command

2009-11-08 Thread Matthias Pfafferodt

Follow-up Comment #5, patch #1284 (project freeciv):

typo corrected patch attached

 Shouldn't reset at a5  b6 give identical results? At least it
 would make debugging (bug reproducibility) easier.

This would need an additional section in the savegame which holds all the
setting values from the game start. A warning could be added if the settings
from a savegame are restored?

(file #7257)
___

Additional Item Attachment:

File name: 20091108-settings-0008-update-reset-command.diff Size:14 KB


___

Reply to this item at:

  http://gna.org/patch/?1284

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1356] use specnum.h for the event types

2009-11-08 Thread pepeto

Follow-up Comment #6, patch #1356 (project freeciv):

 There should be a hint, that E_LAST should be used as the last
 element of the list (the number needs to be updated). Would it
 be possible to add SPECENUM_LAST to generate_specenum.py?

Maybe there is an other way using event_type_max(), even for static arrays. 
I don't know if using the 'const' attribute would work in this case.  But
anyway, this should be a part of another ticket.

After this one, we would be also able to make a new orders for the events.


___

Reply to this item at:

  http://gna.org/patch/?1356

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14708] ATK warnings at start

2009-11-08 Thread pepeto

URL:
  http://gna.org/bugs/?14708

 Summary: ATK warnings at start
 Project: Freeciv
Submitted by: pepeto
Submitted on: dimanche 08.11.2009 à 22:06
Category: client-gtk-2.0
Severity: 2 - Minor
Priority: 3 - Low
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.0

___

Details:

Updating GTK to 2.18, I get error messages at start:

** (freeciv-gtk2:30666): CRITICAL **: atk_object_set_name: assertion `name !=
NULL' failed

** (freeciv-gtk2:30666): CRITICAL **: atk_object_set_name: assertion `name !=
NULL' failed


Fix attached.




___

File Attachments:


---
Date: dimanche 08.11.2009 à 22:06  Name: trunk_S2_2_atk_warnings.diff  Size:
1 ko   By: pepeto

http://gna.org/bugs/download.php?file_id=7258

___

Reply to this item at:

  http://gna.org/bugs/?14708

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14707] Selected theme does not apply until game starts

2009-11-08 Thread pepeto

Follow-up Comment #1, bug #14707 (project freeciv):

Unfortunately I don't have this theme available.  However, I tried with 3-4
themes, and all appeared correctly at start.  Would it be something wrong
with this particular theme?  Or linked with your GTK library version?


___

Reply to this item at:

  http://gna.org/bugs/?14707

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev