[Freeciv-Dev] [bug #16958] no messages for diplomat combat when in allied city
Follow-up Comment #6, bug #16958 (project freeciv): Sorry for late comment, but I think some of the arguments to the new messages may be wrong? You are right; Thanks for catching this! ___ Reply to this item at: http://gna.org/bugs/?16958 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2221] help text for city radius and build slots
URL: http://gna.org/patch/?2221 Summary: help text for city radius and build slots Project: Freeciv Submitted by: syntron Submitted on: Samstag 20.11.2010 um 10:30 Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0, 2.4.0 ___ Details: ___ File Attachments: --- Date: Samstag 20.11.2010 um 10:30 Name: 20101120-trunk-help-text-for-city-radius-and-build-slots.patch Size: 2kB By: syntron http://gna.org/patch/download.php?file_id=11287 ___ Reply to this item at: http://gna.org/patch/?2221 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius
Follow-up Comment #1, bug #17110 (project freeciv): The size for the next city image are hardcoded (see for example ./data/amplio/moderncities.spec): 2, 0, city.electricage_city_0 2, 1, city.electricage_city_4 2, 2, city.electricage_city_8 2, 3, city.electricage_city_12 2, 4, city.electricage_city_16 2, 5, city.electricage_wall_0 2, 6, city.electricage_wall_4 2, 7, city.electricage_wall_8 2, 8, city.electricage_wall_12 2, 9, city.electricage_wall_16 You could simply change the number at the end of the description tag (city.electricage_city_4 = city.electricage_city_3). Something nice would be the possibility to change this in the ruleset ... ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit
Follow-up Comment #7, bug #16639 (project freeciv): I had to modify your setup to run the game. Is this correct? The reason is that I can't start the game if I connect as global observer (error message: no enough human players). 1)Load savegame in stand-alone server 2)Start client and connect to server 2.1) connect to Rudolf (as user1) 2.2) aitoggle Rudolf 2.3) disconnect 2.4) connect as global observer (as user2) 3)Observe game as global observer 4)Make sure all players are AIs 5)Set 20s timeout 6)After some turns the asserts start appearing - now at turn 590 there are about 20 of them every turn I did not got the assert till now (secound game at turn 500) ___ Reply to this item at: http://gna.org/bugs/?16639 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1893] [metaticket] Help updates for 2.3.0
Update of patch #1893 (project freeciv): Depends on: = patch #2221 ___ Reply to this item at: http://gna.org/patch/?1893 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16964] Mfg. Plant + electrical plant bonus does not match Help
Follow-up Comment #2, bug #16964 (project freeciv): I vote for point 2. ___ Reply to this item at: http://gna.org/bugs/?16964 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit
Follow-up Comment #8, bug #16639 (project freeciv): 2.1) connect to Rudolf (as user1) 2.2) aitoggle Rudolf 2.3) disconnect 2.4) connect as global observer (as user2) Figured it out - simple type '/observe' in the chat and '/aitoggle r' ... Still no error (fourth game to turn 600+) ___ Reply to this item at: http://gna.org/bugs/?16639 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2167] [ai header] gotohand.c
Update of patch #2167 (project freeciv): Status: Ready For Test = Invalid Assigned to:None = syntron Open/Closed:Open = Closed ___ Follow-up Comment #1: invalid after the file was removed ___ Reply to this item at: http://gna.org/patch/?2167 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius
Update of bug #17110 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2221] help text for city radius and build slots
Update of patch #2221 (project freeciv): Assigned to:None = jtn ___ Reply to this item at: http://gna.org/patch/?2221 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2222] Name cleanup for the unit test functions
URL: http://gna.org/patch/? Summary: Name cleanup for the unit test functions Project: Freeciv Submitted by: pepeto Submitted on: samedi 20.11.2010 à 13:26 Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ File Attachments: --- Date: samedi 20.11.2010 à 13:26 Name: 0001-Names-cleanup-in-the-unit-test-functions.patch Size: 32 ko By: pepeto http://gna.org/patch/download.php?file_id=11288 ___ Reply to this item at: http://gna.org/patch/? ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2222] Name cleanup for the unit test functions
Update of patch # (project freeciv): Category: client-gtk-2.0 = general ___ Reply to this item at: http://gna.org/patch/? ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17102] settler units lose red border and cannot build cities
Update of bug #17102 (project freeciv): Category: client = general Status:None = Ready For Test ___ Follow-up Comment #6: Fix attached, but it won't fix the whole problem as the client already disables the command without explanation. However, maybe with new menus, it will be possible. (file #11289) ___ Additional Item Attachment: File name: 0002-City-build-test.patch Size:12 KB ___ Reply to this item at: http://gna.org/bugs/?17102 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17102] settler units lose red border and cannot build cities
Update of bug #17102 (project freeciv): Depends on: = patch # ___ Reply to this item at: http://gna.org/bugs/?17102 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map
Follow-up Comment #1, patch #2218 (project freeciv): Note the _struct tile_data_cache_ pointers are never free-d. You should define _SPECHASH_DATA_FREE_ to _tile_data_cache_destroy()_. ___ Reply to this item at: http://gna.org/patch/?2218 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map
Follow-up Comment #2, patch #2218 (project freeciv): Reading again you should also defined _SPECHASH_DATA_COPY_ to _tile_data_cache_copy()_ to auto duplicate the element when needed. ___ Reply to this item at: http://gna.org/patch/?2218 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology
Update of bug #16971 (project freeciv): Status: Need Info = In Progress Assigned to:None = jtn ___ Follow-up Comment #5: Convert it is, then. I'll concentrate on the strings first for the forthcoming string freeze, but I will rename the concept internally as well. However, I've just realised that renaming transform_to in units.ruleset would technically break the datafile format freeze (task #7229). Since it's a new feature and not used in any of the shipped rulesets (maybe not used anywhere?), would anyone object to my breaking the freeze for this? ___ Reply to this item at: http://gna.org/bugs/?16971 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology
Follow-up Comment #6, bug #16971 (project freeciv): I don't. ___ Reply to this item at: http://gna.org/bugs/?16971 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17109] Map grid color should be white only when option City Outlines is on.
Update of bug #17109 (project freeciv): Category: client-gtk-2.0 = client ___ Follow-up Comment #1: Actually, it also print in red the worked tiles. I doubt this should be related to City Outlines then. ___ Reply to this item at: http://gna.org/bugs/?17109 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17109] Map grid color should be white only when option City Outlines is on.
Update of bug #17109 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?17109 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16971] Resolve 'transform' (terrain) vs 'transform' (units) terminology
Follow-up Comment #7, bug #16971 (project freeciv): Here is the almost-minimal patch that fixes the strings only, but doesn't rename the concept internally. Also fixed a couple of bugs: * One string was not marked as translatable. * In GTK client, the menu item was never greyed out for units incapable of transformation (i.e., most of them) -- it was lost in patch #1315. This would only have added to the confusion :) ** (I didn't notice this before as the Freeciv Gtk theming currently looks awful on my computer -- I haven't reported a bug yet as I haven't worked out whose fault it is.) Also, I notice that only the Gtk client knows about unit transformation/conversion currently. If we are to fix that it'll need doing for the string freeze, so I'll look at that next. (file #11290) ___ Additional Item Attachment: File name: trunk-transform-convert-minimal.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16971 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17105] Global warming ineffective?
Update of bug #17105 (project freeciv): Category:None = rulesets ___ Follow-up Comment #4: Attached a patch which make more terrain transformations. (file #11291) ___ Additional Item Attachment: File name: trunk_S2_3_global_warming_result.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?17105 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client
URL: http://gna.org/bugs/?17112 Summary: Add unit convert order to SDL client Project: Freeciv Submitted by: jtn Submitted on: Saturday 11/20/10 at 15:34 Category: client-sdl Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Bug #13890 added a Transform capability to unit (soon to be renamed Convert under bug #16971), but it seems the SDL client was never updated to add it. The attached patch minimally fixes this (using the new terminology / shortcut). (I haven't tried to draw an icon for conversion, but unit upgrade doesn't have one either.) ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client
Additional Item Attachment, bug #17112 (project freeciv): File name: trunk-sdl-unit-convert.diffSize:2 KB ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client
Update of bug #17112 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7231] S2_3 translatable string freeze
Update of task #7231 (project freeciv): Depends on: = bugs #17112 ___ Reply to this item at: http://gna.org/task/?7231 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client
URL: http://gna.org/bugs/?17113 Summary: Add unit convert order to Xaw client Project: Freeciv Submitted by: jtn Submitted on: Saturday 11/20/10 at 15:55 Category: client-xaw Severity: 1 - Wish Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: I know the Xaw client isn't really supported any more, but it didn't take long to add and test. ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client
Additional Item Attachment, bug #17113 (project freeciv): File name: trunk-xaw-unit-convert.diffSize:3 KB ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7231] S2_3 translatable string freeze
Update of task #7231 (project freeciv): Depends on: = bugs #17113 ___ Reply to this item at: http://gna.org/task/?7231 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17091] cleanup saving old savegame format
Update of bug #17091 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17091 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16639] fix assert in dbv_isset() at server exit
Follow-up Comment #9, bug #16639 (project freeciv): sorry; I can't reproduce the assert. Could you run freeciv with the option -F and send a backtrace? ___ Reply to this item at: http://gna.org/bugs/?16639 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16971] Rename 'transform' to 'convert' for units, and add help
Update of bug #16971 (project freeciv): Status: In Progress = Ready For Test Summary: Resolve 'transform' (terrain) vs 'transform' (units) terminology = Rename 'transform' to 'convert' for units, and add help ___ Follow-up Comment #8: Finished version attached. This renames the concept through the source, including in the datafile format (as previously mentioned) and in packets.def (but it's still wire-compatible so doesn't break the freeze). Also: * Added autogenerated help for unit types involved in conversions. * In the Gtk client, display the destination unit in the menu item where possible (similar to bug #15611). (file #11294) ___ Additional Item Attachment: File name: trunk-transform-convert.diff Size:19 KB ___ Reply to this item at: http://gna.org/bugs/?16971 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client
Additional Item Attachment, bug #17112 (project freeciv): File name: trunk-sdl-unit-convert-bis.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client
Additional Item Attachment, bug #17113 (project freeciv): File name: trunk-xaw-unit-convert-bis.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17113] Add unit convert order to Xaw client
Update of bug #17113 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/bugs/?17113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17112] Add unit convert order to SDL client
Update of bug #17112 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/bugs/?17112 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2217] [autosettler] dynamically allocate citymap in struct cityresult
Update of patch #2217 (project freeciv): Summary: [autosettler] dynamically allocate struct cityresult = [autosettler] dynamically allocate citymap in struct cityresult ___ Follow-up Comment #1: move reserved information into the tile data cache (file #11297) ___ Additional Item Attachment: File name: 20101120-07-trunk-autosettler-dynamically-allocate-citymap-in-struct-c.patch Size:13 KB ___ Reply to this item at: http://gna.org/patch/?2217 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map
Follow-up Comment #3, patch #2218 (project freeciv): I did rewrote the entire patch. Now also the tile data in the city result is saved using a hash. tile_data_hash_copy() and tile_data_hash_destroy() are defined and used. changes 20101120: * use spechash.h for settler map and cityresult * print cache results (file #11298) ___ Additional Item Attachment: File name: 20101120-08-trunk-autosettler-use-a-hash-for-plr-ai-settler_map.patch Size:26 KB ___ Reply to this item at: http://gna.org/patch/?2218 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius
Update of bug #17110 (project freeciv): Status:None = Ready For Test Assigned to:None = syntron Planned Release: = 2.4.0 ___ Follow-up Comment #2: Here is a patch for 2.4.0 configure the city images via the effects system * [TODO] wiki = effect EFT_CITY_IMAGES * [TODO] wiki = How to tilesets 2.3.x = 2.4.x * [TODO] what spec should be defined for 2.4.x tilesets? (file #11299) ___ Additional Item Attachment: File name: 20101120-trunk-configure-the-city-images-via-the-effects-system.patch Size:42 KB ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius
Follow-up Comment #3, bug #17110 (project freeciv): You could simply change the number at the end of the description tag (city.electricage_city_4 = city.electricage_city_3). The city radius, except for the first step, is changed by other things than just size so this won't work. But I see you have already wrote a patch to make city images an effect too. One thing though: +; The maximum number of images is only limited by the maximum size of a city +; (currently MAX_CITY_SIZE = 250). The constant is defined in common/city.h. With images being an rffect it makes no sense to limit the number of image by the size of a city. They are really independent. MfG Goswin ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius
Follow-up Comment #4, bug #17110 (project freeciv): With images being an rffect it makes no sense to limit the number of image by the size of a city. They are really independent. That's right - but a limit is needed. And I don't think that there will be much more images than the current 4 for each city style ... ___ Reply to this item at: http://gna.org/bugs/?17110 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17105] Global warming ineffective?
Update of bug #17105 (project freeciv): Status:None = Ready For Test Assigned to:None = dmarks Planned Release: = 2.3.0 ___ Follow-up Comment #5: Good idea. Here's my take - these rules will potentially turn lowlands into ocean. (file #11301) ___ Additional Item Attachment: File name: trunk-s2_3-global_warming_effects.diff Size:14 KB ___ Reply to this item at: http://gna.org/bugs/?17105 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2180] Polish ruleset update
Update of patch #2180 (project freeciv): Status: Need Info = Ready For Test Assigned to:None = dmarks Planned Release: = 2.3.0, 2.4.0 ___ Follow-up Comment #3: Patch against S2_3/trunk. Note that cities that are not within the country's current borders cannot be used in nationsets that are listed as Modern. See policy document in doc/README.nations (file #11302) ___ Additional Item Attachment: File name: trunk-s2_3-additions_to_polish_nation.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2221] help text for city radius and build slots
Follow-up Comment #1, patch #2221 (project freeciv):
Thanks for the explanation. I've mucked around with this a fair bit:
* Moved inline to the relevant sections of the existing help;
* Added description of interaction of build slots with worklists (since this
was fairly carefully designed in patch #1234, it seems); in fact I've added a
description of how worklists work in general, which was missing;
* Remove the details which are more of relevance to ruleset authors.
I was uncomfortable with requiring people to understand/remember what the
punctuation means when city production is described as Warriors
(134/[5*10]) or Settlers (134/{1*40}); the square-vs-angle-brackets is
particularly obscure. I've thus made the following changes to clients, so
that it's no longer necessary to understand the meaning of the bracketing
(although it's still there for experienced users):
* Add a build slots column to the city report;
* In the Gtk client, state the number of build slots on the Production tab of
the city dialog (if it's more than 1).
These should give enough information to know if you're using all the build
slots, which is what the bracketing tells you ([] means you are, {} means
you're not). (I'm assuming that the 5*10 bit is obvious enough once you've
read the description in the help.)
(file #11303)
___
Additional Item Attachment:
File name: trunk-help-cityradii-buildslots-bis.diff Size:9 KB
___
Reply to this item at:
http://gna.org/patch/?2221
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2221] help text for city radius and build slots
Follow-up Comment #2, patch #2221 (project freeciv):
(that should be Warriors (134/[5*10]) or Settlers (134/{1*40}) ,
hopefully. And I meant braces, not angle brackets. But apart from that...)
___
Reply to this item at:
http://gna.org/patch/?2221
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate
URL: http://gna.org/patch/?2223 Summary: Display destination type of unit upgrade in menu, and grey out menu entry as appropriate Project: Freeciv Submitted by: jtn Submitted on: Sunday 11/21/10 at 01:09 Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0,2.4.0 ___ Details: $SUBJECT -- enhance the UI for unit upgrades in the Gtk client a little. ___ Reply to this item at: http://gna.org/patch/?2223 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate
Update of patch #2223 (project freeciv): Depends on: = bugs #16971 ___ Reply to this item at: http://gna.org/patch/?2223 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2223] Display destination type of unit upgrade in menu, and grey out menu entry as appropriate
Additional Item Attachment, patch #2223 (project freeciv): File name: trunk-gtk-upgrade-menu.diffSize:4 KB ___ Reply to this item at: http://gna.org/patch/?2223 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2218] [autosettler] use a hash for plr-ai-settler_map
Follow-up Comment #4, patch #2218 (project freeciv): There are still losses of memory. When calling _tile_data_cache_hash_replace(key, data)_, then data will be duplicated inside (because _SPECHASH_DATA_COPY_ has been defined). So you need to free the pointer after that. So, there are 2 solutions: * You still define _SPECHASH_DATA_COPY_ and pass a built-in structure to _tile_data_cache_hash_replace()_ which will be duplicated internally. * Then, you remove the definition of _SPECHASH_DATA_COPY_. Then, the pointer you passed to _tile_data_cache_hash_replace()_ will be returned with _tile_data_cache_hash_lookup()_. ___ Reply to this item at: http://gna.org/patch/?2218 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17116] Citizens roles become unrecognisable in large cities
URL: http://gna.org/bugs/?17116 Summary: Citizens roles become unrecognisable in large cities Project: Freeciv Submitted by: mrvn Submitted on: Sunday 11/21/2010 at 01:49 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: svn trunk Discussion Lock: Any Operating System: None Planned Release: ___ Details: When a city grows the icons for each citizen in the city display begin to overlap and become harder and harder to deciver. Maybe at a certain size it should show a single icon per role followed by the number of citizens in that role instead of showing each citizen. ___ Reply to this item at: http://gna.org/bugs/?17116 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2224] Help system entry for nation legends
URL: http://gna.org/patch/?2224 Summary: Help system entry for nation legends Project: Freeciv Submitted by: dmarks Submitted on: Sunday 11/21/2010 at 11:50 Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Patch for adding a 'Nations' entry to the client help system. It contains the legends for each nation. By Egor Vyscrebentsov and myself, originally at http://rt.freeciv.org/Ticket/Display.html?id=35961 It is from 2007 and does no longer apply cleanly to a recent trunk or S2_3. ___ File Attachments: --- Date: Sunday 11/21/2010 at 11:50 Name: nations_help-trunk.diff Size: 9kB By: dmarks http://gna.org/patch/download.php?file_id=11306 ___ Reply to this item at: http://gna.org/patch/?2224 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2224] Help system entry for nation legends
Update of patch #2224 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: First try to getting patch up to date. It seems that the interface to look up a nation has changed over the last three years: 'find_nation_by_name()' does not exist anymore. Does anyone know how to do this these days? (file #11307) ___ Additional Item Attachment: File name: s2_3-nations_in_helpsystem.diff Size:9 KB ___ Reply to this item at: http://gna.org/patch/?2224 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
