[Freeciv-Dev] [bug #17197] Ungrammatical message when game ends

2010-12-03 Thread Daniel Markstedt

Update of bug #17197 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.3.0-beta2, 2.4.0 

___

Additional Item Attachment:

File name: trunk-s2_3-turn_limit_exceeded_string.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2224] Help system entry for nation legends

2010-12-03 Thread Daniel Markstedt

Update of patch #2224 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17166] City productions map display off by default

2010-12-03 Thread Daniel Markstedt

Update of bug #17166 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17215] Fixed-width tables look bad with multibyte character encodings

2010-12-03 Thread Jacob Nevins

URL:
  

 Summary: Fixed-width tables look bad with multibyte
character encodings
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Dec  4 01:39:26 2010
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There are a few places where tables of data are displayed in a fixed-width
typeface, relying on spacing for alignment. These don't work when using a
multibyte character encoding (such as UTF-8) in a locale that uses the
multibyte characters.

The examples I've noticed are the autogenerated help for terrain alterations
(client/helpdata.c:insert_generated_table()) and the spaceship report
(client/text.c:get_spaceship_descr()).

One place that does get this right is the demographics report. This uses
get_internal_string_length() to calculate the display length of strings, and
pads appropriately. The same approach would probably work for the others.

(In most of these places it would be better to move away from text tables,
but that's a chunk of work; fixing this will be easier.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17166] City productions map display off by default

2010-12-03 Thread Daniel Markstedt

Update of bug #17166 (project freeciv):

 Planned Release: 2.2.4, 2.3.0, 2.4.0 => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17214] Amplio2 unit sprites overstepping grid boundaries

2010-12-03 Thread Jacob Nevins

Update of bug #17214 (project freeciv):

 Summary: Amplio2 unit sprites overstepping their boundaries
=> Amplio2 unit sprites overstepping grid boundaries


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17214] Amplio2 unit sprites overstepping their boundaries

2010-12-03 Thread Jacob Nevins

URL:
  

 Summary: Amplio2 unit sprites overstepping their boundaries
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Dec  4 01:09:52 2010
Category: art
Severity: 2 - Minor
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

The glitches I fixed in Amplio in bug #15777 also apply to the Amplio2
tileset.

Since Amplio2's units.png is identical to Amplio's pre bug #15777, I intend
to just copy my units.png over the Amplio2 one.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1962] Expand the commentary for RESULT_IS_ENOUGH

2010-12-03 Thread Jacob Nevins

Update of patch #1962 (project freeciv):

 Summary: Expand the commentary for RESULT_IS_KNOWN => Expand
the commentary for RESULT_IS_ENOUGH


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17193] in unquote_block() [savegame2.c::990]: assertion '1 == parsed' failed

2010-12-03 Thread Jacob Nevins

Follow-up Comment #3, bug #17193 (project freeciv):

Here's a backtrace, if it helps. (S2_3 r18648)

#0  0x7fc5c8795a75 in raise () from /lib/libc.so.6
No symbol table info available.
#1  0x0058382f in fc_assert_fail (file=0x5e23e0 "savegame2.c", 
function=0x5e4f5a "unquote_block", line=976, 
assertion=, message=0x0) at log.c:476
level = LOG_FATAL
#2  0x0049f88c in unquote_block (loading=, 
plr=0x2422ab0) at savegame2.c:976
i = 
length = 
tmp = 
quoted = 
endptr = 
parsed = false
#3  sg_load_player_attributes (loading=, plr=0x2422ab0)
at savegame2.c:4599
quoted_length = 2110
quoted = 0x23e5680 "702:00 00 00 00 02 00 00 00 0e 00 00 02 be 00 00
00 1d 05 f5 e1 01 00 00 01 57 ff ff ff ff 02 00 00 00 01 00 00 00 01 00 00 00
01 00 00 00 01 00 00 00 01 00 00 00 01 00 01 00 00 00 00 00 1d 05 f5 e1 0"...
part_nr = 3
parts = 3
plrno = 0
__FUNCTION__ = "sg_load_player_attributes"
#4  0x004a15e4 in sg_load_players (loading=0x1dbac10)
at savegame2.c:2886
pplayer = 0x2422ab0
_pslot = 
__FUNCTION__ = "sg_load_players"
#5  0x004a3bc4 in savegame2_load_real (file=)
at savegame2.c:600
loading = 
was_send_city_suppressed = 
was_send_tile_suppressed = false
#6  savegame2_load (file=) at savegame2.c:528
savefile_options = 
__FUNCTION__ = "savegame2_load"
loadtimer = 0x1dbabd0
#7  0x00413ffa in load_command (caller=, 
filename=, check=)
at stdinhand.c:3545
loadtimer = 0x1dbab50
uloadtimer = 0x1dbab90
file = 
arg = "/home/jtn/.freeciv/saves/freeciv-T0115-Y00300-manual.sav.bz2",
' 00' ,
"8205\311305177 00 00/ 00 00 00 00 00 00 00U226=311305177 00 00 00 00 00 00 00 
00 00 00270211\311305177 00 00 20",
' 00' , " 01", ' 00' "240,
u217Q377177 00 00 60v217Q377177 00 00 00200\311305177 00 00 01", ' 00'
"305,
K=311305177 00 00 00 00 00 00 00 00 00 00215326=311305177 00 00 00 00 00 00 00 
00 00 00i270 61310305177 00 00 00 00 00 00 00 00 00 00232g=311305177",
' 00' "341"...
__FUNCTION__ = "load_command"
#8  0x0040c3b1 in srv_prepare () at srv_main.c:2246
__FUNCTION__ = "srv_prepare"
#9  0x0040c4c4 in srv_main () at srv_main.c:2516
__FUNCTION__ = "srv_main"
#10 0x00404137 in main (argc=, 
argv=0x7fff518f8578) at civserver.c:375
inx = 4
showhelp = false
showvers = false
option = 0x1918970
"/usr/local/share/locale/en_GB.UTF-8.utf8/LC_MESSAGES/freeciv.mo"
__FUNCTION__ = "main"


I also notice that upon connecting to a server which has failed this
assertion and starting the game, the client says:

2: Old attributes detected and removed.

Dunno if that's related.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17194] in sg_load_player_attributes() [savegame2.c::4616]: assertion 'actual_length == plr->attribute_block.length' failed

2010-12-03 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #17194 (project freeciv):

This one is a result of the assert failing in bug #17193 (actual_length is
set to 0)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17193] in unquote_block() [savegame2.c::990]: assertion '1 == parsed' failed

2010-12-03 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #17193 (project freeciv):

I do not see this error (but at the moment I can't compile on my 64bit pc as
it seems to crash if I do something freeciv related on it). It should also be
visible for S2_2 as the corresponding function (unquote_block()) is identical
for S2_2 and S2_3/trunk.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17201] Civil war rebels have no capital city

2010-12-03 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #17201 (project freeciv):

will there be a 2.1.x / 2.0.x version? this bug is also valid for this
versions (and even most 1.x versions)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17201] Civil war rebels have no capital city

2010-12-03 Thread Matthias Pfafferodt

Update of bug #17201 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => syntron
 Planned Release: => 2.2.4,2.3.0,2.4.0  

___

Follow-up Comment #1:

allow auto palace (capital) for the new player after a civil war

since before 2002 (adapted unmodified in svn4148/svn17560)

(file #11455)
___

Additional Item Attachment:

File name:
20101203-trunk-allow-auto-palace-capital-for-the-new-player-after-a.patch
Size:1 KB


___

Reply to this item at:

  <http://gna.org/bugs/?17201>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15410] Freeciv does not compile with --enable-debug=yes and GCC 4.2.4

2010-12-03 Thread Jordi Negrevernis i Font

Follow-up Comment #16, bug #15410 (project freeciv):

Yes, it is persistent...

But I resolved the problem with:

CFLAGS="-Wno-strict-alias" ./configure

Thanks


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1962] Expand the commentary for RESULT_IS_KNOWN

2010-12-03 Thread Matthias Pfafferodt

Update of patch #1962 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.4.0  


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1968] add players_iterate_alive()

2010-12-03 Thread Matthias Pfafferodt

Update of patch #1968 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.4.0  

___

Follow-up Comment #2:

updated patch:

add players_iterate_alive()

* update iteration macro to use players_iterate(_end)
* check for more possible users

Please check the logic ...

(file #11454)
___

Additional Item Attachment:

File name: 20101203-trunk-add-players_iterate_alive.patch Size:31 KB


___

Reply to this item at:

  <http://gna.org/patch/?1968>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17158] in dbv_init() [bitvector.c::54]: assertion 'pdbv->vec == ((void *)0)' failed.

2010-12-03 Thread Matthias Pfafferodt

Update of bug #17158 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17132] in tile_change_terrain() [tile.c::503]: assertion 'can_unit_exist_at_tile(punit, ptile)' failed.

2010-12-03 Thread Matthias Pfafferodt

Update of bug #17132 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17139] use tile_virtual_*() for virtual tile functions

2010-12-03 Thread Matthias Pfafferodt

Update of bug #17139 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17001] src-check

2010-12-03 Thread Matthias Pfafferodt

Update of bug #17001 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev