[Freeciv-Dev] [patch #1662] use specenum_gen for enum unit_flag_id / unit_role_id
Follow-up Comment #2, patch #1662 (project freeciv): where is the patch? ___ Reply to this item at: http://gna.org/patch/?1662 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17711] ai_auto_settler_init() causes immediate assert failure when server starts
Update of bug #17711 (project freeciv): Status:None = Ready For Test Assigned to:None = syntron Planned Release: = 2.4.0 ___ Follow-up Comment #2: fix auto settler changes * move auto_settler_init() and auto_settler_free() to ai_data_init() and ai_data_close() * no dependencies to ai-phase_initialized and adv-phase_initialized * reset auto settler state after each run (aicity.c and autosettler.c) see gna bug #17711 fixes gna patch #2219 reported by Marko Lindqvist cazfi (file #12406) ___ Additional Item Attachment: File name: 20110212-fix-auto-settler-changes.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?17711 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2390] ai_best_government() - adv_best_government()
Update of patch #2390 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2390 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2417] Stub of threaded ai module
Update of patch #2417 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2417 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2521] [metaticket] Generic road code
URL: http://gna.org/patch/?2521 Summary: [metaticket] Generic road code Project: Freeciv Submitted by: cazfi Submitted on: Sat 12 Feb 2011 01:48:08 PM EET Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: I'll start miniproject of making Road/Railroad/whatever handling a bit more generic. Note a bit -part. I don't consider it worth the cost to have unlimited number of road types etc. (that is, road generalization will not go as far as military base generalization did) At the moment I think we can have hardcoded limit of three road types (one more than current system has) and anyway that limit is easy to increase once code is generalized for the case of limit of three. Optimistically setting Planned Release to 2.4.0. ___ Reply to this item at: http://gna.org/patch/?2521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Hoover dam
Works as if you had a Hydro Planthttp://freeciv.wikia.com/wiki/Buildings#Hydro_Plantin every city. (This reduces pollution and increases the effects of Factories and Mfg. Plants.) -- http://freeciv.wikia.com/wiki/Wonders_catalog I built Hoover dam in one city. I am still able to build a Hydro Plant in that city and other cities. Am I missing something? Cheers, Shaun ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Hoover dam
On 12 February 2011 14:10, Shaun Savani savani1...@gmail.com wrote: Works as if you had a Hydro Plant in every city. (This reduces pollution and increases the effects of Factories and Mfg. Plants.) -- http://freeciv.wikia.com/wiki/Wonders_catalog I built Hoover dam in one city. I am still able to build a Hydro Plant in that city and other cities. Am I missing something? Well, maybe that particular city should be special cased so that you cannot build Hydro Plant there. Reason you are generally able to build Hydro Plants is that it allows you to prepare to the loss of Hoover Dam if at some point losing that city is just matter of time. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17710] tile-worked more than init_city_radius away not zeroed for enemy cities
Follow-up Comment #2, bug #17710 (project freeciv): 1. Send radius_sq information to client about enemy cities. S2_3 version of the patch uses optional network capability for this. 2. Since even with 1 implemented it is possible that while we don't see the city, its city radius grows and it starts working tile we do see, detect that situation and just grow radius_sq variable in client end. Now I wonder if 1 can actually cause problems and should we rely on 2 only. Server might send short city info packet with radius information from the time city was last seen after client has already seen tile worked outside that radius. In that case more correct value client has would be replaced with too small value from short city info packet. Downside of relying to 2 only is that client side radius information would never decrease. Err, it's also not clear what would happen when tile information was sent before city was seen (so that client has created invisible city first). I need to rethink this once more... ___ Reply to this item at: http://gna.org/bugs/?17710 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1662] use specenum_gen for enum unit_flag_id / unit_role_id
Follow-up Comment #3, patch #1662 (project freeciv): What is the big advantage of having these as specenum? There's several downsides, and with ruleset defined flags you get no advantage of being able to use _by_name() for instance. ___ Reply to this item at: http://gna.org/patch/?1662 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2509] Doxygen configuration
Update of patch #2509 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2509 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1662] use specenum_gen for enum unit_flag_id / unit_role_id
Update of patch #1662 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #4: Ups, that's why there were no comments ;-) I did find the old patch and rebased it to trunk (a lot of changes!). I hope all changes/renames are correct. Please test! use specenum_gen for enum unit_flag_id and enum unit_role_id * rework handling of unit properties * cleanup role/flag/uflag usage in function names * unit_props: roles + flags + user flags * changed network protocol (file #12407) ___ Additional Item Attachment: File name: 20110212-use-specenum_gen-for-enum-unit_flag_id-and-enum-unit.patch Size:106 KB ___ Reply to this item at: http://gna.org/patch/?1662 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1662] use specenum_gen for enum unit_flag_id / unit_role_id
Follow-up Comment #5, patch #1662 (project freeciv): What is the big advantage of having these as specenum? There's several downsides, and with ruleset defined flags you get no advantage of being able to use _by_name() for instance. IMO, specenums allow a clearer definition of the variable as well as of the name. In this case it is ahrd as the two enums as well as the user flags are interconnected. I think that the presented solution, especially with the different function, provide a clean way to handle this values. ___ Reply to this item at: http://gna.org/patch/?1662 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2521] [metaticket] Generic road code
Update of patch #2521 (project freeciv): Depends on: = patch #2522 ___ Reply to this item at: http://gna.org/patch/?2521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2523] savegame2: remove compat_load/save_020300() functions
URL: http://gna.org/patch/?2523 Summary: savegame2: remove compat_load/save_020300() functions Project: Freeciv Submitted by: jtn Submitted on: Sat Feb 12 20:07:21 2011 Category: None Priority: 3 - Low Status: Ready For Test Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0,2.4.0 ___ Details: As discussed in bug #17678 (comment 1 http://gna.org/bugs/?17678#comment1), these functions are not used (in fact, the way sg_load/save_compat() are written, they will never be called), so they may as well be removed. Also expand the comments in savegame2.c to reflect my understanding of the backward compatibility arrangements. ___ Reply to this item at: http://gna.org/patch/?2523 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2523] savegame2: remove compat_load/save_020300() functions
Additional Item Attachment, patch #2523 (project freeciv): File name: trunk-savegame2-rm-compat-020300.diff Size:7 KB File name: S2_3-savegame2-rm-compat-020300.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2523 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17678] Warnings about wonders (etc) when loading S2_3 experimental savegame in trunk
Follow-up Comment #4, bug #17678 (project freeciv): I keep this ticket open as there were more problems. please report if some of them are still valid ... I think you've fixed all the relevant ones in the savegame I was having trouble with, thanks. I think you can close this ticket. (Off-topic but: have I missed the point of sg_load/save_compat()? The naming should be read as: compat_load_020400() - load pre 2.4.0 savegame compat_save_020400() - save pre 2.4.0 savegame Ah, my mistake, sorry -- I read the comments and not the actual code. It makes sense to me now. So perhaps the functions should be renamed and the original 2.3 version can be removed (set to NULL in the compat array). I'm for keeping the names the same (if we ever invent compat_..._020301(), say, then all the functionality currently in compat_..._020400() will need to stay in the same function -- let's say the name means translate data between *previous* and _020400). I've submitted patch #2523 which removes the _020300() functions and attempts to explain the backward compatibility strategy in comments (hopefully I've got it right this time...) ___ Reply to this item at: http://gna.org/bugs/?17678 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17678] Warnings about wonders (etc) when loading S2_3 experimental savegame in trunk
Update of bug #17678 (project freeciv): Status: Need Info = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #5: Ah, my mistake, sorry -- I read the comments and not the actual code. It makes sense to me now. This means that my comments there not good enough - thank you for cleaning it up. I did read patch #2523 and it explains it nicely! ___ Reply to this item at: http://gna.org/bugs/?17678 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2523] savegame2: remove compat_load/save_020300() functions
Follow-up Comment #1, patch #2523 (project freeciv): The changed texts are correct from my point of view. Ready for commit ;-) ___ Reply to this item at: http://gna.org/patch/?2523 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2460] Qt-client pages
Update of patch #2460 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2460 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17669] assert(adv-phase_is_initialized) fails on savegame load
Update of bug #17669 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17669 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2489] Clear output window (and free its resources) on exit
Update of patch #2489 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: Gtk-client-specific fix for problem seen in gtk-client only. (file #12413) ___ Additional Item Attachment: File name: FreeGtkMBOnExit_2489.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2489 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17714] Number of (land) tiles per player option doesn't work properly
URL: http://gna.org/bugs/?17714 Summary: Number of (land) tiles per player option doesn't work properly Project: Freeciv Submitted by: master Submitted on: Sat 12 Feb 2011 09:58:48 PM GMT Category: general Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.x Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Well this option doesn't work properly... How you can see in my two images that i attached I set 115 tiles per player, but the generator only gave 56 for each player :( ___ File Attachments: --- Date: Sat 12 Feb 2011 09:58:49 PM GMT Name: Bug freeciv island generator doesn't work.jpg Size: 338kB By: master http://gna.org/bugs/download.php?file_id=12414 --- Date: Sat 12 Feb 2011 09:58:49 PM GMT Name: Bug freeciv island generator doesn't work1.jpg Size: 378kB By: master http://gna.org/bugs/download.php?file_id=12415 ___ Reply to this item at: http://gna.org/bugs/?17714 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17672] /set rare X, /set situational X etc crash server
Follow-up Comment #5, bug #17672 (project freeciv): (Also, I don't think S2_3 is in string freeze? On that assumption, my trunk patch is also applicable to S2_3.) I'm not sure about the status wrt the release of 2.3.0. So I prepeared a 'save' patch ... ___ Reply to this item at: http://gna.org/bugs/?17672 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17717] Xaw-client asks to verify password when cannot connect server
URL: http://gna.org/bugs/?17717 Summary: Xaw-client asks to verify password when cannot connect server Project: Freeciv Submitted by: cazfi Submitted on: Sun 13 Feb 2011 12:58:20 AM EET Category: client-xaw Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: With TRUNK Xaw-client I tried to connect to port where was no server. To my surprise client considered this no server situation as server requires authentication and asked me to verify password. ___ Reply to this item at: http://gna.org/bugs/?17717 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17716] SDL-client blend_surface() does not free mask.
Update of bug #17716 (project freeciv): Planned Release:2.3.0, 2.4.0 = 2.2.5, 2.3.0, 2.4.0 ___ Follow-up Comment #1: Same leak present in S2_2 and patch applies without changes. Counting together various valgrind reports this bug is reason for, about 100MB was leaked because of it in relatively short game. ___ Reply to this item at: http://gna.org/bugs/?17716 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17714] Number of (land) tiles per player option doesn't work properly
Update of bug #17714 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: It does generate a map with x land tiles per player - it is _not_ related to the size of the iland there you start. Perhaps this has to be written in the help text? ___ Reply to this item at: http://gna.org/bugs/?17714 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17718] Mapcanvas not freed
URL: http://gna.org/bugs/?17718 Summary: Mapcanvas not freed Project: Freeciv Submitted by: cazfi Submitted on: Sun 13 Feb 2011 01:02:05 AM EET Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0, 2.4.0 ___ Details: As valgrind puts it: ==13818== 1,290,240 bytes in 1 blocks are still reachable in loss record 667 of 680 ==13818==at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==13818==by 0x7E92F35: SDL_CreateRGBSurface (in /usr/lib/libSDL-1.2.so.0.11.3) ==13818==by 0x495339: create_surf_with_format (graphics.c:333) ==13818==by 0x46AB5A: canvas_create (canvas.c:47) ==13818==by 0x42A511: map_canvas_resized (mapview_common.c:2921) ==13818==by 0x407FC5: overview_size_changed (mapview.c:367) ==13818==by 0x42D0BE: calculate_overview_dimensions (overview_common.c:464) ==13818==by 0x4338B4: handle_map_info (packhand.c:1592) ==13818==by 0x435DE1: client_handle_packet (packhand_gen.c:63) ==13818==by 0x40C09D: client_packet_input (client_main.c:566) ==13818==by 0x411384: input_from_server (clinet.c:417) ==13818==by 0x405E03: gui_event_loop (gui_main.c:694) ==13818==by 0x406211: ui_main (gui_main.c:1057) ==13818==by 0x40C529: client_main (client_main.c:509) ==13818==by 0x83C4C4C: (below main) (libc-start.c:228) and similar report for creation of _tmp canvas. Attached patches should fix this. Difference between TRUNK and S2_3 versions is that in TRUNK version also Qt-client is fixed (S2_3 fixes gtk, sdl and xaw clients). ___ File Attachments: --- Date: Sun 13 Feb 2011 01:02:05 AM EET Name: FreeMapcanvas.diff Size: 3kB By: cazfi http://gna.org/bugs/download.php?file_id=12417 --- Date: Sun 13 Feb 2011 01:02:05 AM EET Name: FreeMapcanvas-S2_3.diff Size: 3kB By: cazfi http://gna.org/bugs/download.php?file_id=12418 ___ Reply to this item at: http://gna.org/bugs/?17718 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1662] use specenum_gen for enum unit_flag_id / unit_role_id
Follow-up Comment #6, patch #1662 (project freeciv): rewritten patch - do not try to merge both enums but do only a cleanup; no network changes! (file #12419) ___ Additional Item Attachment: File name: 20110212-use-specenum_gen-for-enum-unit_flag_id-and-enum-unit.patch Size:86 KB ___ Reply to this item at: http://gna.org/patch/?1662 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17714] Number of (land) tiles per player option doesn't work properly
Follow-up Comment #2, bug #17714 (project freeciv): Well i think it should be like i said, in fact the function is confusing. and in all case in the second image you can see i set only 100 tiles and i got a huge island bigger than 100 tiles. ___ Reply to this item at: http://gna.org/bugs/?17714 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2491] Large flagset in Amplio2
Update of patch #2491 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2491 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17714] Number of (land) tiles per player option doesn't work properly
Follow-up Comment #3, bug #17714 (project freeciv): and in all case in the second image you can see i set only 100 tiles and i got a huge island bigger than 100 tiles. In file #12415, the mapsize option (Map size definition) is set to Number of tiles, so value of the tiles per player option will be ignored in favour of Map size (in thousands of tiles). ___ Reply to this item at: http://gna.org/bugs/?17714 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2491] Large flagset in Amplio2
Follow-up Comment #1, patch #2491 (project freeciv): (Committed to trunk as r19318 http://svn.gna.org/viewcvs/freeciv?view=revrevision=19318.) Any reason not to do this on S2_3 as well? We are distributing the large flags in 2.3.x, we may as well use them... ___ Reply to this item at: http://gna.org/patch/?2491 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17705] helpdata text for EFT_FORCE_CONTENT should have singular/plural
Update of bug #17705 (project freeciv): Category:None = client Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.2.5,2.3.0,2.4.0 ___ Follow-up Comment #1: Patch attached for this and EFT_MAKE_CONTENT. There are many similar examples nearby, but since PL_ introduces fuzzies and I'm not entirely sure of the necessity, I've resisted the urge to do a wholesale cleanup. (file #12420) ___ Additional Item Attachment: File name: trunk-S2_3-S2_2-eft-content-i18n-pl.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17705 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17706] Better translatability for strings containing and-lists.
Follow-up Comment #1, bug #17706 (project freeciv): Hm. Would it be an abuse of PL_() to pass in the length of the list, if there's a TRANS comment explaining it? ___ Reply to this item at: http://gna.org/bugs/?17706 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2491] Large flagset in Amplio2
Follow-up Comment #2, patch #2491 (project freeciv): Oh, my mistake, you already did that in r19319 http://svn.gna.org/viewcvs/freeciv?view=revrevision=19319... never mind. ___ Reply to this item at: http://gna.org/patch/?2491 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17719] Terrain sprites created by cropping not freed
URL: http://gna.org/bugs/?17719 Summary: Terrain sprites created by cropping not freed Project: Freeciv Submitted by: cazfi Submitted on: Sun 13 Feb 2011 02:36:59 AM EET Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.5, 2.3.0, 2.4.0 ___ Details: Valgrind says: ==13818== 967,680 bytes in 210 blocks are indirectly lost in loss record 663 of 680 ==13818==at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==13818==by 0x7E92F35: SDL_CreateRGBSurface (in /usr/lib/libSDL-1.2.so.0.11.3) ==13818==by 0x7E930C6: SDL_ConvertSurface (in /usr/lib/libSDL-1.2.so.0.11.3) ==13818==by 0x7E94F9C: SDL_DisplayFormatAlpha (in /usr/lib/libSDL-1.2.so.0.11.3) ==13818==by 0x495044: mask_surface (graphics.c:222) ==13818==by 0x4A56AF: crop_sprite (sprite.c:108) ==13818==by 0x44B93F: tileset_setup_tile_type (tilespec.c:3085) ==13818==by 0x435A04: client_handle_packet (packhand_gen.c:304) ==13818==by 0x40C09D: client_packet_input (client_main.c:566) ==13818==by 0x411384: input_from_server (clinet.c:417) ==13818==by 0x405E03: gui_event_loop (gui_main.c:694) ==13818==by 0x406211: ui_main (gui_main.c:1057) ==13818==by 0x40C529: client_main (client_main.c:509) ==13818==by 0x83C4C4C: (below main) (libc-start.c:228) While this raport is from running SDL-client, root problem is in client common code and affects all clients. This is memory leak when switching tileset or quitting program. Most tileset sprites are put to hash by load_sprite() and everything from hash is freed by unload_all_sprites(). These problematic sprites however are not got directly from load_sprite(), but they are created with crop_sprite() from one. Fix attached ___ File Attachments: --- Date: Sun 13 Feb 2011 02:36:59 AM EET Name: FreeCroppedTerSprites.diff Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=12421 --- Date: Sun 13 Feb 2011 02:36:59 AM EET Name: FreeCroppedTerSprites-S2_2.diff Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=12422 ___ Reply to this item at: http://gna.org/bugs/?17719 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2524] Client 'city bar' terminology
URL: http://gna.org/patch/?2524 Summary: Client 'city bar' terminology Project: Freeciv Submitted by: dmarks Submitted on: Sat 12 Feb 2011 04:55:36 PM PST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0, 2.4.0 ___ Details: To call it 'city bar' instead of 'citybar'. ___ File Attachments: --- Date: Sat 12 Feb 2011 04:55:36 PM PST Name: trunk-s2_3-city_bar_term.diff Size: 841B By: dmarks http://gna.org/patch/download.php?file_id=12423 ___ Reply to this item at: http://gna.org/patch/?2524 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2525] Wider Amplio2 occupied sprite
URL: http://gna.org/patch/?2525 Summary: Wider Amplio2 occupied sprite Project: Freeciv Submitted by: dmarks Submitted on: Sat 12 Feb 2011 04:59:48 PM PST Category: art Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0, 2.4.0 ___ Details: To make Amplio2's occupied city sprite wider to match the larger flags introduced in patch #2491 ___ File Attachments: --- Date: Sat 12 Feb 2011 04:59:48 PM PST Name: moderncities.png Size: 97kB By: dmarks http://gna.org/patch/download.php?file_id=12424 ___ Reply to this item at: http://gna.org/patch/?2525 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17705] helpdata text for EFT_FORCE_CONTENT should have singular/plural
Follow-up Comment #2, bug #17705 (project freeciv): PL_ introduces fuzzies It might be better not to include this in S2_2 at all. Finnish translation will still be in bad shape anyway when we release 2.2.5, and if this patch is not needed by any other actively supported (=one that would actually use it) language, there's no point in introducing fuzzies to all languages. ___ Reply to this item at: http://gna.org/bugs/?17705 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17698] S2_3 ai settler code doesn't free all memory
Update of bug #17698 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
