date:20110218

[Freeciv-Dev] [patch #2528] GTK_CFLAGS -> GTK2_CFLAGS

2011-02-18 Thread Marko Lindqvist


Update of patch #2528 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2510] adv_wants_science()

2011-02-18 Thread Marko Lindqvist


Update of patch #2510 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17760] Zoom

2011-02-18 Thread Jacob Nevins


Follow-up Comment #1, bug #17760 (project freeciv):

I assume we're talking about zooming the main map area here? Presumably in
some quick and easy way such as Ctrl+mousewheel, rather than having to go
through menus every time you want to change zoom level.

I doubt our community has the energy to create multiple hand-drawn tilesets
at different zoom levels, so I guess we'll have to put up with jaggies and
such ugliness at non-default zoom levels. (Sid Meier's Alpha Centauri allows
something like this with pixel-based tilesets.)

I can understand the desire for this. I use the zoom facility provided by my
window manager (Compiz' Enhanced Zoom Desktop
) for this sort of thing all the time
(not just in Freeciv).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Doxygen documentation markup

2011-02-18 Thread Jacob Nevins

Marko Lindqvist writes:
>  No comments? I kind of expected at least Jacob as our main
> documentation guru to have an opinion. Just in case I changed subject
> of this email to one that might catch his attention better :-)

Hey, I mainly concern myself with user documentation. Developer
documentation is another kettle of worms entirely. ;)

> Now that we are putting doxygen generated documentation online one way
> or other we should also consider improving it.
>
> Doxygen (like other similar tools) requires specially crafted comments
> in source code (its markup) to build better documentation from. Should
> we add such markup to freeciv code? It's also important to decide if
> we want to use some other markup (and some other tool) instead, before
> we have invested a lot of working time to add doxygen markup.

Well, I've worked in a few codebases where Doxygen has been used,
although not on this scale, and I've never introduced it myself. It
seems pretty popular, particularly for C codebases, so I guess it'll
remain well-supported, and I'm not aware of a "better" choice (but I
haven't gone looking, and I've not worked with anything else similar).

In my (limited!) experience it's rather good for basic documentation
that's closely tied to code structures, so long as you don't try to do
anything too fancy with it (in terms of formatting, or swathes of text
that aren't tied to any particular code construct -- I think our wiki
would be better for that sort of thing).

I wouldn't be unhappy committing to Doxygen markup.

(
seems like a reasonable place to shop for alternatives, if anyone feels
like it. By the features and support, nothing else stands out as
obviously much better than Doxygen.)

> If we don't decide against doxygen markup (if we at least allow people
> to add it, if not require it), I'd like to see some official policy
> added to CodingStyle. It should govern markup usage on new code and
> code being touched.

Doxygen allows several ways of doing the markup (dunno if you can
disable some of them in the configuration), so we'd probably want to set
some standards for that.

> I don't expect us to systematically go through all the existing code
> to add markup now. We may decide to add some specific subset of
> documentation systematically when doing so would make documentation
> significantly better with small investment.

Function headers are already in a pretty standard format. We could
consider auto-converting those to Doxygen markup to get basic
per-function documentation; the current Doxygen output is pretty
indigestible without.

Autogenerated code is another place where we could get a quick win (and
compensate somewhat for the fact that important files like packets.def
will probably be otherwise invisible in Doxygen output).

To start with, we could try applying such automatic conversions locally
between checkout and running Doxygen in some sort of regular build, if
we don't want to commit to Doxygen and create noise in svn. However, I
think we'd get the most benefit from checking an autoconversion into
svn, and then we can improve it by adding \param, \returns, hyperlink
etc markup on an ad-hoc basis. It'll be a bit of a pain for porting
between branches, but we've survived such "noisy" changes before (e.g.,
assert->fc_assert, my*()->fc_*()).

By the way, I guess that the current freeciv.doxygen relies on you
having done a full build first, so that autogenerated code is in place?
Perhaps it should be added as a Makefile target so that it gets all the
dependencies it needs.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17742] Setting killcitizen messes memory

2011-02-18 Thread Marko Lindqvist


Follow-up Comment #2, bug #17742 (project freeciv):

> Is this something you found with valgrind?

No, I was working on patch adding another bitwise setting. I had initially
declared that variable char, and that caused problems as variable next to it
got changed also. I then checked other bitwise settings and noticed this
potential problem.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17760] Zoom

2011-02-18 Thread Marko Lindqvist


URL:
  

 Summary: Zoom
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 18 Feb 2011 06:55:16 PM EET
Category: client
Severity: 1 - Wish
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

In discussion with Scenario League
(http://forums.civfanatics.com/showthread.php?t=412202) Harry Tuttle (name to
be used in credits to be confirmed) says that freeciv needs zoom
functionality.

Implementing this in client common code would mean that all clients would get
the feature. However, using optimized zooming functionality of widget-sets
would be so much better performance -wise that I vote for client-specific
implementation.

Qt has zooming support which would make this quite natural feature in
Qt-client once we get one. I don't know for sure, but it's probably quite easy
to implement also for gtk-client once we've switched to drawing code that uses
cairo. So our gtk3 migration plays a role here.

As request is about supporting scenario creation, I don't think it would
satisfy requestor if we had Qt-client that has zoom but no editor and
gtk-client that has editor but no zoom.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2270] [metaticket] allow recursive transports

2011-02-18 Thread Matthias Pfafferodt


Update of patch #2270 (project freeciv):

  Depends on: => patch #2547


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2547] [transport19] first move the transporter, then the transported unit(s)

2011-02-18 Thread Matthias Pfafferodt


URL:
  <http://gna.org/patch/?2547>

 Summary: [transport19]  first move the transporter, then the
transported unit(s)
 Project: Freeciv
Submitted by: syntron
Submitted on: Fr 18 Feb 2011 15:18:38 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

* the right way to go; if the transporter dies all transported units are
dead
* this changes autogame results, i.e. no identical games for the same
settings (seeds)




___

File Attachments:


---
Date: Fr 18 Feb 2011 15:18:38 CET  Name:
20110218-first-move-the-transporter-then-the-transported-unit.patch  Size: 2kB
  By: syntron

<http://gna.org/patch/download.php?file_id=12484>

___

Reply to this item at:

  <http://gna.org/patch/?2547>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2477] [transport09] use pointer for transported units (server/common)

2011-02-18 Thread Matthias Pfafferodt


Follow-up Comment #1, patch #2477 (project freeciv):

updated patch:

* autogame test (first move transported units and then the transporter)
* fix wrong '==' in advmilitary.c; should be '='
* cleanup a check in aiunit.c

there are still differences in autogames; this needs further investigations
...

(file #12483)
___

Additional Item Attachment:

File name: 20110218-use-pointer-for-transported-units-server-common.patch
Size:64 KB


___

Reply to this item at:

  <http://gna.org/patch/?2477>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17693] print 'Console:' for option changed using the server console / script files

2011-02-18 Thread Matthias Pfafferodt


Follow-up Comment #1, bug #17693 (project freeciv):

see svn #19366 and svn #19367 

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17692] print 'Ruleset:' for option changes by the ruleset

2011-02-18 Thread Matthias Pfafferodt


Update of bug #17692 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 
 Planned Release:   2.4.0 => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17693] print 'Console:' for option changed using the server console / script files

2011-02-18 Thread Matthias Pfafferodt


Update of bug #17693 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 
 Planned Release:   2.4.0 => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17684] Loading a savegame with rule locked displays an error

2011-02-18 Thread Matthias Pfafferodt


Update of bug #17684 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 
 Planned Release: => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2542] server/ruleset settings

2011-02-18 Thread Matthias Pfafferodt


Update of patch #2542 (project freeciv):

 Assigned to:None => syntron

___

Follow-up Comment #1:

I added some patches which prepare for the new 'ruleset' settings level.
Please add your opinions to the proposed changes ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2542] server/ruleset settings

2011-02-18 Thread Matthias Pfafferodt


Update of patch #2542 (project freeciv):

  Depends on: => patch #2544


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2546] [settings03] redo show command

2011-02-18 Thread Matthias Pfafferodt


URL:
  <http://gna.org/patch/?2546>

 Summary: [settings03] redo show command
 Project: Freeciv
Submitted by: syntron
Submitted on: Fr 18 Feb 2011 14:59:42 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

* cleanup show_command()
* prepare for new level 'ruleset'



___

File Attachments:


---
Date: Fr 18 Feb 2011 14:59:42 CET  Name: 20110218-redo-show-command.patch 
Size: 7kB   By: syntron

<http://gna.org/patch/download.php?file_id=12482>

___

Reply to this item at:

  <http://gna.org/patch/?2546>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2545] [settings02] use new setting lists

2011-02-18 Thread Matthias Pfafferodt


Update of patch #2545 (project freeciv):

 Summary:   use new setting lists => [settings02] use new
setting lists


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2545] use new setting lists

2011-02-18 Thread Matthias Pfafferodt


URL:
  <http://gna.org/patch/?2545>

 Summary: use new setting lists
 Project: Freeciv
Submitted by: syntron
Submitted on: Fr 18 Feb 2011 14:57:58 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

see also gna patch #2544



___

File Attachments:


---
Date: Fr 18 Feb 2011 14:57:58 CET  Name: 20110218-use-new-setting-lists.patch
 Size: 8kB   By: syntron

<http://gna.org/patch/download.php?file_id=12481>

___

Reply to this item at:

  <http://gna.org/patch/?2545>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17757] fix comment to lookup_option()

2011-02-18 Thread Matthias Pfafferodt


URL:
  <http://gna.org/bugs/?17757>

 Summary: fix comment to lookup_option()
 Project: Freeciv
Submitted by: syntron
Submitted on: Fr 18 Feb 2011 14:56:23 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0,2.4.0

___

Details:

cleanup of the comment for lookup_option(); see also bug #17672



___

File Attachments:


---
Date: Fr 18 Feb 2011 14:56:23 CET  Name:
20110218-fix-comment-to-lookup_option.patch  Size: 1kB   By: syntron

<http://gna.org/bugs/download.php?file_id=12480>

___

Reply to this item at:

  <http://gna.org/bugs/?17757>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2544] [settings01] add settings_list_* functions

2011-02-18 Thread Matthias Pfafferodt


URL:
  <http://gna.org/patch/?2544>

 Summary: [settings01] add settings_list_* functions
 Project: Freeciv
Submitted by: syntron
Submitted on: Fr 18 Feb 2011 14:53:38 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

* create (sorted) lists for all setting levels



___

File Attachments:


---
Date: Fr 18 Feb 2011 14:53:38 CET  Name:
20110218-add-settings_list_-functions.patch  Size: 9kB   By: syntron

<http://gna.org/patch/download.php?file_id=12479>

___

Reply to this item at:

  <http://gna.org/patch/?2544>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2528] GTK_CFLAGS -> GTK2_CFLAGS

[Freeciv-Dev] [patch #2510] adv_wants_science()

[Freeciv-Dev] [bug #17760] Zoom

Re: [Freeciv-Dev] Doxygen documentation markup

[Freeciv-Dev] [bug #17742] Setting killcitizen messes memory

[Freeciv-Dev] [bug #17760] Zoom

[Freeciv-Dev] [patch #2270] [metaticket] allow recursive transports

[Freeciv-Dev] [patch #2547] [transport19] first move the transporter, then the transported unit(s)

[Freeciv-Dev] [patch #2477] [transport09] use pointer for transported units (server/common)

[Freeciv-Dev] [bug #17693] print 'Console:' for option changed using the server console / script files

[Freeciv-Dev] [bug #17692] print 'Ruleset:' for option changes by the ruleset

[Freeciv-Dev] [bug #17693] print 'Console:' for option changed using the server console / script files

[Freeciv-Dev] [bug #17684] Loading a savegame with rule locked displays an error

[Freeciv-Dev] [patch #2542] server/ruleset settings

[Freeciv-Dev] [patch #2542] server/ruleset settings

[Freeciv-Dev] [patch #2546] [settings03] redo show command

[Freeciv-Dev] [patch #2545] [settings02] use new setting lists

[Freeciv-Dev] [patch #2545] use new setting lists

[Freeciv-Dev] [bug #17757] fix comment to lookup_option()

[Freeciv-Dev] [patch #2544] [settings01] add settings_list_* functions

20 matches

Site Navigation

Mail list logo

Footer information