[Freeciv-Dev] [bug #18200] Configure is unable to detect frameworks
Follow-up Comment #3, bug #18200 (project freeciv): Yes, it's one line setting CFLAGS and LDFLAGS environment variables for run of configure. Is that not found still about headers or about libraries (they are separate tests)? Include paths given in CFLAGS affect how headers are found, library paths in LDFLAGS affect how libraries are found. Configure check for headers tries to find QApplication and library check libraries QtGui and QtCore. Library files are named like libQtGui.somesuffix. If you send config.log generated when configure fails, I can check what exactly fails in configure test. ___ Reply to this item at: http://gna.org/bugs/?18200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2702] Gtk3 include path comments
Follow-up Comment #1, patch #2702 (project freeciv): - Fixed comments in a couple more source files (file #13167) ___ Additional Item Attachment: File name: Gtk3IncPathComments_2702-2.diff Size:13 KB ___ Reply to this item at: http://gna.org/patch/?2702 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2694] Remove all default ai includes from advisors code
Update of patch #2694 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2694 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2703] Gtk3 client string
Update of patch #2703 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2703 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17954] Hotekys displayed twice
Follow-up Comment #2, bug #17954 (project freeciv): - New TRUNK version of the patch where also gtk3-client is fixed (file #13168) ___ Additional Item Attachment: File name: DoubleHotkeyFix_17954.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17954 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13701] game_remove_unit(), homecity invalid
Follow-up Comment #5, bug #13701 (project freeciv): Current evidence suggests that this one either is or is not duplicate of bug #18194, depending what we consider proper way to fix #18194. That is: Fix to bug #18194 may fix this one too or not. If #18194 is fixed so that it also fixes this one, patch I earlier submitted to this ticket is itself an bug. So it should not be committed before we have decided what to do with #18194. ___ Reply to this item at: http://gna.org/bugs/?13701 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18195] Qt-client compile warning about NULL 3:rd argument to real_output_window_append()
Update of bug #18195 (project freeciv): Status: Ready For Test = None ___ Reply to this item at: http://gna.org/bugs/?18195 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18194] Client has out-of-date info about units transferred when city lost
Follow-up Comment #6, bug #18194 (project freeciv): This bug has probably existed forever in one form or other, so at least it isn't regression in S2_3. ___ Reply to this item at: http://gna.org/bugs/?18194 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2708] Remove default ai includes from server code
URL: http://gna.org/patch/?2708 Summary: Remove default ai includes from server code Project: Freeciv Submitted by: cazfi Submitted on: Sun 12 Jun 2011 02:31:26 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: Attached patch removes all default ai includes from server code. ___ File Attachments: --- Date: Sun 12 Jun 2011 02:31:26 PM EEST Name: ServerAiIncPathRm.diff Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=13169 ___ Reply to this item at: http://gna.org/patch/?2708 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2709] Japanese clans nations
URL: http://gna.org/patch/?2709 Summary: Japanese clans nations Project: Freeciv Submitted by: gorb Submitted on: Sun 12 Jun 2011 12:50:15 PM GMT Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Source: http://en.wikipedia.org/wiki/Japanese_clans Feudal-era clan names: Date clan, Hojo clan, Mori clan, Oda clan, Shimazu clan, Takeda clan and Tokugawa clan. I don't know how to make a ''graphic shield / shield graphic''. J.M.G./GM1530 ___ File Attachments: --- Date: Sun 12 Jun 2011 12:50:15 PM GMT Name: 7clanjapanese.zip Size: 29kB By: gorb File.zip: 7 rulesets, 7 flags and 7 large flags http://gna.org/patch/download.php?file_id=13170 ___ Reply to this item at: http://gna.org/patch/?2709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2529] Configure checks for gtk3-client
Follow-up Comment #3, patch #2529 (project freeciv): This is much better first part. It's basically full patch except that one macro call in gtk3-client.m4 must be changed when really switching to use gtk3 (AM_PATH_GTK_2_0 - AM_PATH_GTK_3_0). Advantages over the previous division to two patches are - Smaller local patch to be used when testing real gtk3 - gtk2-client and gtk3-client will already have separate configure checks. This is turn means: * Minimum gtk2-version can be set separately (i.e. correctly) for each client * gtk3-client can be built without building gtk2-client As this is basically full patch, I'll consider this ticket finished once this patch goes in. The required macro change will be part of the ticket where gtk2-client will turn from gtk2-program to gtk3-program. (file #13171) ___ Additional Item Attachment: File name: Gtk3ConfigurePartI_2529-2.diff Size:12 KB ___ Reply to this item at: http://gna.org/patch/?2529 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2701] gtk3-client settings
Follow-up Comment #1, patch #2701 (project freeciv): - Corrected option names in gtk3-clienty gui_option_extra_init() (file #13172) ___ Additional Item Attachment: File name: Gtk3Settings_2701-2.diff.bz2 Size:7 KB ___ Reply to this item at: http://gna.org/patch/?2701 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17802] Overview map area has grown from 2.2 to 2.3 (bad for small screens)
Update of bug #17802 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed Release: 2.3.0-beta3 = 2.3.0-beta4 ___ Follow-up Comment #7: Applied. For trunk, I just cloned the changes across from gui-gtk-2.0 to gui-gtk-3.0 and tested, as the source code is still almost identical. (I assume this is uncontroversial at this stage.) ___ Reply to this item at: http://gna.org/bugs/?17802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17825] Minimap corruption with large maps
Update of bug #17825 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed Planned Release: 2.3.0 = 2.3.0,2,4.0 ___ Follow-up Comment #6: Seems to work well for me, thanks. (I can't now remember the details of what I was struggling with in this area.) Is something similar needed for other clients? I don't think any other client shows anything less than the full minimap here. As for bug #17802, I've committed it in your absence, and cloned it across to gui-gtk-3.0 on trunk. If I ever revisit my ideas of comment #1, it'll be under a new ticket. ___ Reply to this item at: http://gna.org/bugs/?17825 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18180] let the overview map fill the entire window if detatched
Update of bug #18180 (project freeciv): Status: Ready For Test = Fixed Assigned to: syntron = jtn Open/Closed:Open = Closed Release: = 2.3.0-beta4 Planned Release: 2.3.0 = 2.3.0,2.4.0 ___ Follow-up Comment #3: Seems good to me. I'm committing it with the others, on the assumption that you're going to be out of contact for a bit. As with the others in this area, I've cloned it across to gui-gtk-3.0 on trunk. ___ Reply to this item at: http://gna.org/bugs/?18180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18200] Configure is unable to detect frameworks
Follow-up Comment #4, bug #18200 (project freeciv): I'll attach the log. I suspect conftest.cpp should also try to #include QApplication/qapplication.h . (file #13173) ___ Additional Item Attachment: File name: config.log Size:93 KB ___ Reply to this item at: http://gna.org/bugs/?18200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18200] Configure is unable to detect frameworks
Follow-up Comment #5, bug #18200 (project freeciv): Stupid mistake from my part. Qt-client is C++ program (and so is configure check for it). Use CXXFLAGS instead of CFLAGS. ___ Reply to this item at: http://gna.org/bugs/?18200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2688] Insert linebreaks to long happiness effect provider lists in happiness tab
Update of patch #2688 (project freeciv): Assigned to:None = jtn ___ Follow-up Comment #2: New version which does the same for wonder related happiness as building related happiness. (file #13174) ___ Additional Item Attachment: File name: insert-line-breaks-into-happiness-strings-bis.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?2688 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18050] crash with popup box (handle_alloc_failure())
Update of bug #18050 (project freeciv): Status:None = Need Info ___ Follow-up Comment #4: I can't think of a specific test. I don't think there's anything more we can do with this ticket for now; I've changed it to Need Info, but it could be closed as Invalid. ___ Reply to this item at: http://gna.org/bugs/?18050 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18200] Configure is unable to detect frameworks
Follow-up Comment #6, bug #18200 (project freeciv): CXXFLAGS gives me the same result. FWIW i've started a thread at the QtDevNet forum asking for info or an example. http://developer.qt.nokia.com/forums/viewthread/6743 (file #13175) ___ Additional Item Attachment: File name: CXX-config.log Size:89 KB ___ Reply to this item at: http://gna.org/bugs/?18200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17906] Gold upkeep icon covers unhappiness upkeep icon
Update of bug #17906 (project freeciv):
Status:None = Ready For Test
Assigned to:None = jtn
Planned Release: = 2.3.0,2.4.0
___
Follow-up Comment #5:
Looks good.
I've propagated the change to the old amplio tileset (as long as it's in our
version control...) and fixed up the others too (isotrident, isophex, trident
-- hex2t was already OK), plus:
* isotrident lost its gold upkeep icons with the fix for bug #16792. Restore
them, and fix up misalignment of upkeep icons (and lightning bolt) -- they
were bleeding into the row of numbers above.
* isophex's tiles.* were essentially a duplicate of isotrident's, so I've
made isophex reference isotrident and deleted tiles.{spec,png} and gold.spec.
(Patch is changes associated with this.)
(file #13176, file #13177, file #13178, file #13179)
___
Additional Item Attachment:
File name: trunk-S2_3-isophex-isotrident-tiles-merge.diff Size:6 KB
File name: tiles-amplio.png Size:76 KB
File name: tiles-isotrident.png Size:6 KB
File name: tiles-trident.png Size:119 KB
___
Reply to this item at:
http://gna.org/bugs/?17906
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17906] Gold upkeep icon covers unhappiness upkeep icon
Additional Item Attachment, bug #17906 (project freeciv): File name: upkeep-icons.png Size:17 KB ___ Reply to this item at: http://gna.org/bugs/?17906 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2710] Improving Hasinay nation
URL: http://gna.org/patch/?2710 Summary: Improving Hasinay nation Project: Freeciv Submitted by: dmarks Submitted on: Sun 12 Jun 2011 02:45:17 PM PDT Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: mixcoatl Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: -Fixing typos in the legend -Adding six leaders; source: http://digital.library.okstate.edu/encyclopedia/entries/H/HA045.html ___ File Attachments: --- Date: Sun 12 Jun 2011 02:45:17 PM PDT Name: hasinay-fixes.diff Size: 1kB By: dmarks http://gna.org/patch/download.php?file_id=13181 ___ Reply to this item at: http://gna.org/patch/?2710 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16457] Bug using enum pointers as int pointers
Follow-up Comment #9, bug #16457 (project freeciv): Some possible approaches to fixing settings.c: Change all the pointed-to settings (in map.server, game.server etc) to be 'int's. Simplest solution, but ugly in the source code -- it makes the link between the storage and its type much less obvious. Use trivial accessor functions to encapsulate the setting storage. These could take a standard pattern which is autogenerated by a macro (GEN_ENUM_ACCESSORS(game.info.borders, borders_accessor) generating a pair of read/write accessor functions, and we could even hope that on most platforms the toolchain would spot that all the autogenerated functions boil down to the same code and merge the object code; but this would make the source harder to read: the GEN_ENUM_ACCESSORS() invocations would have to be distant from the GEN_ENUM() definitions, and the latter would look different from GEN_INT() et al due to not referencing the setting storage directly. So it would be much harder to work out where a setting actually lived starting from the GEN_ENUM() definition. It would be possible to unify it all again by moving to defining settings with X-Macros http://en.wikibooks.org/wiki/C_Programming/Preprocessor#X-Macros or similar, but at the cost of making it even harder to understand what's going on under the hood of GEN_ENUM() etc. Doesn't feel worth the hassle, given the imperfections in the result. ___ Reply to this item at: http://gna.org/bugs/?16457 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64
Follow-up Comment #6, bug #18170 (project freeciv): Such an option is really rarely needed, and really shouldn't be used by accident, so I wonder if it should be commandline-option at all or only in database access configuration file (I haven't checked new authentication database access code, but I assume that server name and port, mysql user name and password are still read from configuration file). Didn't know about that. Yes, that still exists on trunk in much the same form, I think (it's specified with --Database file rather than --auth file now). It could take the form of a new hash parameter in that file, with options md5 (default) and md5swap to solve this problem, but extensible to other hashes such as SHA-1 in future if we feel the need. ___ Reply to this item at: http://gna.org/bugs/?18170 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
