[Freeciv-Dev] [patch #2899] Name unit class variable "uc", not "ut" as unit type

2011-08-12 Thread Marko Lindqvist 

URL:
  

 Summary: Name unit class variable "uc", not "ut" as unit
type
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 13 Aug 2011 09:16:20 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This is something I noticed as part of bug #13630 patch. There's
unit class pointer called "ut" in ruleset.c. There is no real bug in this,
but it can be confusing as there is some unit type handling in same function.
Attached patch renames variable as "uc"



___

File Attachments:


---
Date: Sat 13 Aug 2011 09:16:20 AM EEST  Name: UnitClassUC.diff  Size: 3kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2891] Remove references to ftwl-client from man page

2011-08-12 Thread Marko Lindqvist 

Update of patch #2891 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2886] Fix "set but unused variable" warning from scripting

2011-08-12 Thread Marko Lindqvist 

Update of patch #2886 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2808] Commandline options for freeciv-modpack

2011-08-12 Thread Marko Lindqvist 

Update of patch #2808 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

2011-08-12 Thread anonymous 

Follow-up Comment #6, patch #2715 (project freeciv):

Being a bit curious, I've decided to give this topic a shot.

But I've been toying with 2.3.0 tarball, not trunk.

First patch touches just about everything but gdk_draw_*.
On that note - trunk seems to have a bug in gui_main.c in regard of srv_id
used instead of ggz_id in one place.

Second (on top of first) tries for cairo drawing.

Caveats:
1. it's not complete yet - I still see gdk_draw_lines, gdk_draw_pixbuf and
gdk_draw_rectangle used somewhere
2. it just about doubles resources consumption (probably cause all sprites
are pixbufs)
3. city map view is broken - I haven't taken a shot at that
gtk_pixbuf_from_cairo_surface function yet

Other than than, I see no *obvious* graphical corruption, then again I
consider myself neither a real freeciv player nor a graphical quality expert.

(file #13853, file #13854)
___

Additional Item Attachment:

File name: api-cleanup.patch  Size:49 KB
File name: cairo-drawing.patchSize:36 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2898] fc_addr_family

2011-08-12 Thread Marko Lindqvist 

URL:
  

 Summary: fc_addr_family
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 13 Aug 2011 12:17:25 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch adds enum fc_addr_family. Value of that type is passed to
net_lookup_service() instead of bool indicating if IPv4 should be forced. This
simplifies callers significantly.




___

File Attachments:


---
Date: Sat 13 Aug 2011 12:17:25 AM EEST  Name: FcAddrFamily.diff  Size: 8kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2840] Make autosettlers consider improving resource tiles

2011-08-12 Thread Marko Lindqvist 

Update of patch #2840 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2513] [lua01] rename files (preparation for lua module rework)

2011-08-12 Thread Marko Lindqvist 

Follow-up Comment #13, patch #2513 (project freeciv):

> so you say the order should be:
>
> 1. moving code
> 2. rename files
> 3. cleanup / changes

Yes, as long as it's understood that 2 contains minimum changes to
Makefile.ams and configure.ac so that the commit does not break anything.
You should not create new ticket about 1.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2887] Build dependencies first

2011-08-12 Thread Marko Lindqvist 

Update of patch #2887 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

2011-08-12 Thread Marko Lindqvist 

Follow-up Comment #5, patch #2715 (project freeciv):

Found out interesting facts about GtkPixcomm implementation. Actual drawing
when widget is exposed uses those data pointers that have been earlier passed
to gtk_pixcomm_fill() and gtk_pixcomm_copyto(). This means that GtkPixcomm
users must ensure that color structures or sprites are not freed as long as
GtkPixcomm is in use. This explains at least one bug in my earlier cairo
patches where local GdkColor structure was passed to gtk_pixcomm_fill() but
GtkPixcomm was drawn only after exiting that function.

Corrupted backgrounds in sprites (including animated cursors) seem to be
problem in drawing to gtk widgets. Everything in handling sprites and canvases
seem to work. Only when final draw from some partly transparent cairo surface
to gtk widget surface is made, extra stuff is left to those transparent
places. It looks like widget surfaces had some stuff on them initially and
that's visible in places we don't overdraw.
I actually did test version that had extra level of drawing. Our partly
transparent canvases were drawn on top of another filled canvas so that the
result had no transparent parts at all. That canvas is then drawn to gtk
widget. No corruption was visible with that version, and for a while I
actually considered using it as fallback solution for first canvas using
commit - but then I noticed that even cursors would need that and those really
need transparency.

Improvements in attached version since previous:
- Helpdialog always keeps color-structure for unit GtkPixcomm
- Moved surface initialization outside of the operations iteration when
GtkPixcomm exposed
- Common parts of sprite_get_pixbuf() and canvas_put_pixbuf() moved to
separate function surface_get_pixbuf()
- Completely removed some code that was already commented out in earlier
versions


Buglist:
- Unit sprites not shown at help dialog
- Wrong terrain pieces drawn to main map (mask handling problem?)
- gtk widgets and cursors displays mess where we don't overdraw with solid
color


(file #13849)
___

Additional Item Attachment:

File name: CairoTmp5.diff.bz2 Size:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18491] Whitespaces in srcdir path break autogen.sh

2011-08-12 Thread Marko Lindqvist 

Follow-up Comment #1, bug #18491 (project freeciv):

- Fixed also handling of builddir with whitespace in name: wrong directory
(usually srcdir) got configured


(file #13848)
___

Additional Item Attachment:

File name: WSautogen_18491-2.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2867] MySQL configure checks in 64bit RedHat derivatives

2011-08-12 Thread anonymous 

Follow-up Comment #2, patch #2867 (project freeciv):

Bit late, but doesn't mysql_config exist for this very purpose ?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1338] [Metaticket] Generalize requirements

2011-08-12 Thread J. M. Gorbach 

Follow-up Comment #1, patch #1338 (project freeciv):

A wish/suggestion... Nation in [Metaticket] Generalize requirements.

Example: http://forum.freeciv.org/viewtopic.php?t=6750

___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2265] [metaticket] citizens

2011-08-12 Thread J. M. Gorbach 

Follow-up Comment #7, patch #2265 (project freeciv):

-One question is, if it should be a 'real' ruleset option as it is now or an
effect.
I prefer an effect.
-The later would allow to change the result 
Buildings (ex. Courthouse and University)  and wonders (ex. French
Revolution? 1848?).
-Which are good for the game play and should be implemented? 
Ruled by foreign oppressor, Ethnic tensions and Underground independence
movement.

___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev