[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong

2012-07-29 Thread Jacob Nevins 
URL:
  

 Summary: Initial state of chatline toolbar is wrong
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Jul 29 11:55:24 2012
Category: client-gtk-3.0
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r21637
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.4.0,2.5.0

___

Details:

The "Chat tools" button starts in the deactivated state (popped out), but the
toolbar (bold, strikethrough, etc) is nevertheless shown. (In the Gtk2 client
it's initially hidden.)
The first time the tools button is pressed, nothing happens other than that
the button goes in.
After that it behaves as designed.

I haven't spotted an obvious mistake in chatline.c. I'm not sure what sets the
initial hidden state in gtk2 -- probably the set_toolbar_visibility() callback
connected to "expose-event". In gtk3 this is connected to "map"; perhaps that
makes things happen in the wrong order?




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19087] Slicker language selection in Windows installer

2012-07-29 Thread Marko Lindqvist 
Follow-up Comment #2, bug #19087 (project freeciv):

Attaching new version just in case, though I think this approach will never be
of acceptable quality.

- Added Indonesian to langnames.txt
- Added langnames.txt to tarball
- Stats generation in separate script instead of being incorporated to
win32/Makefile
- langstat.txt now generated to $(top_builddir)
- langstat.txt generation PHONY target so gets always regenerated when "make
dist" run

Bugs:
- langstat.txt is generated as first step of 'make dist', most importantly
before .po files have been updated
- Requires bash (should work wiht any standard /bin/sh)

And the main problem:
- Works only with English locale when every .po file has at least 2 (=plural)
of each of translated, fuzzy, and untranslated strings. This is due to very
fragile method of parsing msgmsrg --stat output. Even if we fix it to work
with current version of gettext, it would depend on gettext output strings
never to change...

(file #16228)
___

Additional Item Attachment:

File name: Langstats-2.patch  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19998] Cimpletoon tileset lacks Elephants/Crusaders, so can't be used with civ2/civ2civ3/multiplayer

2012-07-29 Thread Marko Lindqvist 
Follow-up Comment #1, bug #19998 (project freeciv):

Note that all tilesets lack civ2civ3 Geoengineer gfx. Ruleset just has normal
Engineer gfx as fallback.
I wonder if similar usage of fallbacks would be acceptable short-term solution
(=avoid the client aborting at least) for Elephants and Crusaders too?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20001] Some colours (e.g., border colours on map) are wrong

2012-07-29 Thread Jacob Nevins 
URL:
  

 Summary: Some colours (e.g., border colours on map) are wrong
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Jul 29 13:33:21 2012
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r21637
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

Simple typo in the gtk sprite.c means that the green component is ignored for
some sprite-related operations. Fix attached.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20001] Some colours (e.g., border colours on map) are wrong

2012-07-29 Thread Jacob Nevins 
Update of bug #20001 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-gtk3-sprite-color-rbb.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1

2012-07-29 Thread Jacob Nevins 
Update of task #7599 (project freeciv):

 Should Start On: Sun Jun 17 00:00:00 2012 => Sun Aug 12 00:00:00 2012
   Should be Finished on: Mon Dec 31 00:00:00 2012 => Sun Aug 19 00:00:00 2012
  Status:   Need Info => None   
 Summary: Windows packages for 2.4.0-beta1 (placeholder) =>
Windows packages for 2.4.0-beta1

___

Follow-up Comment #8:

> the beta isn't imminent...
It's getting that way now -- as announced
, I plan to
release the beta1 source on the weekend of August 11-12.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7603] Tracking release 2.4.0-beta1

2012-07-29 Thread Jacob Nevins 
Update of task #7603 (project freeciv):

   Should be Finished on: Sun Jul  1 22:00:00 2012 => Sun Aug 12 00:00:00 2012


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3456] Add language names list

2012-07-29 Thread Marko Lindqvist 
URL:
  

 Summary: Add language names list
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Jul 2012 03:59:33 PM EEST
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0, 2.5.0

___

Details:

While translation statistics generation part of bug #19087 is problematic,
language names part can be useful (I sort of hope to get something done for
Windows installer before 2.4.0-beta1). This patch adds bootstrap/langnames.txt
file to version control and tarball.

- What should (if any) suffix of the file be. Current .txt might be a bit too
generic.

- Currently language names are in English. We may want them in the language
itself in the future, but I don't have time to find out those names now.



___

File Attachments:


---
Date: Sun 29 Jul 2012 03:59:33 PM EEST  Name: Langnames-S2_4.patch  Size: 1kB 
 By: cazfi


---
Date: Sun 29 Jul 2012 03:59:33 PM EEST  Name: Langnames.patch  Size: 1kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7504] Tracking release 2.4.0

2012-07-29 Thread Jacob Nevins 
Update of task #7504 (project freeciv):

   Should be Finished on: Tue Aug 14 22:00:00 2012 => Fri Feb 15 00:00:00 2013


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7518] Mac packages for 2.3.1

2012-07-29 Thread Jacob Nevins 
Update of task #7518 (project freeciv):

  Status:None => Cancelled  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Since 2.3.2 has come and gone, I'm assuming this isn't going to happen now. I
won't raise tasks for Mac builds for future releases until further notice.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3457] Set estimated release month for 2.4.0 to February

2012-07-29 Thread Marko Lindqvist 
URL:
  

 Summary: Set estimated release month for 2.4.0 to February
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Jul 2012 04:25:21 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:





___

File Attachments:


---
Date: Sun 29 Jul 2012 04:25:21 PM EEST  Name: FebEstimate.patch  Size: 385B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19999] Trouble playing multiplayer

2012-07-29 Thread Marko Lindqvist 
Update of bug #1 (project freeciv):

Category:client-win32 => None   

___

Follow-up Comment #1:

Winsock error #10053 is WSAECONNABORTED
http://msdn.microsoft.com/en-us/library/windows/desktop/ms740668%28v=vs.85%29.aspx

At first I wondered how connection lost error message can be sent from server
(as it appears in server) to client chatline as, uh, connection is supposedly
lost. But maybe it's just matter of both server and client detecting
connection loss independently.


Set category to "None" as it's unknown if this was client-gtk2 or client-sdl
(there's no working client-win32 of 2.3, but only gtk2 and sdl clients on
Windows too)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2521] [metaticket] Generic road code

2012-07-29 Thread Marko Lindqvist 
Update of patch #2521 (project freeciv):

  Status: In Progress => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Couldn't keep it such a small step after all - we now have gen-roads
equivalent of gen-bases. As such, I consider the feature now ready and going
to maintenance mode, so closing this ticket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong

2012-07-29 Thread RafałMużyło 
Follow-up Comment #1, bug #2 (project freeciv):

I suspect the only mistake could be relying on some side effect of running in
expose-event.

Attaching something that seems to fix the problem.

The second block is just a minor gtk3 cleanup.

(file #16233)
___

Additional Item Attachment:

File name: fix-chat-toolbar-visibility.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3458] Bases & roads (& specials?) to same vector in savegames

2012-07-29 Thread Marko Lindqvist 
URL:
  

 Summary: Bases & roads (& specials?) to same vector in
savegames
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Jul 2012 07:08:42 PM EEST
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

We currently save separate specials, bases, and specials maps. As each
character in savegame represent 4 specials/bases/roads, there can be wasted
capacity up to 3*3 = 9 bits (last character of each of specials/bases/roads
having just 1 meaningless bit) when number of specials/bases/roads is not
divisible by 4. If we saved them all together, there would be only one "last"
character, so wasted capacity would be 3 bits at max, meaning smaller
savegames.

If done before current roads saving format gets in to official release, and
done right (the way they are going to be arranged in the future), we could
save future headaches of savegame backward compatibility with one more
different format.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20002] Trivial build fix

2012-07-29 Thread Patrick Welche 
URL:
  

 Summary: Trivial build fix
 Project: Freeciv
Submitted by: prlw1
Submitted on: Sun Jul 29 16:35:39 2012
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: *BSD
 Planned Release: 

___

Details:

x.m4 calls test(1) giving it "==" rather than "=" as the operator to test for
string equality. (You may have a "test" which allows "==" as an extension.)



___

File Attachments:


---
Date: Sun Jul 29 16:35:39 2012  Name: buildfix.patch  Size: 1kB   By: prlw1
trivial patch


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20002] Trivial build fix

2012-07-29 Thread Marko Lindqvist 
Update of bug #20002 (project freeciv):

Category: general => bootstrap  
  Status:None => Ready For Test 
 Assigned to:None => cazfi  
 Planned Release: => 2.3.3, 2.4.0, 2.5.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20002] x.m4 uses "==" instead of "=" for comparison

2012-07-29 Thread Marko Lindqvist 
Update of bug #20002 (project freeciv):

 Summary:   Trivial build fix => x.m4 uses "==" instead of
"=" for comparison


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3449] "Nation sets": initial cut-down implementation for 2.4.x

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #2, patch #3449 (project freeciv):

> (At least in the SDL client.)
I meant Gtk. Nation groups aren't currently used in the SDL client.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3449] "Nation sets": initial cut-down implementation for 2.4.x

2012-07-29 Thread Jacob Nevins 
Update of patch #3449 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3432] "Core" nation group

2012-07-29 Thread Jacob Nevins 
Update of patch #3432 (project freeciv):

 Planned Release: => 2.4.0,2.5.0

___

Follow-up Comment #7:

Patch #3449 is now committed.

I'd like to get this in for beta1, if possible. Are we happy with it the way
it is, given the status wrt scenarios/civilwar/conflicts already posted?

I'm happy to commit what we have to trunk and S2_4 myself -- I'll do it before
beta1 if no-one says anything. (But I'm equally happy for someone else to pick
it up.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3449] "Nation sets": initial cut-down implementation for 2.4.x

2012-07-29 Thread Jacob Nevins 
Update of patch #3449 (project freeciv):

  Status:Done => In Progress
 Open/Closed:  Closed => Open   

___

Follow-up Comment #5:

Hm, just spotted a flaw in my plan.
If creating a game with more players than in the default nation set (say >50),
there's no relief valve so bad things happen.

Easy enough to remove the restrictions and try again in this case.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

2012-07-29 Thread Patrick Welche 
URL:
  

 Summary: Security advisory
 Project: Freeciv
Submitted by: prlw1
Submitted on: Sun Jul 29 18:41:34 2012
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

I came across

http://aluigi.altervista.org/adv/freecivet-adv.txt

and a quick look at packet.c suggests that the code in 2.3.2 is the same as in
the advisory. My attempts at querying the bug database haven't returned
anything, so is this still news?




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3449] "Nation sets": initial cut-down implementation for 2.4.x

2012-07-29 Thread Jacob Nevins 
Update of patch #3449 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #6:

Attached patch on top of what's already committed causes pick_a_nation() to
disable restrictions and retry, if out of nations and a restriction is in
place.

This is a temporary approach for S2_4. For the proper implementation in 2.5
(patch #3448), the size of the chosen nation set should determine an
equivalent of playable_nations, such that attempts to create nations beyond
the limit imposed by the set (via aifill, network connections etc) are
rejected, so the issue doesn't arise.

(If anyone's worried what else might come out of the woodwork with this late
change: if it turn out to be unusable, we can always stop using it in 2.4 with
no harm done, and take the time to get it right in 2.5. So I plan to press
on.)

(file #16237)
___

Additional Item Attachment:

File name: trunk-S2_4-nation-sets-interim-relief-valve.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3432] "Core" nation group

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #8, patch #3432 (project freeciv):

For the patch #3449 approach, Barbarian and Pirate nations need to be in the
Core group.
(This was probably a good idea anyway, if we were going to trigger a pot-file
split based off membership in the Core group -- we need them translated.)

This won't affect the nation groups displayed to the client, as these are not
playable nations.

(file #16238, file #16239)
___

Additional Item Attachment:

File name: trunk-core-nations-p3449-bis.patch Size:25 KB
File name: S2_4-core-nations-p3449-bis.patch Size:25 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3432] "Core" nation group

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #9, patch #3432 (project freeciv):

(BTW, another use for this core group would be if a custom tileset wanted a
custom flagset -- IIRC one tileset author on the forum wanted their own
flagset for some reason. This allows them to focus on a manageable number of
flags.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3432] "Core" nation group

2012-07-29 Thread Jacob Nevins 
Update of patch #3432 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3448] "Nation sets": allow set of nations that will ever appear in-game to be chosen

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #3, patch #3448 (project freeciv):

The list of nations shown in the client help should reflect the selected
nationset.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3459] Per road type roadstyle

2012-07-29 Thread Marko Lindqvist 
URL:
  

 Summary: Per road type roadstyle
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Jul 2012 11:16:44 PM EEST
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Replace one tileset wide roadstyle with road type specific ones. This makes it
easier to mix gfx from different sources and makes it easier to reimplement
rivers as special road type.



___

File Attachments:


---
Date: Sun 29 Jul 2012 11:16:44 PM EEST  Name: PerRoadRoadstyle.patch  Size:
13kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19609] View Native Tiles & city dialog

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #1, bug #19609 (project freeciv):

To fix this I think we should fix both issues:
* It doesn't make sense to display information about the current unit(s) in
the city map.
* We should have a different sprite for non-native tiles (perhaps one without
borders). It shouldn't take much in the way of artistic skills...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17685] bulbs per turn not always displayed on map view tooltip

2012-07-29 Thread Jacob Nevins 
Follow-up Comment #6, bug #17685 (project freeciv):

> Maybe in the message (I don't remember the exact words...)
> "tech 14 - 0 per turn" can be remove the " - 0" part if no 
> tech has upkeep cost
For the record, the "- 0" was removed if tech upkeep is disabled in bug
#19162.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19983] Conquered fortress provides borders for previous owner where new owner does not see

2012-07-29 Thread Marko Lindqvist 
Update of bug #19983 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

2012-07-29 Thread Marko Lindqvist 
Follow-up Comment #1, bug #20003 (project freeciv):

> is this still news?

Yes. It would be nice if those who already invest so much time to investigate
security and write advisories would bother to inform us too so that these
things would get also fixed.

Fix for A] for S2_3, S2_4 and TRUNK attached. This patch doesn't apply to
S2_2, but security fix is still worth backporting (will check also S2_0 in
case warclient folks will update their fork)


(file #16241)
___

Additional Item Attachment:

File name: CheckMinTotalPacketLen.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

2012-07-29 Thread Marko Lindqvist 
Update of bug #20003 (project freeciv):

 Planned Release: => 2.0.11, 2.2.8, 2.3.3,
2.4.0, 2.5.0

___

Follow-up Comment #2:

- Fix for A], S2_2 and S2_0 version.

(file #16242)
___

Additional Item Attachment:

File name: CheckMinTotalPacketLen-S2_2.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19986] universal_rule_name() returning weird strings

2012-07-29 Thread Marko Lindqvist 
Update of bug #19986 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3446] Make terrain class property of terrain type instead of determining it from flags

2012-07-29 Thread Marko Lindqvist 
Update of patch #3446 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20004] Qt-client does not compile due to use of C++ reserved word "class" in common headers

2012-07-29 Thread Marko Lindqvist 
URL:
  

 Summary: Qt-client does not compile due to use of C++
reserved word "class" in common headers
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 30 Jul 2012 03:00:15 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

So it seems Qt-client is not enabled in my pre-commit compilation tests...
last commit introduced use of word "class" in terrain.h and that breaks
compilation of Qt-client written in C++.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20004] Qt-client does not compile due to use of C++ reserved word "class" in common headers

2012-07-29 Thread Marko Lindqvist 
Update of bug #20004 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Patch committed immediately after testing.

(file #16243)
___

Additional Item Attachment:

File name: Tclass.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-29 Thread Marko Lindqvist 
Update of patch #3434 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Committed though noticed in final testing that there's no confirmation dialog
when selecting target government directly. I guess that's not intentional?
Leaving to future tickets.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3452] Qt science report small fix

2012-07-29 Thread Marko Lindqvist 
Follow-up Comment #1, patch #3452 (project freeciv):

Even with this patch behavior before first research is selected is weird.

1. Start new game
2. Before doing anything else, open research dialog
3. See how selected research and goal change rapidly from one value to
another

This no longer happens once you select tech to research, or one gets selected
automatically on first turn change.

Is that separate issue, or should it be handled as part of this ticket?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev