[Freeciv-Dev] [bug #20476] netdb.h conflict
URL:
http://gna.org/bugs/?20476
Summary: netdb.h conflict
Project: Freeciv
Submitted by: hugo
Submitted on: Sun 03 Feb 2013 01:04:36 PM GMT
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: GNU/Linux
Planned Release:
___
Details:
After building against SVN @22265 on Ubuntu Ubuntu 10.04.4 LTS (Lucid),
attempting to start the server immediately bailed out with the error Server:
bad address: (none):5556.
After some digging, this turned out to be a conflict between two different
netdb.h files - /usr/include/netdb.h comes from libc6 (Ubuntu package libc-dev
version 2.11.1-0ubuntu7.11 from the eglibc project), and includes a
definition:
# define AI_NUMERICSERV 0x0400 /* Don't use name resolution. */
I also have /usr/include/bind/netdb.h, which comes from libbind (Ubuntu
package libbind4, version 6.0-1, from the libbind project). This is the
library that actually provides getaddrinfo(3), and does *not* define or
support NUMERICSERV; attempting to pass ai_flags with 0x400 set always returns
EAI_BADFLAGS.
I don't know whether the error here is mine, Ubuntu's, Freeciv's, or that of
one of the two source projects.
1) It was made harder to track down the problem because net_lookup_getaddrinfo
in utility/netintf.c does not report or return the actual error. It would be
useful if it could be modified to log the error, eg with:
... else {
printf(getaddrinfo: error '%s' (%d)\n, gai_strerror(err), err);
}
2) I do not know if the configure probes could be enhanced to check for both
netdb.h and bind/netdb.h and make an intelligent choice between them. For
now I've just hacked my netintf.c, which has got me a little further; I've not
yet checked if I also need to change the other uses of netdb.h.
3) An alternative would be to support a build hint HAVE_AI_NUMERICSERV, but I
suspect it will generally be hard for someone building freeciv to discover
they should override this to false.
Hope this helps,
Hugo
___
Reply to this item at:
http://gna.org/bugs/?20476
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20003] Security advisory
Follow-up Comment #23, bug #20003 (project freeciv): IIRC return value is solely about whether data was available (and read). These low-level functions do not know what data is valid. Maybe dio_get_uint8() has a bug? I think so. I will try to investigate a bit deeper... Usually lack of valid data will lead to connection being closed in upper level, but the original bug here was that low-level ended to infinite loop and it never returned to upper level. I understood this point. However, no test is performed in the packets body, or nearly not. I will try to build a more complete patch. ___ Reply to this item at: http://gna.org/bugs/?20003 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3640] Document need to restart msys.bat after dev packages installation
Update of patch #3640 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3640 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3663] Setting lock optional
URL: http://gna.org/patch/?3663 Summary: Setting lock optional Project: Freeciv Submitted by: cazfi Submitted on: Sun 03 Feb 2013 10:34:54 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Ruleset seldom needs to set setting locked, so one would expect it something that doesn't need to be explicitly said about every setting. Attached patch makes defininig setting lock value in ruleset optional, defaulting to FALSE if not given. ___ File Attachments: --- Date: Sun 03 Feb 2013 10:34:54 PM EET Name: OptionalLock.patch Size: 664B By: cazfi http://gna.org/patch/download.php?file_id=17116 ___ Reply to this item at: http://gna.org/patch/?3663 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3664] Alien ruleset settings in game.ruleset
URL: http://gna.org/patch/?3664 Summary: Alien ruleset settings in game.ruleset Project: Freeciv Submitted by: cazfi Submitted on: Sun 03 Feb 2013 11:57:36 PM EET Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Move settings from alien.serv to game.ruleset. I finally found a good argument to decide which one is better - reset command resets to value found in ruleset by default. ___ File Attachments: --- Date: Sun 03 Feb 2013 11:57:36 PM EET Name: AlienSettings.patch Size: 962B By: cazfi http://gna.org/patch/download.php?file_id=17117 ___ Reply to this item at: http://gna.org/patch/?3664 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3665] civ2civ3 settings in game.ruleset
URL: http://gna.org/patch/?3665 Summary: civ2civ3 settings in game.ruleset Project: Freeciv Submitted by: cazfi Submitted on: Mon 04 Feb 2013 12:27:18 AM EET Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Move server settings from civ2civ3.serv to game.ruleset. Do not set trademindist at all as traderoutesettings are used to disable national traderoutes completely. ___ File Attachments: --- Date: Mon 04 Feb 2013 12:27:18 AM EET Name: Civ2civ3Settings.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=17118 ___ Reply to this item at: http://gna.org/patch/?3665 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3645] Modpack notes
Update of patch #3645 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3645 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3648] Roadstyle as specenum
Update of patch #3648 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3648 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
