[Freeciv-Dev] [bug #20577] new parameter gameloss_style in game.ruleset
Follow-up Comment #4, bug #20577 (project freeciv): ouch, yes, right one comes here (file #17399) ___ Additional Item Attachment: File name: gamelossStyle22446_v2.patchSize:9 KB ___ Reply to this item at: http://gna.org/bugs/?20577 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3765] Error output about failed mapimg create command
Update of patch #3765 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3765 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20595] Errow while setting temperature below 14 with temperate map
URL: http://gna.org/bugs/?20595 Summary: Errow while setting temperature below 14 with temperate map Project: Freeciv Submitted by: hubkow Submitted on: Wed 06 Mar 2013 04:29:56 PM CET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.2 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: At the beginning of the game, when checking the option All the map is temperate and Average temperature of the planet to less than 14, the error message The server couldn't allocate starting positions pops up. ___ Reply to this item at: http://gna.org/bugs/?20595 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20596] The scenario Earth (classic/small) fails to start
URL: http://gna.org/bugs/?20596 Summary: The scenario Earth (classic/small) fails to start Project: Freeciv Submitted by: hubkow Submitted on: Wed 06 Mar 2013 04:39:26 PM CET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.2 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: The scenario Earth (classic/small) fails to start. After selecting the scenario, the button for starting the game is inactive, no AI players are listed, and none can be added. Other scenarios start properly. ___ Reply to this item at: http://gna.org/bugs/?20596 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20589] Client uses different safe filename logic to everything else
Update of bug #20589 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20589 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20555] Client fails to kill server when it fails to get 'hack' access
Update of bug #20555 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20555 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20596] The scenario Earth (classic/small) fails to start
Follow-up Comment #1, bug #20596 (project freeciv): I think this is a duplicate of bug #20050, which was fixed in 2.3.3? ___ Reply to this item at: http://gna.org/bugs/?20596 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20598] Something funny with Ready checkboxes in pregame screen
URL: http://gna.org/bugs/?20598 Summary: Something funny with Ready checkboxes in pregame screen Project: Freeciv Submitted by: jtn Submitted on: Thu Mar 7 00:01:36 2013 Category: client-gtk-3.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: 2.4.0 ___ Details: They seem to be progressively more shifted/truncated vertically on successive players. See screenshot. (Same on S2_4 r22490 and trunk r22488.) ___ File Attachments: --- Date: Thu Mar 7 00:01:36 2013 Name: gtk3-S2_4-pregame-checkboxes.png Size: 35kB By: jtn http://gna.org/bugs/download.php?file_id=17401 ___ Reply to this item at: http://gna.org/bugs/?20598 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20598] Something funny with Ready checkboxes in pregame screen
Follow-up Comment #1, bug #20598 (project freeciv): (This is on xubuntu 12.04.) ___ Reply to this item at: http://gna.org/bugs/?20598 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3754] Extend road rivers when ocean transformed to land
Update of patch #3754 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3754 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3764] Make ISO topology the default
Update of patch #3764 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3764 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3770] better defense when GameLoss is a military unit
Follow-up Comment #1, patch #3770 (project freeciv): Second, if no DefendGood units can be produced, DefendOk will do. Is this somehow connected to the primary change in this ticket? Otherwise it should be separate ticket, even though it means that both would be one-liners. As you said, the first change is a bit hackish, so I need to check if there's no better way to implement it. AFAICS latter change could go forward if it was separate ticket. ___ Reply to this item at: http://gna.org/patch/?3770 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20595] Errow while setting temperature below 14 with temperate map
Follow-up Comment #1, bug #20595 (project freeciv): This is definitely suboptimal behavior, but what exactly you would expect? Should it create suitable starting places despite you explicitly requesting that all map is too cold, or should it just use unsuitable locations as starting place? ___ Reply to this item at: http://gna.org/bugs/?20595 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20577] new parameter gameloss_style in game.ruleset
Follow-up Comment #5, bug #20577 (project freeciv):
- No changes to ruleset.c? I thought the value was supposed to be read from
the ruleset.
- Don't use magic numbers gameloss_style 4. In fact you should probably
make gameloss styles bitwise specenum
- Spaces between many elements missing while (n0) - while (n 0)
- Block starting brace should not be in new line
while ()
{
-
while () {
- Braces needed even when block following if is just one line (so if another
line gets ever added, things will not blow up)
if (!fc_rand(3))
break; /* Out of luck */
-
if (!fc_rand(3)) {
break; /* Out of luck */
}
- Empty line needed between variable declararions and code
- if (evcsize 3) evcsize = 0; else evcsize -=3; -
if (evcsize 3) {
evcsize = 0;
} else {
evcsize -= 3;
}
- Decrlaration of int conqsize after previous code (not in the beginning of
block)
- What happens to palace if it's in transfered cities? You disable
savepalace for a while so it won't be moved from city to city multiple
times, but should you finally rebuild it somewhere?
- Comment type palyer - player
- +/* out of sheer cruelty we reanimate the player
+ * so he can behold what happens to his empire */
+pplayer-is_alive = TRUE;
sounds worrisome. Should't the player stay alive all the time instead (I'm
worried what may happen while (s)he is temporarily marked dead) Actually, from
the patch it seems that this gets overwritten with pplayer-is_alive =
FALSE; anyway
- As create_barbarian_player() may return existing barbarian with already
established capital, you should protect against trying to give him second
one.
___
Reply to this item at:
http://gna.org/bugs/?20577
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls
Follow-up Comment #4, bug #20544 (project freeciv): - Some comment typos fixed (file #17402) ___ Additional Item Attachment: File name: NonNatDefPct-2.patch Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?20544 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3767] Remove glib.m4 and glib-2.0.m4
Update of patch #3767 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3767 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
