[Freeciv-Dev] [patch #4077] action enablers + move the "Spy" unit flag requirement for the spy actions "Poison city" and "Sabotage unit"

[Marko Lindqvist]

Update of patch #4077 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => cazfi  
 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4094] gui-sdl2 that compiles

[Marko Lindqvist]

Follow-up Comment #1, patch #4094 (project freeciv):

- Updated against svn

(file #18718)
___

Additional Item Attachment:

File name: CompileSdl2-2.patch.bz2Size:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4098] Rename Xaw's actions.(c|h)

[Marko Lindqvist]

Update of patch #4098 (project freeciv):

Category:None => client-xaw 
 Planned Release: => 2.6.0  

___

Follow-up Comment #1:

You should change also multiple-inclusion-guard on xaw_actions.h. This is even
more than cosmetic - sharing same guard between xaw_actions.h and
common/actions.h would not be good.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4091] Add a local range to diplomatic relation requirement type

[Marko Lindqvist]

Update of patch #4091 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4093] Desktop file to launch gtk3-client

[Marko Lindqvist]

Update of patch #4093 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4099] Update tutorial scenario to 2.5 savegame format

[Marko Lindqvist]

URL:
  

 Summary: Update tutorial scenario to 2.5 savegame format
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 20 Aug 2013 01:17:42 AM EEST
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Tue 20 Aug 2013 01:17:42 AM EEST  Name: Tutorial25.patch.bz2  Size: 9kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21036] Windows unistaller not removing server

[Christian Prochaska]

Follow-up Comment #1, bug #21036 (project freeciv):

The uninstaller normally removes the server, but it doesn't kill running
servers, so in that case the files currently in use would remain. This
shouldn't have an effect on other installed Freeciv versions, though, since
the installer does not modify the PATH variable and each version has its own
installation directory by default.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4077] action enablers + move the "Spy" unit flag requirement for the spy actions "Poison city" and "Sabotage unit"

[Sveinung Kvilhaugsvik]

Follow-up Comment #9, patch #4077 (project freeciv):

I just uploaded the wrong patch. Here is the correct one.

(file #18716)
___

Additional Item Attachment:

File name: action_enablers.patch  Size:28 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4079] Minimum size requirement of "Poison city" to action enablers

[Sveinung Kvilhaugsvik]

Follow-up Comment #3, patch #4079 (project freeciv):

Update to apply on top of patch #4078

(file #18715)
___

Additional Item Attachment:

File name: poison_size_req.patch  Size:11 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #4078 (project freeciv):

Update to apply on top of patch #4077

(file #18714)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:19 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4077] action enablers + move the "Spy" unit flag requirement for the spy actions "Poison city" and "Sabotage unit"

[Sveinung Kvilhaugsvik]

Follow-up Comment #8, patch #4077 (project freeciv):

Address review comments.

(file #18713)
___

Additional Item Attachment:

File name: action_enablers.patch  Size:46 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4089] Save unit activity order to savegame

[Marko Lindqvist]

Update of patch #4089 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21041] Player "Ready" status toggling off in pregame

[Marko Lindqvist]

URL:
  

 Summary: Player "Ready" status toggling off in pregame
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Aug 2013 09:41:41 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

This one is probably not bug per se, but something not-well-documented and
breaking our use-case. If not bug, this ticket should still exist about
supporting the use-case.

We play long turn -style, so that people play their turns when ever they have
time instead of everyone being on computer at the same time. This should be
case also when starting the game.
With connection problems regularly cutting them, we cannot really go by the
model that first everyone connects (time between first and last one being
something between 12 and 48 hours) and then everyone clicks "Ready". We use
"minplayers" setting to partially solve the problem. We set minplayers to 4 as
we have 4 players. Then, in theory, everyone can click "Ready" as soon as he
connects, but game starting only when all 4 players have done that.
The problem is that "Ready" status of player seems not to be persistent.
Client left in "Ready" status waiting for game to start has often/always lost
it's "Ready" status when one comes back in a couple of hours. That's despite
client still being connected to server, and just requiring clicking of "Ready"
again.
So, even if we have 3 players connected who have already clicked "Ready", game
will not start when fourth one connects since someone else has already lost
his "Ready" status. And by the time he toggles "Ready" again, someone else has
lost the status...




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21040] crash after building city on fortress tile

[Bo Di Bo]

Follow-up Comment #2, bug #21040 (project freeciv):

For your information: Please note that in earlier versions of freeciv this
type of action has never caused a crash for me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21038] Replace the gtk+ DLLs to newer version

[Christian Prochaska]

Update of bug #21038 (project freeciv):

 Assigned to:None => cproc  


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4098] Rename Xaw's actions.(c|h)

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Rename Xaw's actions.(c|h)
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 19 Aug 2013 03:55:57 PM GMT
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

to xaw_actions.(c|h). It compiles. The client starts. No matter if this patch
is applied or not I'm not able to issue any orders and the menus are grayed
out. (That may be normal. I haven't used the xaw client before)



___

File Attachments:


---
Date: Mon 19 Aug 2013 03:55:57 PM GMT  Name: xawActionsRename.patch  Size: 1kB
  By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4097] Kill diplstate_text(), use diplstate_type_name()

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Kill diplstate_text(), use diplstate_type_name()
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 19 Aug 2013 02:17:45 PM GMT
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The names in diplstate_text() is qualified. The enum must be untranslated as
it is used when reading from the rule set. Solve this by making other users of
the same string (that I assume can be translated differently) qualified.

Changes:
 * Qualify "Team" used as a label.
 * Mark the names in the spec enum as translateble
 * Replace diplstate_text(state) with _(diplstate_type_name(state))

Only tested lightly. (Started the gtk2, gtk3, qt and sdl clients. Looking at
nations and, except for qt, intelligence)

Is the approach OK? Any suggestions for more tests?



___

File Attachments:


---
Date: Mon 19 Aug 2013 02:17:45 PM GMT  Name: kill_diplstate_text.patch  Size:
10kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4086] Targeted pollution/fallout cleaning

[Marko Lindqvist]

Follow-up Comment #1, patch #4086 (project freeciv):

- Updated against svn
- player parameter to prev_extra_in_tile() const

(file #18710)
___

Additional Item Attachment:

File name: TargetedCleaning-2.patch   Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21040] crash after building city on fortress tile

[Marko Lindqvist]

Follow-up Comment #1, bug #21040 (project freeciv):

I haven't checked but this sounds like tile ownership from the city is set
first, then ownership is removed as part of base removal leading the city tile
without ownership.
Obvious solution for this (and maybe not-yet-encountered similar ones) would
be adding refcount about tile ownership, but I'd rather not make tile
structure bigger (more memory hungry) just for corner-case like this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21037] Meeting not opened when /take player

[Marko Lindqvist]

Follow-up Comment #2, bug #21037 (project freeciv):

> Did you turn of AI mode after you took it?

Yes. And did another test where AI control was turned off *before* I took it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21037] Meeting not opened when /take player

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, bug #21037 (project freeciv):

>  But meeting dialog did not open once I had /taken the AI.
Did you turn of AI mode after you took it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21040] crash after building city on fortress tile

[Bo Di Bo]

URL:
  

 Summary: crash after building city on fortress tile
 Project: Freeciv
Submitted by: bodibo
Submitted on: Mon 19 Aug 2013 01:11:55 PM GMT
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: svn - revision 23210
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

See saved game - if you use the settler to build a city on the fortress tile,
the following error is reported:

in auto_arrange_workers() [cityturn.c::319]: assertion '((void *)0) !=
((pcenter)->owner)' failed.
(  23,   21) in "Southampton"[1]
Please report this message at http://gna.org/projects/freeciv/
in auto_arrange_workers() [cityturn.c::398]: assertion '((void *)0) !=
((pcenter)->owner)' failed.
(  23,   21) in "Southampton"[1]
Please report this message at http://gna.org/projects/freeciv/
You have founded Southampton.
in create_city() [citytools.c::1403]: assertion '((void *)0) !=
((pcenter)->owner)' failed.
(  23,   21) in "Southampton"[1]
Please report this message at http://gna.org/projects/freeciv/

Pressing turn done results in a crash.


Notes:
* Source code downloaded via svn - revision 23210:
  svn co svn://svn.gna.org/svn/freeciv/trunk freeciv
* Package installed via:
./autogen.sh --disable-nls --mandir=/usr/local/share/man --enable-client=gtk3
  make 
  make install
* freeciv started via freeciv-gtk3


Operating system:
* OpenSuSe 12.3 linux 32-bit with all updates installed



___

File Attachments:


---
Date: Mon 19 Aug 2013 01:11:55 PM GMT  Name:
freeciv-T0185-Y01350-manual.sav.gz  Size: 168kB   By: bodibo



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21039] sdl-client not compiling due to missing tile_activity_time() parameters

[Marko Lindqvist]

Update of bug #21039 (project freeciv):

  Status:None => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21039] sdl-client not compiling due to missing tile_activity_time() parameters

[Marko Lindqvist]

URL:
  

 Summary: sdl-client not compiling due to missing
tile_activity_time() parameters
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Aug 2013 03:45:11 PM EEST
Category: client-sdl
Severity: 3 - Normal
Priority: 9 - Immediate
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Fix for build error to be committed immediately.



___

File Attachments:


---
Date: Mon 19 Aug 2013 03:45:11 PM EEST  Name: SDLActTimeCompileFix.patch 
Size: 3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4096] Mapimg orientation

[Marko Lindqvist]

URL:
  

 Summary: Mapimg orientation
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Aug 2013 01:18:12 PM EEST
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

It would be nice if mapimg of ISO maps (the default) would not be rotated 45%.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21038] Replace the gtk+ DLLs to newer version

[taka]

URL:
  

 Summary: Replace the gtk+ DLLs to newer version
 Project: Freeciv
Submitted by: taka
Submitted on: 2013年08月19日 09時55分51秒
Category: client-win32
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.0-RC1
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Windows packages contains the GTK+ for Windows
which version is 2.24.10 in Freeciv 2.4.0-RC1.
There are some bugs in the version 2.24.10.
Can you replace it to more new version?
Current version is 2.24.20 for 2.24 series.

-

I can't input some texts in Freeciv 2.4.0-RC1
at Japanese input method environment. (see attachment file)

https://bugzilla.gnome.org/show_bug.cgi?id=668239
I think this bug is fixed in 2.24.12 and newer.
(I tested the gtk+ version 2.24.16, it's fine.)



___

File Attachments:


---
Date: 2013年08月19日 09時55分51秒  Name: gtkimecontext_bug.png  Size:
95kB   By: taka



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21037] Meeting not opened when /take player

[Marko Lindqvist]

URL:
  

 Summary: Meeting not opened when /take player
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Aug 2013 12:16:43 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

For reproducing a bug I needed pact between two players. AI didn't accept it,
so I tried to /take the AI player to accept myself. But meeting dialog did not
open once I had /taken the AI. Meeting certainly was still open in server's
opinion as it was not possible to open new one from the AI player and once I
/take original player back, meeting dialog was opened there.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21036] Windows unistaller not removing server

[Marko Lindqvist]

URL:
  

 Summary: Windows unistaller not removing server
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Aug 2013 11:06:54 AM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

>From http://freeciv.wikia.com/wiki/Forum:Freeciv_will_not_load_a_game/scenario
it seems that after uninstalling freeciv, server still remains.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev